Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2C51917E2 for ; Tue, 20 Aug 2024 14:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162941; cv=none; b=mgBRydXRh1LmRXcJmYIaCB76QdajuQrQMLjGRSmnRkxE6bhxXpSly6Uop8zuM7SDHk3wJqhFWNg/f+wWaUKG82ehySOtaBjby7U4+975TNeITz6HNK1th2KWOO+qi1qernCX74yCwivBJ1170bOjW7WL9uI5Zebtw2AF37kO1gI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162941; c=relaxed/simple; bh=9Segk2rEnzzYLM5UMH/BUuLN5VWq274pJxTiMZnvWZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BNAZfrqJkfTaquf4zFR1VND7ZG8GAy01SP5ZAGuiwx19t7dLzeuI8I9bl/bvWSumH5Xdo1PNGYjZukSkplDF73WS92j4ti0zXTkJTA8ZfU7rOchTBwvfi6k88gSB2y6k/WzhSeQ2nPLrX8wEfZcrDqQcLzbx8Xh3Aoq8NBLHsBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gOMq2qEV; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gOMq2qEV" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5bec78c3f85so4775763a12.1 for ; Tue, 20 Aug 2024 07:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724162937; x=1724767737; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=otzLQkR0nYuxuHzAtdMQ6ZUKW9N3q5AeXiTB9RXH6Zg=; b=gOMq2qEVQol0KrNDknOlChitHDcMJqAlli461k/USjC1apb918C/F5aO7mrAue5UV0 JSzB/mdiNjFb30HeQxCcM52vRNQBF1QiSNe4VnFpvOlb65agi9xtDl9uYIoJ+1kH3m9I 3VKgoor7GMXGNN7tbaQL7WrkxJZ1girXM8ojeeDjr1+PQQJNLwhurn53l8awsgugBxHU y413Z7VDJU7xRDW9Caawp8aUUS6YGWJrtVob3juCZ3ijqsKcmLOMFsJuC4//JkAizsqM g3KU+QI4arCi7qkUXysdF6vDYT3uE8fElXOb9dreAsND+b5WIGqQDMZTAiquIEUMSgUg Fn/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724162937; x=1724767737; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=otzLQkR0nYuxuHzAtdMQ6ZUKW9N3q5AeXiTB9RXH6Zg=; b=nO8I0PNPtafvl8GbNVXGY9ObuULKf7NI3XxnhRa+54GEdBRXkzURs9AUanZL0PrFv3 MXUifAkr4RcLsWUtDGx+VuiK522FNidW3WVJ2ZmqyhdAFjkWuXX/49bm91X5PFBsv5Bu OYnAUXKGGX5mBjMXo6cCxJxuqmaK3oVfvJU8yjP9+M4PnWhGohqwrpiRRtQQyiKyYct9 oqsBcjkCyn1z2DoYnt+aw9gtO87waFLbh70D01i6iqV1pXK4bE6BLKP6UzYwORjIMhSK kN+DcxXzHeNFzDXimL+pdPyHiZNIWFfUQQk/nOTS+NIWigxPfc+ZaOcCq3GRXGlLwYU+ Dl8A== X-Forwarded-Encrypted: i=1; AJvYcCWUgTSbpfxRvfxrfMTSwgXgotasKXovYGdj+B583UCHUDksz+9/M0A5U6/E7z6LaOdjZbZs4LNOmreNfagdOw4hJGHK+bvWEgBe2nc= X-Gm-Message-State: AOJu0YwMFTd0PcwyICoKDeN3sqlOto8LUqZ73CEqcEIlq3uFNmbCkEYR QwJNHtSu/xVB+bv8nYX+deflcNmyJv5ahC1PhLO9D+SeSupfjDLqVMQssVC+kJY= X-Google-Smtp-Source: AGHT+IG7K42OljGwNDca7BpbBxc9a8ncIPw07BdbgCTDcGsV9LoXCrbLowXk7thOJpwhbZD0g4Oa7w== X-Received: by 2002:aa7:c54d:0:b0:5a4:6dec:cd41 with SMTP id 4fb4d7f45d1cf-5beca76e4ebmr8107111a12.28.1724162936808; Tue, 20 Aug 2024 07:08:56 -0700 (PDT) Received: from pathway.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bebbdfad42sm6871687a12.47.2024.08.20.07.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2024 07:08:56 -0700 (PDT) Date: Tue, 20 Aug 2024 16:08:54 +0200 From: Petr Mladek To: Ira Weiny Cc: Dave Jiang , Fan Ni , Jonathan Cameron , Navneet Singh , Chris Mason , Josef Bacik , David Sterba , Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , Dan Williams , Davidlohr Bueso , Alison Schofield , Vishal Verma , linux-btrfs@vger.kernel.org, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range Message-ID: References: <20240816-dcd-type2-upstream-v3-0-7c9b96cba6d7@intel.com> <20240816-dcd-type2-upstream-v3-2-7c9b96cba6d7@intel.com> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240816-dcd-type2-upstream-v3-2-7c9b96cba6d7@intel.com> On Fri 2024-08-16 09:44:10, Ira Weiny wrote: > The use of struct range in the CXL subsystem is growing. In particular, > the addition of Dynamic Capacity devices uses struct range in a number > of places which are reported in debug and error messages. > > To wit requiring the printing of the start/end fields in each print > became cumbersome. Dan Williams mentions in [1] that it might be time > to have a print specifier for struct range similar to struct resource > > A few alternatives were considered including '%pn' for 'print raNge' but > %par follows that struct range is most often used to store a range of > physical addresses. So use '%par' for 'print address range'. > > --- a/Documentation/core-api/printk-formats.rst > +++ b/Documentation/core-api/printk-formats.rst > @@ -231,6 +231,20 @@ width of the CPU data path. > > Passed by reference. > > +Struct Range > +------------ > + > +:: > + > + %par [range 0x60000000-0x6fffffff] or It seems that it is always 64-bit. It prints: struct range { u64 start; u64 end; }; > + [range 0x0000000060000000-0x000000006fffffff] > + > +For printing struct range. A variation of printing a physical address is to > +print the value of struct range which are often used to hold a physical address > +range. > + > +Passed by reference. > + > DMA address types dma_addr_t > ---------------------------- > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 2d71b1115916..c132178fac07 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1140,6 +1140,39 @@ char *resource_string(char *buf, char *end, struct resource *res, > return string_nocheck(buf, end, sym, spec); > } > > +static noinline_for_stack > +char *range_string(char *buf, char *end, const struct range *range, > + struct printf_spec spec, const char *fmt) > +{ > +#define RANGE_PRINTK_SIZE 16 > +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) > +#define RANGE_PRINT_BUF_SIZE sizeof("[range - ]") I think that it should be "[range -]" > + char sym[RANGE_DECODED_BUF_SIZE + RANGE_PRINT_BUF_SIZE]; > + char *p = sym, *pend = sym + sizeof(sym); > + > + static const struct printf_spec str_spec = { > + .field_width = -1, > + .precision = 10, > + .flags = LEFT, > + }; Is this really needed? What about using "default_str_spec" instead? > + static const struct printf_spec range_spec = { > + .base = 16, > + .field_width = RANGE_PRINTK_SIZE, > + .precision = -1, > + .flags = SPECIAL | SMALL | ZEROPAD, > + }; > + > + *p++ = '['; > + p = string_nocheck(p, pend, "range ", str_spec); > + p = number(p, pend, range->start, range_spec); > + *p++ = '-'; > + p = number(p, pend, range->end, range_spec); > + *p++ = ']'; > + *p = '\0'; > + > + return string_nocheck(buf, end, sym, spec); > +} > + > static noinline_for_stack > char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec, > const char *fmt) Also add a selftest into lib/test_printf.c, please. Best Regards, Petr