Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D90D21E378D for ; Wed, 30 Oct 2024 23:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730330093; cv=none; b=FvZGb4yAOAvHklSRtsEj19EtUUcnvTdFibZez4b8lwE1Pni626fVDotqhGPYN7FOaa7w8np1FNO8YMnbVBxMd4A6Pw78E3iJJoj7j27BAQnDnVBrjAbTn2uWmPWunzdtOxMAp4rlIgYQkdez7kGtm57Ymbp6Z2wysf15uzcUIc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730330093; c=relaxed/simple; bh=JDbX1Flj8wPZLpIhhFjNuGcJZ1lDvQaSiLchnKzAPb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQXrEAjdC/LXAwYoCd8gEYwueiJSfkanCp9BKuwH9wwq/skjZ/GvfYz3uteXYNm+9wvTXfZZzxTYRxXO4lplpzCV4D2t3KdIK77+nptmEq6mXTRsRwZxSwqna7WLIJwogW7n+C6/oi9uqPRhB6oOmdxrNtsT1kmMyYGYDmAceUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ow8GXlbH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ow8GXlbH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91255C4CECF; Wed, 30 Oct 2024 23:14:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730330093; bh=JDbX1Flj8wPZLpIhhFjNuGcJZ1lDvQaSiLchnKzAPb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ow8GXlbHkLnHYqO1sEM5uYvqSr49dLqmBSgV7OJWHYrxZrQ9/luAoOPI1kQBqKJrw zy88+JNnuTwz0nqI5D8CPS4dhFFOTLKXf++JAcMwFRkDPdA2XPwB/rOmDRyBZOla6M 12P7Rrs+caAVKyimkoMZtFipZ8PO2YoAmOxUiBp4Qcna9OHazR2NxmoqwwNzll1N3b 9RUz7I2bjB2gR+Np34Slq7teg9HIA0fQdpVNwPDDhLVP7cu59/RMC96HOmb9UEDfqM cz+U1bwjc6PSPCb4XMI4UuiEDbBUwlPczolxa0uvpfdwWEWH8+Gpgb28pYhDf3ioqi Wwg33HmEBl64g== Date: Wed, 30 Oct 2024 13:14:52 -1000 From: Tejun Heo To: Yonghong Song Cc: bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, Martin KaFai Lau Subject: Re: [PATCH bpf-next v7 8/9] bpf: Support private stack for struct_ops progs Message-ID: References: <20241029221637.264348-1-yonghong.song@linux.dev> <20241029221718.268017-1-yonghong.song@linux.dev> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241029221718.268017-1-yonghong.song@linux.dev> Hello, On Tue, Oct 29, 2024 at 03:17:18PM -0700, Yonghong Song wrote: > For struct_ops progs, whether a particular prog will use private stack > or not (prog->aux->use_priv_stack) will be set before actual insn-level > verification for that prog. One particular implementation is to > piggyback on struct_ops->check_member(). The next patch will have an > example for this. The struct_ops->check_member() will set > prog->aux->use_priv_stack to be true which enables private stack > usage with ignoring BPF_PRIV_STACK_MIN_SIZE limit. > > If use_priv_stack is true for a particular struct_ops prog, bpf > trampoline will need to do recursion checks (one level at this point) > to avoid stack overwrite. > > Signed-off-by: Yonghong Song From sched_ext usage POV: Acked-by: Tejun Heo Thanks. -- tejun