Content-Type: multipart/mixed; boundary="===============4507147781482085204==" MIME-Version: 1.0 From: vishnu To: kbuild-all@lists.01.org Subject: Re: [RESEND PATCH v5 6/6] ASoC: amd: Added ACP3x system resume and runtime pm (fwd) Date: Mon, 18 Nov 2019 14:28:07 +0530 Message-ID: In-Reply-To: List-Id: --===============4507147781482085204== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 17/11/19 4:40 PM, Julia Lawall wrote: > Line 179 needs to cleanup everything that needed to be cleaned up in the > previous error handling code (line 173) as well as adding an iounmap. But > maybe you could have used a devm function to avoid the need for the > iounmap. > = > Also functions should have blank lines between them. That is why this > report contains lots of function definitions, and not just the one with > the problem. > = > julia Hi Julia, This is not latest version.I have already send V6 version. The comment which you gave is for v5 old version. Thanks, Vishnu > ---------- Forwarded message ---------- > Date: Sun, 17 Nov 2019 13:55:47 +0800 > From: kbuild test robot > To: kbuild(a)lists.01.org > Cc: Julia Lawall > Subject: Re: [RESEND PATCH v5 6/6] ASoC: amd: Added ACP3x system resume a= nd > runtime pm > = > CC: kbuild-all(a)lists.01.org > In-Reply-To: <1573629249-13272-7-git-send-email-Vishnuvardhanrao.Ravulapa= ti@amd.com> > References: <1573629249-13272-7-git-send-email-Vishnuvardhanrao.Ravulapat= i@amd.com> > CC: > = > Hi Ravulapati, > = > Thank you for the patch! Perhaps something to improve: > = > [auto build test WARNING on asoc/for-next] > [cannot apply to v5.4-rc7 next-20191115] > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://stackoverflow.com/a/374= 06982] > = > url: https://github.com/0day-ci/linux/commits/Ravulapati-Vishnu-vardha= n-rao/ASoC-amd-Create-multiple-I2S-platform-device-Endpoint/20191113-230604 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git= for-next > :::::: branch date: 4 days ago > :::::: commit date: 4 days ago > = > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > Reported-by: Julia Lawall > = >>> sound/soc/amd/raven/pci-acp3x.c:179:2-8: ERROR: missing iounmap; iorema= p on line 170 and execution via conditional on line 178 > = > # https://github.com/0day-ci/linux/commit/bfd341330019202bd0a17caa808937c= 88d536e58 > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout bfd341330019202bd0a17caa808937c88d536e58 > vim +179 sound/soc/amd/raven/pci-acp3x.c > = > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 24 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 25 static int = acp3x_power_on(void __iomem *acp3x_base) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 26 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 27 u32 val; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 28 u32 timeou= t =3D 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 29 int ret = =3D 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 30 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 31 val =3D rv= _readl(acp3x_base + mmACP_PGFSM_STATUS); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 32 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 33 if (val = =3D=3D 0) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 34 return va= l; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 35 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 36 if (!((val= & ACP_PGFSM_STATUS_MASK) =3D=3D > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 37 ACP_POW= ER_ON_IN_PROGRESS)) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 38 rv_writel= (ACP_PGFSM_CNTL_POWER_ON_MASK, > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 39 acp3x_ba= se + mmACP_PGFSM_CONTROL); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 40 while (++t= imeout < DELAY) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 41 val =3D = rv_readl(acp3x_base + mmACP_PGFSM_STATUS); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 42 if (!val) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 43 break; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 44 udelay(1); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 45 if (timeo= ut > 500) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 46 pr_err("= ACP is Not Powered ON\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 47 return -= ETIMEDOUT; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 48 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 49 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 50 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 51 static int = acp3x_power_off(void __iomem *acp3x_base) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 52 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 53 u32 val; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 54 u32 timeou= t =3D 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 55 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 56 rv_writel(= ACP_PGFSM_CNTL_POWER_OFF_MASK, > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 57 acp3x_ba= se + mmACP_PGFSM_CONTROL); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 58 while (++t= imeout < DELAY) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 59 val =3D = rv_readl(acp3x_base + mmACP_PGFSM_STATUS); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 60 if ((val = & ACP_PGFSM_STATUS_MASK) =3D=3D ACP_POWERED_OFF) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 61 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 62 udelay(1); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 63 if (timeo= ut > 500) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 64 pr_err("= ACP is Not Powered OFF\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 65 return -= ETIMEDOUT; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 66 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 67 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 68 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 69 static int = acp3x_reset(void __iomem *acp3x_base) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 70 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 71 u32 val, t= imeout; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 72 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 73 rv_writel(= 1, acp3x_base + mmACP_SOFT_RESET); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 74 timeout = =3D 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 75 while (++t= imeout < DELAY) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 76 val =3D r= v_readl(acp3x_base + mmACP_SOFT_RESET); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 77 if ((val = & ACP3x_SOFT_RESET__SoftResetAudDone_MASK) || > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 78 time= out > 100) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 79 if (val = & ACP3x_SOFT_RESET__SoftResetAudDone_MASK) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 80 break; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 81 return -= ENODEV; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 82 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 83 cpu_relax= (); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 84 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 85 rv_writel(= 0, acp3x_base + mmACP_SOFT_RESET); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 86 timeout = =3D 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 87 while (++t= imeout < DELAY) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 88 val =3D r= v_readl(acp3x_base + mmACP_SOFT_RESET); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 89 if (!val) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 90 break; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 91 if (timeo= ut > 100) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 92 return -= ENODEV; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 93 cpu_relax= (); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 94 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 95 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 96 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 97 static int = acp3x_init(void __iomem *acp3x_base) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 98 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 99 int ret; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 100 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 101 /* power o= n */ > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 102 ret =3D ac= p3x_power_on(acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 103 if (ret) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 104 pr_err("A= CP3x power on failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 105 return re= t; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 106 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 107 /* Reset */ > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 108 ret =3D ac= p3x_reset(acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 109 if (ret) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 110 pr_err("A= CP3x reset failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 111 return re= t; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 112 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 113 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 114 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 115 static int = acp3x_deinit(void __iomem *acp3x_base) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 116 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 117 int ret; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 118 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 119 /* Reset */ > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 120 ret =3D ac= p3x_reset(acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 121 if (ret) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 122 pr_err("A= CP3x reset failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 123 return re= t; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 124 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 125 /* power o= ff */ > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 126 ret =3D ac= p3x_power_off(acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 127 if (ret) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 128 pr_err("A= CP3x power off failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 129 return re= t; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 130 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 131 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 132 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 133 static int = snd_acp3x_probe(struct pci_dev *pci, > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 134 const= struct pci_device_id *pci_id) > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 135 { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 136 int ret; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 137 u32 addr, = val, i; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 138 struct acp= 3x_dev_data *adata; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 139 struct pla= tform_device_info pdevinfo[ACP3x_DEVS]; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 140 unsigned i= nt irqflags; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 141 > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 142 if (pci_en= able_device(pci)) { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 143 dev_err(&= pci->dev, "pci_enable_device failed\n"); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 144 return -E= NODEV; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 145 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 146 > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 147 ret =3D pc= i_request_regions(pci, "AMD ACP3x audio"); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 148 if (ret < = 0) { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 149 dev_err(&= pci->dev, "pci_request_regions failed\n"); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 150 goto disa= ble_pci; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 151 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 152 > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 153 adata =3D = devm_kzalloc(&pci->dev, sizeof(struct acp3x_dev_data), > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 154 GFP= _KERNEL); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 155 if (!adata= ) { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 156 ret =3D -= ENOMEM; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 157 goto rele= ase_regions; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 158 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 159 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 160 /* check f= or msi interrupt support */ > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 161 ret =3D pc= i_enable_msi(pci); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 162 if (ret) > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 163 /* msi is= not enabled */ > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 164 irqflags = =3D IRQF_SHARED; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 165 else > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 166 /* msi is= enabled */ > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 167 irqflags = =3D 0; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 168 > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 169 addr =3D p= ci_resource_start(pci, 0); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 @170 adata->acp= 3x_base =3D ioremap(addr, pci_resource_len(pci, 0)); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 171 if (!adata= ->acp3x_base) { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 172 ret =3D -= ENOMEM; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 173 goto rele= ase_regions; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 174 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 175 pci_set_ma= ster(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 176 pci_set_dr= vdata(pci, adata); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 177 ret =3D ac= p3x_init(adata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 @178 if (ret) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 @179 return -E= NODEV; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 180 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 181 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 182 val =3D rv= _readl(adata->acp3x_base + mmACP_I2S_PIN_CONFIG); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 183 switch (va= l) { > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 184 case I2S_M= ODE: > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 185 adata->re= s =3D devm_kzalloc(&pci->dev, > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 186 size= of(struct resource) * 4, > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 187 GFP_= KERNEL); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 188 if (!adat= a->res) { > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 189 ret =3D = -ENOMEM; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 190 goto unm= ap_mmio; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 191 } > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 192 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 193 adata->re= s[0].name =3D "acp3x_i2s_iomem"; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 194 adata->re= s[0].flags =3D IORESOURCE_MEM; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 195 adata->re= s[0].start =3D addr; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 196 adata->re= s[0].end =3D addr + (ACP3x_REG_END - ACP3x_REG_START); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 197 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 198 adata->re= s[1].name =3D "acp3x_i2s_sp"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 199 adata->re= s[1].flags =3D IORESOURCE_MEM; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 200 adata->re= s[1].start =3D addr + ACP3x_I2STDM_REG_START; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 201 adata->re= s[1].end =3D addr + ACP3x_I2STDM_REG_END; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 202 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 203 adata->re= s[2].name =3D "acp3x_i2s_bt"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 204 adata->re= s[2].flags =3D IORESOURCE_MEM; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 205 adata->re= s[2].start =3D addr + ACP3x_BT_TDM_REG_START; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 206 adata->re= s[2].end =3D addr + ACP3x_BT_TDM_REG_END; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 207 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 208 adata->re= s[3].name =3D "acp3x_i2s_irq"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 209 adata->re= s[3].flags =3D IORESOURCE_IRQ; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 210 adata->re= s[3].start =3D pci->irq; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 211 adata->re= s[3].end =3D adata->res[3].start; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 212 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 213 adata->ac= p3x_audio_mode =3D ACP3x_I2S_MODE; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 214 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 215 memset(&p= devinfo, 0, sizeof(pdevinfo)); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 216 pdevinfo[= 0].name =3D "acp3x_rv_i2s_dma"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 217 pdevinfo[= 0].id =3D 0; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 218 pdevinfo[= 0].parent =3D &pci->dev; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 219 pdevinfo[= 0].num_res =3D 4; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 220 pdevinfo[= 0].res =3D &adata->res[0]; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 221 pdevinfo[= 0].data =3D &irqflags; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 222 pdevinfo[= 0].size_data =3D sizeof(irqflags); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 223 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 224 pdevinfo[= 1].name =3D "acp3x_i2s_playcap"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 225 pdevinfo[= 1].id =3D 0; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 226 pdevinfo[= 1].parent =3D &pci->dev; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 227 pdevinfo[= 1].num_res =3D 1; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 228 pdevinfo[= 1].res =3D &adata->res[1]; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 229 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 230 pdevinfo[= 2].name =3D "acp3x_i2s_playcap"; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 231 pdevinfo[= 2].id =3D 1; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 232 pdevinfo[= 2].parent =3D &pci->dev; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 233 pdevinfo[= 2].num_res =3D 1; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 234 pdevinfo[= 2].res =3D &adata->res[2]; > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 235 for (i = =3D 0; i < ACP3x_DEVS ; i++) { > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 236 adata->p= dev[i] =3D > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 237 platfor= m_device_register_full(&pdevinfo[i]); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 238 if (IS_E= RR(adata->pdev[i])) { > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 239 dev_err= (&pci->dev, "cannot register %s device\n", > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 240 pdevin= fo[i].name); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 241 ret =3D= PTR_ERR(adata->pdev[i]); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 242 goto un= map_mmio; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 243 } > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 244 } > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 245 break; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 246 default: > 00347e4ea8ca4c Colin Ian King 2018-11-16 247 dev_err(&= pci->dev, "Invalid ACP audio mode : %d\n", val); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 248 ret =3D -= ENODEV; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 249 goto unma= p_mmio; > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 250 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 251 pm_runtime= _set_autosuspend_delay(&pci->dev, 10000); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 252 pm_runtime= _use_autosuspend(&pci->dev); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 253 pm_runtime= _set_active(&pci->dev); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 254 pm_runtime= _put_noidle(&pci->dev); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 255 pm_runtime= _enable(&pci->dev); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 256 return 0; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 257 > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 258 unmap_mmio: > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 259 ret =3D ac= p3x_deinit(adata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 260 if (ret) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 261 dev_err(&= pci->dev, "ACP de-init failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 262 else > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 263 dev_info(= &pci->dev, "ACP de-initialized\n"); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 264 pci_disabl= e_msi(pci); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 265 for (i =3D= 0 ; i < ACP3x_DEVS ; i++) > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 266 platform_= device_unregister(adata->pdev[i]); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 267 kfree(adat= a->res); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 268 iounmap(ad= ata->acp3x_base); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 269 release_reg= ions: > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 270 pci_releas= e_regions(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 271 disable_pci: > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 272 pci_disabl= e_device(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 273 > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 274 return ret; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 275 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 276 static int = snd_acp3x_suspend(struct device *dev) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 277 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 278 int status; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 279 struct acp= 3x_dev_data *adata =3D dev_get_drvdata(dev); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 280 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 281 status =3D= acp3x_deinit(adata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 282 if (status) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 283 dev_err(d= ev, "ACP de-init failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 284 else > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 285 dev_info(= dev, "ACP de-initialized\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 286 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 287 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 288 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 289 static int = snd_acp3x_resume(struct device *dev) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 290 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 291 int status; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 292 struct acp= 3x_dev_data *adata =3D dev_get_drvdata(dev); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 293 > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 294 status =3D= acp3x_init(adata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 295 if (status= ) { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 296 dev_err(d= ev, "ACP init failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 297 return st= atus; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 298 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 299 return 0; > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 300 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 301 static cons= t struct dev_pm_ops acp3x_pm =3D { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 302 .runtime_s= uspend =3D snd_acp3x_suspend, > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 303 .runtime_r= esume =3D snd_acp3x_resume, > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 304 .resume = =3D snd_acp3x_resume, > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 305 }; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 306 static void= snd_acp3x_remove(struct pci_dev *pci) > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 307 { > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 308 int i, ret; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 309 struct acp= 3x_dev_data *adata =3D pci_get_drvdata(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 310 > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 311 if (adata-= >acp3x_audio_mode =3D=3D ACP3x_I2S_MODE) { > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 312 for (i = =3D 0 ; i < ACP3x_DEVS ; i++) > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 313 platform= _device_unregister(adata->pdev[i]); > 79701559637a30 Ravulapati Vishnu vardhan rao 2019-11-13 314 } > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 315 ret =3D ac= p3x_deinit(adata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 316 if (ret) > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 317 dev_err(&= pci->dev, "ACP de-init failed\n"); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 318 else > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 319 dev_info(= &pci->dev, "ACP de-initialized\n"); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 320 iounmap(ad= ata->acp3x_base); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 321 pm_runtime= _disable(&pci->dev); > bfd34133001920 Ravulapati Vishnu vardhan rao 2019-11-13 322 pm_runtime= _get_noresume(&pci->dev); > 7894a7e7ea3de6 Vijendar Mukunda 2018-11-12 323 pci_disabl= e_msi(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 324 pci_releas= e_regions(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 325 pci_disabl= e_device(pci); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 326 } > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 327 static cons= t struct pci_device_id snd_acp3x_ids[] =3D { > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 328 { PCI_DEVI= CE(PCI_VENDOR_ID_AMD, 0x15e2), > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 329 .class =3D= PCI_CLASS_MULTIMEDIA_OTHER << 8, > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 330 .class_mas= k =3D 0xffffff }, > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 331 { 0, }, > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 332 }; > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 333 MODULE_DEVI= CE_TABLE(pci, snd_acp3x_ids); > e30d9128def6ca Maruthi Srinivas Bayyavarapu 2018-11-12 334 > = > --- > 0-DAY kernel test infrastructure Open Source Technology C= enter > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corp= oration >=20 --===============4507147781482085204==--