From: "plaisthos (Code Review)" Date: Thu, 4 Jan 2024 12:45:54 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ISMjSy/xbT0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , flichtenheld , openvpn-devel --ISMjSy/xbT0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/460?usp=3Demail ) Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 8: (1 comment) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/46b9a5e4_f4d733cf : PS8, Line 1809: return (ret && memcmp(out, expected_out, sizeof(out)) != =3D 0); > It pains me to return to "-2" again, but there is something really weird = going on here - to see what [=E2=80=A6] O my got I really butchered that one. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 04 Jan 2024 12:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --ISMjSy/xbT0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/crypto.c:

    • Patch Set #8, Line 1809:= return (ret &&= memcmp(out, expected_out, sizeof(out)) !=3D 0);

      It p= ains me to return to "-2" again, but there is something really we= ird going on here - to see what [=E2=80=A6]

      O my got I really butchered tha= t one.

To view, visit change 460. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 04 Jan 2024 12:45:54= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--ISMjSy/xbT0=--