Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 019BBC433EF for ; Mon, 21 Mar 2022 03:20:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F4DC83AC8; Mon, 21 Mar 2022 04:20:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="E9FTMt3n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 80D0C80FEC; Mon, 21 Mar 2022 04:20:44 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe06::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB58E83AC8 for ; Mon, 21 Mar 2022 04:20:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YhLQeTQb93aodhuUofoCltHf28qkGeB8lqc1LwPdrxIDt+63DsvPXdhl+JNPOuPO41uQhzyvarFzC2Ygo8kmygNTnXTKvTG0PFtspGZOow4LLzBB/8jTsvGwkvo7W5/6ZdzNbHe3/5gREz+jzYc6grk3jQIhaWU9kuz6+wylglotgfs1Cwr8fVtUMWhwccY73c6QDZ4Lyx0iAsixuVj2mw7JkNg9RwAGW9C2ML1a8LTR3QUx06RDgrIs/7Yv9clNaIc6EDfxAhFcC6c1baGtV9+6+76kSyI0KgfWiG9PigM4wGAJ+gQaAaTBZIcrQQXgDTPvzaMgrFL0Nzj31A6hMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wHgY0gl/M5l0+PMfUPAPYG/qh1LRuYUqmwP6bR3aWdc=; b=JyS6iMR5ec8CuduFpUa3GMTHOFeobaChnHZemddZSSOYphUqx5H+H5Lqp8Q+yyZwStNd0tmr5eBIRvO1Vgz6HdgG8gFkZU8aXd6XJtYhsNJ4P/t/O6R8nTG/eFBX0LUWOZy4beSDNKVwQl5QeXDd4v9eRcr3vFucR0v87MgdOB5+ybORUqOo69o0kjs1u3dkDRWm6b9I9wDnFfT03YnjKitCNGkB8p41hP5W/sn4nGJkTH4yUuzpn7308nTxN59orGTttwR9eNcOhXqKOwE1Yfc6snLHNf8nU+9kxCYTHSGcj7j9Kxx4z/Ee6fUy/jVNXnflzlCLQQE64xy+egOIyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHgY0gl/M5l0+PMfUPAPYG/qh1LRuYUqmwP6bR3aWdc=; b=E9FTMt3n2BsCGo4nbfSagOx1Ek40UnirSmLWNC0mU+2ZYsgvLz1NehWrDsj2kotQdoitDypwP9rf8HNJo1CsPcnBS9rnV8No99uENV8KaYXUjFrKHOgHcYZVr7A11h/9rxjYgghvZwgxaz3DVL3hz/5agCCQVh0M/0pHofjzR9k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VE1PR04MB7214.eurprd04.prod.outlook.com (2603:10a6:800:1a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.22; Mon, 21 Mar 2022 03:20:38 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::cd28:b224:dbce:5f5e]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::cd28:b224:dbce:5f5e%7]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 03:20:38 +0000 Subject: Re: [PATCH] imx: imx8mm/imx8mn_beacon: Remove redundant code To: Adam Ford , u-boot@lists.denx.de Cc: sbabic@denx.de References: <20220223135051.27707-1-aford173@gmail.com> From: "Peng Fan (OSS)" Message-ID: Date: Mon, 21 Mar 2022 11:20:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20220223135051.27707-1-aford173@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0132.apcprd03.prod.outlook.com (2603:1096:4:91::36) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 748761c5-6d30-43ba-f074-08da0ae9c589 X-MS-TrafficTypeDiagnostic: VE1PR04MB7214:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FGYvtXeSz3ebii6RPEhVCJ5C5AL43Bdj7dVa5+nS+D7pBzWk5E0KO0kNobPvvLrAG3BeapWOSgQhvwj8Ag6CSxf2aai6zCatD86x9wt9205ryKAqwX2Lz/GJInu50kuQFWiAnMPBXer041MUQ+Qj+sGIH4K59pPcXeaxrFEeRLEl2pouMjLzAaRlCE+I+9AlLPpKweVDnDsoREjNOYKblNBquNvGsKs+weUAjJerLuBjg9pQ+kAB3M1Xq6WpILZ5hxilHyBMUhja7LW7DTfqopQu4Sjclo1ld3sQveM5IWkESbKYDHADIn5iMaQSF4J+c4k3n6arVwHIHpiBtkcVkfCTVXuP28nGIzG445E6ZEokuHbQwltXF+OL5jJBBGR2twZfDwgIJfMwG+MuXc/UszH6BgovDtudsC76SUF++F71OI/QXAoYcogZX0uHDnz0i/akLcqORdXYb/U5lqkYnAEIMCIz1AGvcpOb/oqH1MG0A6LMn0alCeo8cQA/phD5ELcCg7vyPipDRJGVAbV0WwkcLBltvdvyYpnquQhQqUMdKxxpH2EwGAPSkE3xI5giiQE4piDLNsi1Fnlg2O8HHaecF8v701daH2/GvL9enj/C029iBCJ7yaLlHgXkBLSxd31J+dr1Nu9tG3LgdWcFLGt+Attsaf472vpdusDbNYk7j7REbUtFK/aSw0XjtPTUiCToRS5wH/Cim+Ir2XKjqVvCY/jmazBeXmhYlg7G9x8X2Q1igSRtLCyDPeeg1kdXVviaWKFN1t/Brzqqqnls4f8g8inKawJM1uFt9gW9EM4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(31686004)(2616005)(316002)(26005)(4326008)(5660300002)(31696002)(86362001)(8936002)(6486002)(508600001)(38350700002)(38100700002)(2906002)(6512007)(6666004)(6506007)(66946007)(8676002)(66556008)(186003)(66476007)(53546011)(52116002)(83380400001)(32563001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3VUaXlqU3FjbnNSaFY5R3B2d1pReTE5cS9GbkFNckZ3cEhlVkpRWlIvRFRm?= =?utf-8?B?TFYxeG9WMGNMalZKUWdRejN2REtaa1hHSloxOTFkTnpJbnRpWDlUdHU1SU9n?= =?utf-8?B?dmR0RXBwMUtHdTAxMklRMUYzM1ZpRnVyS29DZ1BHSnRGbEVqRXh5OHVBNitM?= =?utf-8?B?UkZCZnlxaTVsUDdRU1NmaE5rMno2OEhuNkZ5WW94dStlRHB6MjRFeXZDUVl0?= =?utf-8?B?Z3drOFQrN3g4ampaaGV1YURIRmdVY1VEbFJpeWY2Y05scUFIdWtGc0cwaFpn?= =?utf-8?B?ejlGa0xVRFI3VjhENzhYVHpyWnp2Z3lYUzg5dVlPenBZVUI0c0MzZ2NwMEhJ?= =?utf-8?B?a3J3K1p3R0t0NXFMNEVyUm9Gd0Y5djg3N01sSDd0cEo5VzUrRytLWDBhUFJD?= =?utf-8?B?RU96VFZidnlucUtSY2ZvUkJBVWg1ZFp0bjNUbTVVM0pyUWQ0cTQvS1ZYQVNh?= =?utf-8?B?aWV3KzVyVCt5TEhJT0tQSVZUd1FFamxCWStka2FZUUdZS0xkOS82RG94eDYw?= =?utf-8?B?YlVUMEExTVZ3em5lVitsV0VObm9Uc3dIVzlxUDJhcXF4OWN4ME5ka1hFUEF0?= =?utf-8?B?US9nN2k5U3ArVVlESUFhUFhDd0ZoRXVPTEtTWElPRlZyVnV6YnZiSkgxTzdu?= =?utf-8?B?eEh6dlNqd2xRK25JZE5nNm5SMStUaTNWY0laRUgrZytRYnBHMWNnMUVmeGxS?= =?utf-8?B?UURsa2hKRitXdnh5dlVzdTBmYzdOQ2lRbjliNDlSVW5KVURRZFZwWCthckF3?= =?utf-8?B?RjdXVzgyUHN4NUlZVW5EYWJKL1d4dTlSeXB5SzBvV2R4NkhLR3E3UmZYNjN5?= =?utf-8?B?VDdKdDVpRkw5OThpdWE1Y1NPWUVSTWpDYWI1K241OWZrd2VNMm9ZZnZKdkFr?= =?utf-8?B?OHYrMmxOVHMwMWdDUTVhQ1RHUXAveGgvZC9kTHVsVTg5cHVWd0Y2MTUzWkdr?= =?utf-8?B?aE5YRUI1VHpvUUFsOXlEUDU3cmR5NkdIajZPTXhpc1B4eTNmQTd3dnVBTk1K?= =?utf-8?B?TWhZYmxXREtuZStYb1N5eG1oSTlXcWVnV1JGODA2WXlVRHhZMGFnSGpza2px?= =?utf-8?B?NldTTzYxc0xCYU0rZzJkUllzalhyL1J6a1ZabHR3anBRMWhSdi90V2Y3Nmgw?= =?utf-8?B?dWZkUGRoSW1sa3hTcnIvNmNqVjc2R3Y3eno5OUtPd21tTTBYdjlXM2pqNXgw?= =?utf-8?B?S1EyME5ZUnhHY3JmODJPcXZjQWlDRldGeWUvV05pSVBjZWdoNmxZdGNoVlJt?= =?utf-8?B?Z3lGSEVYUGZyUE0yNnI1Z1pZOVBWTnlMM2ZndUhlNHZwT3FvUTgzYkJqdUYw?= =?utf-8?B?UUFBRFRQelk1N1RFRDNZa016Qk9CbEllWUMyaUVWSFJHVW5sVkF6R084QXJE?= =?utf-8?B?a1dvNXFzT1hncUV3bEYzYkRBeDJodzZiSEZ4UGVvbHRkRzdyQW5pZGxrMG1k?= =?utf-8?B?enVEVEFpVExjUFNKd2tMTGhSVXpvWHF0NUp0eVRCeXFVL1BlVXZTbFlNcnlp?= =?utf-8?B?WXRxR3M4MHN3Z2VZNG9ObVNnVG5KOWUwcWgzaTZ3YnBSZFFBdU8rdFk4UUI3?= =?utf-8?B?R0dyaVVsWmFJRytaTHlVMGNBeElwZlpreGc2RTBMVnNOY09DRU9paVE4MDlt?= =?utf-8?B?RGR2TmtxdjIrVXBCQThicXhQcHZjQW9VR0RQeThrNUxpVEZDOWptcnNVSTU1?= =?utf-8?B?WThOdEhIYWxSUWhsUU1ZT0hONHJURHduTEpZRnBQVE5GcmlIVUtNbXNtTjdG?= =?utf-8?B?TGk1KzVzSE9zYVBDNE9OR21IRnY0c3FDWVJYREdnRThtSnNmNGY5dHZIM0pi?= =?utf-8?B?Ny9Td0krNk10aW5oTXpFYVRsS3BLeFFXcjBPd1dwTjZQSVFkNndFcEVGc2oz?= =?utf-8?B?M00wblQ5cCtQbmFuTGFSVkRrdWtrM2pXNGgvSFo1WVhaNVk1ZzExcVY5MXRS?= =?utf-8?Q?qpsFeAKtRmw9Xvi+X+1+xFxCCNvfuxUO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 748761c5-6d30-43ba-f074-08da0ae9c589 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 03:20:38.5717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2chVwhXIJwAg26dQceHuqFq5rxRebcxgrw7vykZ7JmC1QwvTWe7dr4HUgdLs4IXl5Y56AeTH7aws4YWdKqQQ5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7214 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2022/2/23 21:50, Adam Ford wrote: > The Ethernet controller and PHY use the device tree info to > configure themselves, so it's not necessary to manually do it > in the board file. This permits the removal of a bunch of headers > as well. > > Signed-off-by: Adam Ford Acked-by: Peng Fan > > diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c > index c228bbf777..204235a3f8 100644 > --- a/board/beacon/imx8mm/imx8mm_beacon.c > +++ b/board/beacon/imx8mm/imx8mm_beacon.c > @@ -1,52 +1,13 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * Copyright 2020 Compass Electronics Group, LLC > + * Copyright 2022 Logic PD, Inc. dba Beacon EmbeddedWorks > */ > > -#include > -#include > -#include > #include > > -#include > -#include > -#include > - > DECLARE_GLOBAL_DATA_PTR; > > -#if IS_ENABLED(CONFIG_FEC_MXC) > -static int setup_fec(void) > -{ > - struct iomuxc_gpr_base_regs *gpr = > - (struct iomuxc_gpr_base_regs *)IOMUXC_GPR_BASE_ADDR; > - > - /* Use 125M anatop REF_CLK1 for ENET1, not from external */ > - clrsetbits_le32(&gpr->gpr[1], 0x2000, 0); > - > - return 0; > -} > - > -int board_phy_config(struct phy_device *phydev) > -{ > - /* enable rgmii rxc skew and phy mode select to RGMII copper */ > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8); > - > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100); > - > - if (phydev->drv->config) > - phydev->drv->config(phydev); > - return 0; > -} > -#endif > - > int board_init(void) > { > - if (IS_ENABLED(CONFIG_FEC_MXC)) > - setup_fec(); > - > return 0; > } > diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c > index 6397dac872..204235a3f8 100644 > --- a/board/beacon/imx8mn/imx8mn_beacon.c > +++ b/board/beacon/imx8mn/imx8mn_beacon.c > @@ -1,52 +1,13 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * Copyright 2020 Compass Electronics Group, LLC > + * Copyright 2022 Logic PD, Inc. dba Beacon EmbeddedWorks > */ > > -#include > -#include > -#include > - > -#include > -#include > #include > -#include > > DECLARE_GLOBAL_DATA_PTR; > > -#if IS_ENABLED(CONFIG_FEC_MXC) > -static int setup_fec(void) > -{ > - struct iomuxc_gpr_base_regs *gpr = > - (struct iomuxc_gpr_base_regs *)IOMUXC_GPR_BASE_ADDR; > - > - /* Use 125M anatop REF_CLK1 for ENET1, not from external */ > - clrsetbits_le32(&gpr->gpr[1], 0x2000, 0); > - > - return 0; > -} > - > -int board_phy_config(struct phy_device *phydev) > -{ > - /* enable rgmii rxc skew and phy mode select to RGMII copper */ > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8); > - > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05); > - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100); > - > - if (phydev->drv->config) > - phydev->drv->config(phydev); > - return 0; > -} > -#endif > - > int board_init(void) > { > - if (IS_ENABLED(CONFIG_FEC_MXC)) > - setup_fec(); > - > return 0; > } >