Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0530278168 for ; Wed, 23 Apr 2025 14:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745416903; cv=none; b=GrN/Ayz8IsnGCPlPv/zulKRjtpJygyQcxDKn6wP4mr1Yg2FnFuW+pLi9GvoHUbhuYmUaQHC+NaFSDHaGqEbxDfjIQ05EfFG6SiqCEIWhWhSYnXFPPxjE2CCXH7SjqQkcuGXQdZddzkMg70dPgmeXJCNXAmmuTiR67ACwhDtjF+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745416903; c=relaxed/simple; bh=GtL8sD4JAXfkMYBcX9cTSrlhTyZpfxVhMwjIALtdbfs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mUXguPfa4QOMPzpIl2vJOleouKxWTjJE4zNLAhMUpwFZglIqJTmvLMJK98qc9Lm3a0XMVPD/aLnoXW2IKWa0rf/36CP6vlh09Q/XGO+L3SfqVqssbasrAUT3jRxDXDUOm9Iq3cL+NeeWUL4hKwEENckblr6StSxdd/lBN+FeR4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JGt1JQgV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JGt1JQgV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8DE6C4CEE2; Wed, 23 Apr 2025 14:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745416903; bh=GtL8sD4JAXfkMYBcX9cTSrlhTyZpfxVhMwjIALtdbfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JGt1JQgVWi6HQKMIk68shJHNlHcrj5t9KM7FOCTsy2bV3wmQiOGqfY5ds6jiA6xpg EOjh6/1w3NLj592y1e7np82fVXFT8Rq46D7z/obDjq2toshWW0vZvRQgXi0XX7SlWn wS8w5pUjvIU+34EVKEtjzk9l3R53ooo/6yX2oxGFnnKBej5UIOXWrNi2zYlcFXinVC u98zVCRDdL0QLFogEsNEWgWRCtgS0sI7HPpvAXyEtkQreuy1m1cKqMy2KX56OhDEsQ 6PC9HDTxYx3DXmHTrZy0qR8LADG2O0kMAkJ8RQ0U+L1xXwtpq1M8s9WPcc5a+aXMcM ovYwcRd5Uj3SA== Message-ID: Date: Wed, 23 Apr 2025 10:01:41 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/4] Add uniquifier to storage pool path To: Luis Chamberlain Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250414170546.1995982-1-cel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/23/25 2:22 AM, Luis Chamberlain wrote: > On Mon, Apr 14, 2025 at 01:05:42PM -0400, cel@kernel.org wrote: >> From: Chuck Lever >> >> I'd like to be able to run more than one instance of kdevops per >> physical host. Currently the kdevops guestfs set-up steers all >> storage pool activity into ${STORAGE_POOL}/kdevops/guestfs, which >> means there's a good change that two different logged-in users will >> create virtual machines whose names, OS base images, and block >> devices will interfere with each other. >> >> So far I haven't been able to get the other storage pool-related >> settings to add sufficient uniqueness to prevent this conflict. >> >> v2 introduces some additional clean-ups, and attempts to address >> review comments. > > I gave this a spin to see if exisitng deployments won't break but they > would right away: > > Here is me running on a debian system where we had the old setup: > > make defconfig-seltests-radix-tree KDEVOPS_HOSTS_PREFIX=x2 > make -j128 > make bringup > > User mcgrof is part of the libvirt-qemu group. > .//scripts/bringup_guestfs.sh: line 276: [: too many arguments > cp: target '}}/guestfs/x2-maple/root.raw': No such file or directory > Extra parameter on the command line: ‘libvirt_storage_pool_path’. > Try ‘virt-sysprep --help’ or consult virt-sysprep(1) for more information. > Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra0.raw', fmt=raw size=107374182400 > chmod: cannot access '{{': No such file or directory > chmod: cannot access 'libvirt_storage_pool_path': No such file or directory > chmod: cannot access '}}/{{': No such file or directory > chmod: cannot access 'kdevops_storage_pool_user': No such file or directory > chmod: cannot access '}}/guestfs/x2-maple/extra0.raw': No such file or directory > Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra1.raw', fmt=raw size=107374182400 > chmod: cannot access '{{': No such file or directory > chmod: cannot access 'libvirt_storage_pool_path': No such file or directory > chmod: cannot access '}}/{{': No such file or directory > chmod: cannot access 'kdevops_storage_pool_user': No such file or directory > chmod: cannot access '}}/guestfs/x2-maple/extra1.raw': No such file or directory > Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra2.raw', fmt=raw size=107374182400 > chmod: cannot access '{{': No such file or directory > chmod: cannot access 'libvirt_storage_pool_path': No such file or directory > chmod: cannot access '}}/{{': No such file or directory > chmod: cannot access 'kdevops_storage_pool_user': No such file or directory > chmod: cannot access '}}/guestfs/x2-maple/extra2.raw': No such file or directory > Formatting '{{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }}/guestfs/x2-maple/extra3.raw', fmt=raw size=107374182400 > chmod: cannot access '{{': No such file or directory > chmod: cannot access 'libvirt_storage_pool_path': No such file or directory > chmod: cannot access '}}/{{': No such file or directory > chmod: cannot access 'kdevops_storage_pool_user': No such file or directory > chmod: cannot access '}}/guestfs/x2-maple/extra3.raw': No such file or directory > Domain 'x2-maple' defined from .//guestfs/x2-maple/x2-maple.xml > > error: Failed to start domain 'x2-maple' > error: Cannot access storage file '/xfs1/libvirt/mcgrof/guestfs/x2-maple/root.raw': No such file or directory > > Failed to start x2-maple > make: *** [scripts/guestfs.Makefile:80: bringup_guestfs] Error 1 > > So, while I like the idea and approach, this would break tons of > deployments right now. > > Luis As I mentioned here [1], because KDEVOPS_STORAGE_POOL_PATH contains a template string: {{ libvirt_storage_pool_path }}/{{ kdevops_storage_pool_user }} not a file pathname, 4/4 won't work. I've committed 1/4 through 3/4 to linux-kdevops, and can post an updated version of 4/4 that might work better for you. But if it doesn't, then I'm open to adding a Kconfig option as you suggested. -- Chuck Lever [1] https://lore.kernel.org/kdevops/44e1183d-78a7-411c-bd1f-2e7d4e6fcb32@oracle.com/