From: "MaxF (Code Review)" Date: Sat, 28 Dec 2024 01:25:12 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0Q1bqhQsfME="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to decrypt packets anymore after 2**36 failed decryptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --0Q1bqhQsfME= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open= vpn/+/843?usp=3Demail ) Change subject: Do not attempt to decrypt packets anymore after 2**36 faile= d decryptions ...................................................................... Patch Set 2: (1 comment) File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/843/comment/06c9974a_c8419cbb : PS2, Line 672: 2**36 > IP and Ethernet packets greater than 2**10 * 16 =3D 16k are pretty rare. = [=E2=80=A6] I don't know. I thought you did consider larger packets in the OpenVPN RFC. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/843?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I81440ac28a1ad553652e201234e5ddfe03a8c190 Gerrit-Change-Number: 843 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: MaxF Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 28 Dec 2024 01:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos Comment-In-Reply-To: MaxF Gerrit-MessageType: comment --0Q1bqhQsfME= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/crypto.h:

    • Patch Set #2, Line 672: = 2**36

      IP and Ethernet packets greater than 2**10 * 16 =3D 16k are pretty rare. [= =E2=80=A6]

      I don't know. I thought you did consider larger packets in t= he OpenVPN RFC.

To view, visit change 843. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I81440ac28a1ad553652e201234e= 5ddfe03a8c190
Gerrit-Change-Number: 843
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: MaxF <max@...2606...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sat, 28 Dec 2024 01:25:12= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
Comment-In-Reply-To: MaxF <max@...2606...&g= t;
Gerrit-MessageType: comment
--0Q1bqhQsfME=--