From: Colin Xu Subject: Re: [PATCH 2/4] drm/i915: clean up virtual PCH special case handling Date: Fri, 1 Jun 2018 00:45:28 +0000 (UTC) Message-ID: References: <20180531115624.30269-1-jani.nikula@intel.com> <20180531115624.30269-3-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86BA46E41D for ; Fri, 1 Jun 2018 00:47:32 +0000 (UTC) Date: Sat, 2 Jun 2018 08:50:13 +0800 In-Reply-To: <20180531115624.30269-3-jani.nikula@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org T24gMDUvMzEvMjAxOCAwNzo1NiBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gVXNlIGludGVsX3Bj aF90eXBlKCkgYWxzbyBmb3IgbWFwcGluZyB0aGUgbm8gUENIIGNhc2UgKFBDSCBpZCAwKSB0bwo+ IFBDSF9OT05FIHRvIHNpbXBsaWZ5IGNvZGUuCj4KPiBBbHNvIG1ha2Ugc3VyZSB0aGF0IGludGVs X3BjaF90eXBlKCkga25vd3MgYWxsIHRoZSBQQ0ggaWRzIHJldHVybmVkIGJ5Cj4gaW50ZWxfdmly dF9kZXRlY3RfcGNoKCkuIExvdWRseSBmYWlsIGlmIHRoaXMgaXNuJ3QgdGhlIGNhc2U7IHRoaXMK PiBzaG91bGRuJ3QgaGFwcGVuIGFueXdheS4KPgo+IENjOiBDb2xpbiBYdSA8Q29saW4uWHVAaW50 ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwgMTMg KysrKysrLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNyBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IGM0MmUzODlhMjdmMy4u MTg0MmEwNjdhNjA0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gQEAgLTI4MiwxMyAr MjgyLDEyIEBAIHN0YXRpYyB2b2lkIGludGVsX2RldGVjdF9wY2goc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICAgCQl9IGVsc2UgaWYgKGludGVsX2lzX3ZpcnRfcGNoKGlkLCBw Y2gtPnN1YnN5c3RlbV92ZW5kb3IsCj4gICAJCQkJCSBwY2gtPnN1YnN5c3RlbV9kZXZpY2UpKSB7 Cj4gICAJCQlpZCA9IGludGVsX3ZpcnRfZGV0ZWN0X3BjaChkZXZfcHJpdik7Cj4gLQkJCWlmIChp ZCkgewo+IC0JCQkJcGNoX3R5cGUgPSBpbnRlbF9wY2hfdHlwZShkZXZfcHJpdiwgaWQpOwo+IC0J CQkJaWYgKFdBUk5fT04ocGNoX3R5cGUgPT0gUENIX05PTkUpKQo+IC0JCQkJCXBjaF90eXBlID0g UENIX05PUDsKPiAtCQkJfSBlbHNlIHsKPiAtCQkJCXBjaF90eXBlID0gUENIX05PTkU7Cj4gLQkJ CX0KPiArCQkJcGNoX3R5cGUgPSBpbnRlbF9wY2hfdHlwZShkZXZfcHJpdiwgaWQpOwo+ICsKPiAr CQkJLyogU2FuaXR5IGNoZWNrIHZpcnR1YWwgUENIIGlkICovCj4gKwkJCWlmIChXQVJOX09OKGlk ICYmIHBjaF90eXBlID09IFBDSF9OT05FKSkKPiArCQkJCWlkID0gMDsKPiArCj4gICAJCQlkZXZf cHJpdi0+cGNoX3R5cGUgPSBwY2hfdHlwZTsKPiAgIAkJCWRldl9wcml2LT5wY2hfaWQgPSBpZDsK PiAgIAkJCWJyZWFrOwoKVGVzdGVkIG9uIEJYVCBndnQtZyBhbmQgZ290IGV4cGVjdGVkIGJlaGF2 aW91ci4KClRlc3RlZC1ieTogQ29saW4gWHUgPENvbGluLlh1QGludGVsLmNvbT4KUmV2aWV3ZWQt Ynk6IENvbGluIFh1IDxDb2xpbi5YdUBpbnRlbC5jb20+CgotLSAKQmVzdCBSZWdhcmRzLApDb2xp biBYdQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==