From: "cron2 (Code Review)" Date: Tue, 14 Apr 2026 16:33:50 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9/6KBcmdAjQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: build: Use info fetched from version.m4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --9/6KBcmdAjQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1605?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: build: Use info fetched from version.m4 ...................................................................... build: Use info fetched from version.m4 Change-Id: I3157e1a228ac7058fca6a88f94076052e33d2e01 Signed-off-by: Luis Cruz Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1605 Message-Id: <20260414125637.42082-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 612.html Signed-off-by: Gert Doering --- M CMakeLists.txt M config.h.cmake.in 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/05/1605/2 diff --git a/CMakeLists.txt b/CMakeLists.txt index 198c98f..72e349c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -141,6 +141,10 @@ set(OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH}) set(OPENVPN_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE}) +set(TAP_WIN_COMPONENT_ID "${PRODUCT_TAP_WIN_COMPONENT_ID}") +set(TAP_WIN_MIN_MAJOR ${PRODUCT_TAP_WIN_MIN_MAJOR}) +set(TAP_WIN_MIN_MINOR ${PRODUCT_TAP_WIN_MIN_MINOR}) + set(CMAKE_C_STANDARD 11) # Set the various defines for config.h.cmake.in diff --git a/config.h.cmake.in b/config.h.cmake.in index a93fcd5..ae1d264 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -366,13 +366,13 @@ #undef SYSTEMD_ASK_PASSWORD_PATH /* The tap-windows id */ -#define TAP_WIN_COMPONENT_ID "tap0901" +#define TAP_WIN_COMPONENT_ID "@TAP_WIN_COMPONENT_ID@" /* The tap-windows version number is required for OpenVPN */ -#define TAP_WIN_MIN_MAJOR 9 +#define TAP_WIN_MIN_MAJOR @TAP_WIN_MIN_MAJOR@ /* The tap-windows version number is required for OpenVPN */ -#define TAP_WIN_MIN_MINOR 9 +#define TAP_WIN_MIN_MINOR @TAP_WIN_MIN_MINOR@ /* Are we running on Mac OS X? */ #cmakedefine TARGET_DARWIN -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1605?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3157e1a228ac7058fca6a88f94076052e33d2e01 Gerrit-Change-Number: 1605 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --9/6KBcmdAjQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by flichtenheld

build: Use info fetched from=
 version.m4

Change-Id: I3157e1a228ac7058fca6a88f94076052e33d2e01
= Signed-off-by: Luis Cruz <luis.cruz@...3019...>
Acked-by: Frank Li= chtenheld <frank@...2641...>
Gerrit URL: https://gerrit.openvpn.ne= t/c/openvpn/+/1605
Message-Id: <20260414125637.42082-1-frank@...2724...= ..>
URL: https://www.mail-archive.com/openvpn-devel@...282...= .net/msg36612.html
Signed-off-by: Gert Doering <gert@...1296...>---
M CMakeLists.txt
M config.h.cmake.in
2 files changed, 7 inse= rtions(+), 3 deletions(-)

git pull ssh://gerrit.=
openvpn.net:29418/openvpn refs/changes/05/1605/2
diff --git a/CMake=
Lists.txt b/CMakeLists.txt
index 198c98f..72e349c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -141,6 +141,10 @@
set(OPENVPN_VERSION_PATC= H ${PRODUCT_VERSION_PATCH})
set(OPENVPN_VERSION_RESOURCE $= {PRODUCT_VERSION_RESOURCE})

+set(TAP_WIN_COMPONENT_ID "${PRODUCT_TAP_WIN_= COMPONENT_ID}")
= +set(TAP_WIN_MIN_MAJOR ${PRODUCT_TAP_WIN_MIN_MAJOR})
+set(TAP_WIN_MIN_MINOR ${PRODUCT_TAP_WIN_M= IN_MINOR})
+ set(CMAKE_C_STANDARD 11)

# Set = the various defines for config.h.cmake.in
diff --git a/conf= ig.h.cmake.in b/config.h.cmake.in
index a93fcd5..ae1d264 10= 0644
--- a/config.h.cmake.in
+++ b/config.h= .cmake.in
@@ -366,13 +366,13 @@
#undef SYS= TEMD_ASK_PASSWORD_PATH

/* The tap-window= s id */
-#define TAP_WI= N_COMPONENT_ID "tap0901"
+#define TAP_WIN_COMPONENT_ID "@TAP_WIN_COMPONENT_ID@&qu= ot;

/* The tap-windows version number is= required for OpenVPN */
+#define TAP_WIN_MIN_MAJOR @TAP_WIN_MIN_MAJOR@
<= /span>
/* The tap-windows version number is required for OpenVPN = */
-#define TAP_WIN_MIN= _MINOR 9
+#define TAP= _WIN_MIN_MINOR @TAP_WIN_MIN_MINOR@

/* Ar= e we running on Mac OS X? */
#cmakedefine TARGET_DARWIN

To view, visit change 1605. To unsubscribe, o= r for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3157e1a228ac7058fca6a88f940= 76052e33d2e01
Gerrit-Change-Number: 1605
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --9/6KBcmdAjQ=--