References: <1519231562-5641-1-git-send-email-selva.nair@...277...> From: Arne Schwabe Message-ID: Date: Wed, 21 Feb 2018 18:00:38 +0100 MIME-Version: 1.0 In-Reply-To: <1519231562-5641-1-git-send-email-selva.nair@...277...> Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH] Disable external ec key support when building with libressl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: selva.nair@...277..., openvpn-devel@lists.sourceforge.net Am 21.02.18 um 17:46 schrieb selva.nair@...277...: > From: Selva Nair > > - This codepath uses some openssl-1.1 specific API and is enabled only > for openssl 1.1 and higher versions. But, due to incompatible > version numbering in libressl, it gets wrongly enabled with libressl > versions that do not support the reqired API. As an easy workaround > disable the feature when LIBRESSL_VERSION_NUMBER is defined. > I will reluctantly ACK this because LibreSSL will not fix their stuff. Acked-By: Arne Schwabe I have not tested this to compile but the code looks good. Arne