From: "selvanair (Code Review)" Date: Thu, 6 Jun 2024 04:50:57 +0000 In-Reply-To: References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., ssbssa@...360..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="hpdN4+FSjpM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement Windows CA template match for Crypto-API selector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ssbssa Cc: plaisthos , flichtenheld , openvpn-devel --hpdN4+FSjpM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, ssbssa. selvanair has posted comments on this change by ssbssa. ( http://gerrit.ope= nvpn.net/c/openvpn/+/621?usp=3Demail ) Change subject: Implement Windows CA template match for Crypto-API selector ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: Thanks for the changes. Looks good to me now. I have no setup to test this but I did confirm that "TMPL:" is recognized a= s a valid selector, and the code does iterate through certificates with pri= vate keys present. Acked-by: Selva Nair File src/openvpn/cryptoapi.c: http://gerrit.openvpn.net/c/openvpn/+/621/comment/66b4877b_503018f8?usp=3De= mail : PS1, Line 220: if (!info && fallback && groupid) > Done nitpick: the comment is now a bit inaccurate -- "and fallback requested" is= no longer required. May be edited at merge time. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/621?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351 Gerrit-Change-Number: 621 Gerrit-PatchSet: 2 Gerrit-Owner: ssbssa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: selvanair Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ssbssa Gerrit-Comment-Date: Thu, 06 Jun 2024 04:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ssbssa Comment-In-Reply-To: selvanair --hpdN4+FSjpM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos, ssbssa.

Patch set 2:Code-Review +2=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #2:

      Thanks for t= he changes. Looks good to me now.
      I have no setup to test this but I di= d confirm that "TMPL:" is recognized as a valid selector, and the= code does iterate through certificates with private keys present.

      Acke= d-by: Selva Nair <selva.nair@...277...>

  • File src/openvpn/cryptoapi.c:

    • Patch Set #1, Line = 220: if (!info &= ;& fallback && groupid)

      Done
      =

      nitpick: the comment is now a bit inaccurate -- "and fallback req= uested" is no longer required. May be edited at merge time.

    To view, visit change 621. To unsubscribe, or for help writing m= ail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b48= 9dbe811de5351
    Gerrit-Change-Number: 621
    Gerrit-PatchSet: 2
    Gerrit-Owner: ssbssa <ssbssa@...360...> =
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: selvanair <selva.nair@...1665...= 77...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: ssbssa <ssbssa@...360...&= gt;
    Gerrit-Comment-Date: Thu, 06 Jun 2024 04:50:57= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: ssbssa <ssbssa@...2803...= ..>
    Comment-In-Reply-To: selvanair <selva.nair@= ...277...>
    = --hpdN4+FSjpM=--