Return-Path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by mail.openembedded.org (Postfix) with ESMTP id A73BC7F921 for ; Mon, 11 Nov 2019 22:19:49 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id l4so8377353plt.13 for ; Mon, 11 Nov 2019 14:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ae7LXmMLj2gaiP6U9LRcataTudgcie6401i0kZqiU8U=; b=IS5pUit0byAjORY55r65KeFGSOGlp0qX4D44FwaQAuBH0J2E7/JNliDAetBQr6oFFT EwZxrGyXeGOzwz7e+P4DGKtIc1LjS7uV+BSNTXqPffCbpOx1rolZmDg7ZJegAxbI4W8F rne16yGXZP/WJDkDsKtbNpn4hUAg10aqjOKxYhFyFxAw3Mu3AfeAng3rE83pIsJhxNnk E0QGZMatpdHiWDqXVnXF0kebtyhcLZJo9zggooPHfJ82dFJ0710AvyKx9OE+hJ71KAWC 72DXMARqFkvD2fhvxqK2SkYYw0dmFhrzlDgQmge7jnRX3LQdYZzuFjgYMTAWZFo8C2vX MoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=ae7LXmMLj2gaiP6U9LRcataTudgcie6401i0kZqiU8U=; b=BMjL4rfolBWNqKP3QnOVrHK5qM7MXyTjTwQ2qQbHn4WwFrGzFNs946G9a4ADzGsI91 DxmWL2uKHcG/WUnK19yEzmijiaBmZ7unTY5qJAYDYrArkPuGuD3hQY5fkoLFPv4s6ghY Am7Q+WyC5h7d867DH/l4mOHj0sHJ6vwKKqg+FwLMkdOfadvRjCXMbdcRT9RA9dtQJO0w Z/Oll5fligH6H5h4rWciaUu6uUhLtJFUE0HhnrcEQxlvQxsBbXA0Z0wASg7Bh9INZgvF ut0h4TdacZkvjsj6BrJg03Ie7e6G64hOL10tqNWVXeIEq/m/I8QFRF4AfyvnQIQf6mum MeQw== X-Gm-Message-State: APjAAAX6JxM6pqLzF/5MYKrgN8apMUtTkoAAgcO0hlaJsjl9jTRosNJy PZmW/m7TDDyk/PUdlem25jM077EB X-Google-Smtp-Source: APXvYqzcBAw+MmD4S1I4icHhmtYA8w9RU1eu29LYlbFaB86v7c7W97ffRnuFbxpyC6nGY5Z43aZX0g== X-Received: by 2002:a17:902:b181:: with SMTP id s1mr4375207plr.62.1573510790492; Mon, 11 Nov 2019 14:19:50 -0800 (PST) Received: from ?IPv6:2601:202:4180:a5c0:604a:b703:29ca:5c7d? ([2601:202:4180:a5c0:604a:b703:29ca:5c7d]) by smtp.gmail.com with ESMTPSA id w2sm15478135pfj.22.2019.11.11.14.19.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Nov 2019 14:19:50 -0800 (PST) To: Ross Burton , openembedded-core@lists.openembedded.org References: <20191107235830.26644-1-ross.burton@intel.com> <20191107235830.26644-5-ross.burton@intel.com> From: akuster808 Openpgp: preference=signencrypt Autocrypt: addr=akuster808@gmail.com; prefer-encrypt=mutual; keydata= mQINBFnlUP4BEADpKf+FQdLykenQXKk8i6xJNxDow+ypFeVAy8iFJp7Dsev+BtwUFo8VG7hx Jmd71vHMw+coBetWC3lk+IKjX815Ox0puYXQVRRtI+yMCgd6ib3oGxoQ8tCMwhf9c9/aKjaz mP97lWgGHbiEVsDpjzmMZGlJ6pDVZzxykkJExKaosE46AcA8KvfhRQg5zRyYBtinzs8Zu8AP aquZVHNXxPwjKPaSEEYqQjFeiNgFTavV+AhM2dmPmGUWCX9RZisrqA4slGwEB0srMdFf12Zg mD35Y9jZ80qpu5LPtJCFcsaAlebqR+dg36pIpiRR+olhN1wmC6LYP1vw6uMEYBjkTa2Rnb6+ C4FDzCJD4UCrUvLMNeTW810DY0bjMMj3SfmSGSfQUssaaaTXCVlLGuGxyCr/kza1rHaXMKum Ek4EFj1fyn7AfkSLEHfJfY4sO1tpgigvs4eD/4ZSQEXSu/TjVvyKx4EvUbhlGMRyH2CPwD/H 7DFF8tcVtJvCwUUW+zKtjxjSSLrhniNMXAOQJZ6CdaqCe4OyJQT5aRdr+FWbBRjpaRCCf5nf dTc88NMU9PrBT3vu0QJ5WNPO6MJpnb+d8iMNLZAz8tv8JMm2l+sMcNKSJ6lhX8peoBsfMVqc FgiykEO0fUt7DCbUYR5tLjM/3E5tHvTjMooVJyOxoufVLYtTtQARAQABtCFha3VzdGVyODA4 IDxha3VzdGVyODA4QGdtYWlsLmNvbT6JAj0EEwEIACcFAlnlUP4CGyMFCQlmAYAFCwkIBwIG FQgJCgsCBBYCAwECHgECF4AACgkQ7ou0mfRW5/kuhRAAlR2FTq5572jrX5nnPR7AqI2bvSVb vqGLlvv739WhghvagbC+tu05QguopAhWW1/DcHK2+QtfIoC9UZrSW4RaO0CCo5sPjqK7l1KT ngWX/rGjF6xTF2QN0U/btcpMyVN2CNtVLwsDF9e+GHKoUcnFkP+JP8vHGokN9k6E/c97hLaL IJPeKl8LZXc2Efk+MaW1NXkfDJdcp/p+voajbihSQO6OZ/o+x9d2I3ZybKfTZ71+ek5Hxzjz g6KkMOI7KJjlmBlrQFAtVbS+CFAKrwkYznE6ggkcmGv3N7DeUBTUR78hf+EZEAM+ajeLMtrG rXE00pIb+gLGYPZxba5pCdQ+qWUW38qi9UnIRPm6fq7Ypx1r6XwJvbgCOkhbxo3D4YUdyC0b FE9lgrg8htbc9in4j2+hVI6ALswNjLprzXdzdKrd+T3Egx36o3Z/qrYsW2o5/A5sVvvASVKi wRPuEKhEhfmiHUPLvuKqhMoymHaz3fg5D2Q8G0gSDkLgeEpAjiWqf4+AGLx+MSDai7DSOsmI t61kWxs7cFTB32UrB/TDoVNn3Fm88ZFQpA/bngikE9jgEm045mSY86fNlbFj2mcCd0Ha1i1n aYc97RpgfjNMWyHDVHOGrNg/hJjkGa5RsAXkfyBwltHRw0Hj4urUQ3rr8um8PLe43SezPwXA oRoyDxC5Ag0EWeVQ/gEQALNHwj5VSPdnvXy1RXUuH+rclMx4x8zaqDyY0YqHfA7b/d8Y0VAt Y6YpzDeFTwD8A0Wfb7kZ2mlDIE6ODCB71uT/E3C6b+FiiN+lgzslznjUW+9l8ddDhRrC8HMG 37vrXF5h++PTXUKEKUlkDib1w093tu3mlJXUvIAzl8CEHkptF6Br0L9XxFwuWoNUfjT9IorQ 0SVIhvq5PhVAITXUD5fD7/N8B4TYegmHFRo1UaaKSnSHwlJJkzKpeWOH8QTYrP0RHxX86Obv IZuwbAo3F3oojcvLJt9NxWnbEmEALkleklLZnukgu7q5Wp1VDwhUbMFTLb6qmnBa/Xi30uOk 0l1TMHDbeQswvQDOZBAMukSRqyBetKxQ3iTfZ/3z1ubQRcVDbVlMDScSHQq0LK3F9yMOMM/6 0QPqJjl13xn/+Bn7WJiAIXXwzAV7uo6i0khFfjDtCDQ40aeffqOLxp1yMLkc3EKJGcQ5F6O2 ycEf4QXCYUbMXjxB0EJB8y7z+xOi5Mmd/pPlVmZ2gQK84NAL90p7n7jRlyf3gOUY+JOl4c5e UFiIhOzmuqNrvPOiZ02GXh6SGUU5y7IgSoIKvXSFgHAn2OG/tcspBmkyv6IuNVpmbmEgYn4I Rnt40UXVQkxTh0dENFhk2cjunMYozV/OqYCgmZLFSeJd8kAo4yn+yOtNABEBAAGJAiUEGAEI AA8FAlnlUP4CGwwFCQlmAYAACgkQ7ou0mfRW5/nNcg//R63cbOS6zLtvdnPub3Ssp1Ft8Wmv mni+kccuNApuDV7d63QckYxjAfUv2zYMLpbh87gVbLyCq9ASn552EbfRhTvHdk44CgbHBVcI ZBEdZWgRR5ViJakQSYHpP2e5AGNFnx9gSIuRTaa5rvZM+4xeoZ2vJiq93TtaYPr7UFNfK+c4 vv4C66lkt9l95/I10eSc3RqbOKZW47emlg4X3ygEoB9k2lPrpspyf6sUuSEi0WrlSxoLAr6p JG8rTUErYNeXe6JCdL31odDx1Dh5sdKIj2RicUYZNilxu9f1M7jZwf2ra1FGAlKj2ybqmgpZ EFteaiCinEYsvDyZyOiWHjAFI+RZIPQQL3AnVp4l7wYD3r9hnqYPww0slyMDcb9262RoFkHq dDwxPYarrNjWUpOzxB6bFxOgNRdCTgvQl8Ftk8a/yXB6vHeUSm1vPFCBxQPZytyfOLhEWm0J /mkVL0Z6iRK3p1LKnpLYCS4/esL2u7RrhPyCs2SsL58YcQF/g+PpeT9geZ+oyZ/4IQ+TWJoU PNHndk8VBTpzrmOaJxrebNL/W6C8JCmbLM11TAUMmHYi9JDytN8Au78hWpDbIdKwg1LeSxpw ZZD/OqOc0DBvHOpQhzkSrtR1lVlDV/+9E8J1T4uDhrGmZwYV+4xQetypHax8aAHisYbjXdVa 8CS2NxU= Message-ID: Date: Mon, 11 Nov 2019 14:19:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191107235830.26644-5-ross.burton@intel.com> Subject: Re: [PATCH 5/5] cve-update-db-native: don't refresh more than once an hour X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2019 22:19:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 11/7/19 3:58 PM, Ross Burton wrote: > We already fetch the yearly CVE metadata and check that for updates before > downloading the full data, but we can speed up CVE checking further by only > checking the CVE metadata once an hour. > > Signed-off-by: Ross Burton > --- > meta/recipes-core/meta/cve-update-db-native.bb | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-core/meta/cve-update-db-native.bb b/meta/recipes-core/meta/cve-update-db-native.bb > index 2c427a5884f..19875a49b1c 100644 > --- a/meta/recipes-core/meta/cve-update-db-native.bb > +++ b/meta/recipes-core/meta/cve-update-db-native.bb > @@ -31,8 +31,16 @@ python do_populate_cve_db() { > db_dir = os.path.join(d.getVar("DL_DIR"), 'CVE_CHECK') > db_file = os.path.join(db_dir, 'nvdcve_1.0.db') > json_tmpfile = os.path.join(db_dir, 'nvd.json.gz') > - proxy = d.getVar("https_proxy") > > + # Don't refresh the database more than once an hour err, I thought the NVD db is only updated once every two hours. And why is this not a variable so folks can tweak accordingly? - armin > + try: > + import time > + if time.time() - os.path.getmtime(db_file) < (60*60): > + return > + except OSError: > + pass > + > + proxy = d.getVar("https_proxy") > if proxy: > # instantiate an opener but do not install it as the global > # opener unless if we're really sure it's applicable for all