Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1F9C433F5 for ; Mon, 18 Oct 2021 15:34:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CE0E610C7 for ; Mon, 18 Oct 2021 15:34:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CE0E610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.212456.370326 (Exim 4.92) (envelope-from ) id 1mcUeX-0004NE-HW; Mon, 18 Oct 2021 15:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 212456.370326; Mon, 18 Oct 2021 15:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mcUeX-0004N7-Ed; Mon, 18 Oct 2021 15:34:17 +0000 Received: by outflank-mailman (input) for mailman id 212456; Mon, 18 Oct 2021 15:34:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mcUeW-0004N1-8a for xen-devel@lists.xenproject.org; Mon, 18 Oct 2021 15:34:16 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab8d8f8a-4d0f-4ff0-bcc4-b2921fc796fd; Mon, 18 Oct 2021 15:34:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 41BBE21961; Mon, 18 Oct 2021 15:34:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B825140B1; Mon, 18 Oct 2021 15:34:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nsZtBfaTbWGUIQAAMHmgww (envelope-from ); Mon, 18 Oct 2021 15:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab8d8f8a-4d0f-4ff0-bcc4-b2921fc796fd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634571254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kFk64Uh32heiFEGqzzb3aE+jycVincgZmQe5hOMAeJI=; b=Ex0k38cJW3oqtIF3k3otjk0W/XnJIVPrgRByYULvklSx/Q+ABjGUNUIA+dpMa/sJ1x7o/Y shiyDNj+BifihS96BZ7PC4M7XzZ8TmiC7OiArE3lyV+XdS8qcaGcfR6rFd1gF3D6dpXi6G AB1dH/QIR5a5Ik59Atp447MXY/arNmY= Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20211015125152.25198-1-jgross@suse.com> <20211015125152.25198-5-jgross@suse.com> <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com> <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com> From: Juergen Gross Message-ID: Date: Mon, 18 Oct 2021 17:34:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU Content-Type: multipart/mixed; boundary="5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype References: <20211015125152.25198-1-jgross@suse.com> <20211015125152.25198-5-jgross@suse.com> <71fae3b2-9f90-878c-50f1-e9c0d7cf7e5c@suse.com> <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com> In-Reply-To: <0a1aee06-41da-7045-4bdd-33993ce3741e@suse.com> --5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb Content-Type: multipart/mixed; boundary="------------FAFE546B6B3A6EE8C0C875FC" Content-Language: en-US This is a multi-part message in MIME format. --------------FAFE546B6B3A6EE8C0C875FC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 18.10.21 16:28, Jan Beulich wrote: > On 18.10.2021 15:27, Juergen Gross wrote: >> On 18.10.21 14:31, Jan Beulich wrote: >>> On 15.10.2021 14:51, Juergen Gross wrote: >>>> hvm_memory_op() should take an unsigned long as cmd, like >>>> do_memory_op(). >>>> >>>> As hvm_memory_op() is basically just calling do_memory_op() (or >>>> compat_memory_op()) passing through the parameters the cmd parameter= >>>> should have no smaller size than that of the called functions. >>>> >>>> Signed-off-by: Juergen Gross >>> >>> Reviewed-by: Jan Beulich >>> >>> Nevertheless ... >>> >>>> --- a/xen/arch/x86/hvm/hypercall.c >>>> +++ b/xen/arch/x86/hvm/hypercall.c >>>> @@ -31,7 +31,7 @@ >>>> #include >>>> #include >>>> =20 >>>> -static long hvm_memory_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg= ) >>>> +static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM= (void) arg) >>>> { >>>> long rc; >>> >>> ... I think this would even better be dealt with by splitting the >>> function into a native one (using unsigned long) and a compat one >>> (using unsigned int). >> >> Why? In 32-bit case the value is naturally limited to 32 bits width >> zero-extending perfectly fine to unsigned long. >=20 > It all ends up working fine, yes. Else I wouldn't have given R-b. > But the .compat slot of the hypercall table really should use a > prototype without unsigned long, and then the calls wouldn't > zero-extend the arguments anymore. And then the declaration would > be wrong, as then it would need to be the callee to zero-extend if > it wants to use 64-bit values. >=20 >> Otherwise I couldn't use the same definition later. >=20 > Right. And this will be less of a problem once the function pointer > tables are gone, as then the compiler sees the real parameter types > for the individual functions. Okay, I understand that. I'd prefer to do that as a followup patch (series) then. Juergen --------------FAFE546B6B3A6EE8C0C875FC Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------FAFE546B6B3A6EE8C0C875FC-- --5kVMQvNheUEqyv8MsIx7sCpjZq82VNTFb-- --8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFtk/UFAwAAAAAACgkQsN6d1ii/Ey8N 4Af+P01EOJmlM+bsehtC/fX34VpNM7DVlAp8FlzxZFR1/J4fBD7+zY9NEZPU6dCtrw/7orVaki+H 2HBs+O0WaOIZhQ/Lw/vueMa4U5ZKfLCkrkpe4K0C7jwXC2fNcdLqVqQtTF9iLWbvjciHSAXpqo5Q TggrSYju//pIjXjT2xavluX2bow5hqxaVNXPKTGZkgRQCtZF44CRyFxkuT9hoowZYFf13+MeK/ux BTgI/fXGSk9yKskG+nfKeSByA5qWvliDwfanJizR+aSD6iGKJHTMYW0npwO1VUHzydZNhNlqkYCO P9d5j/DIKzitSbr5SD07dJPLdY7LQ91bACnPyXgawQ== =zXDP -----END PGP SIGNATURE----- --8MZ0cbvgWoPdEv2qmeX6bjF7EgWiEG1EU--