Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 902F3CD98DA for ; Tue, 16 Jun 2026 07:31:53 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1338752.1599802 (Exim 4.92) (envelope-from ) id 1wZOGp-0006tO-FW; Tue, 16 Jun 2026 07:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1338752.1599802; Tue, 16 Jun 2026 07:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1wZOGp-0006tH-CD; Tue, 16 Jun 2026 07:31:39 +0000 Received: by outflank-mailman (input) for mailman id 1338752; Tue, 16 Jun 2026 07:31:37 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) id 1wZOGn-0006tB-Pk for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 07:31:37 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1wZOGn-004tq3-6J for xen-devel@lists.xenproject.org; Tue, 16 Jun 2026 09:31:37 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6a30fbd9-2eae-0a2a0a5409dd-0a2a4502c162-2 for ; Tue, 16 Jun 2026 09:31:37 +0200 Received: from [209.85.218.48] (helo=mail-ej1-f48.google.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.56.1) (envelope-from ) id 6a30fbd9-af86-0a2a45020019-d155da30f0a2-3 for ; Tue, 16 Jun 2026 09:31:37 +0200 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-bef47b1ac01so591578366b.2 for ; Tue, 16 Jun 2026 00:31:37 -0700 (PDT) Received: from [192.168.1.6] (user-109-243-148-111.play-internet.pl. [109.243.148.111]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb7b6dc48sm598107566b.36.2026.06.16.00.31.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 00:31:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781595097; x=1782199897; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xgq4liH7Jz4cbnB2BqbOfY+iuZH2QCjiC950WcU4bEA=; b=oiB/xt5yyMfrQ5B760rgo5SFYG1ZMGZtTSMM9Imgdxk0EASHtl9NLSd4XaRenyNawx VU4t1qmj4FiI8HrLL2Y9Im939JTR+AZXt69SBIISBwzpinw2mD7WEpYmyRrrvFag1MIE PghKdGJsYwC6yj0D0MFehAsIZE31c/liH9ujRVtOkrRUN1engU4uvJEkpArA0LBHhGSv EBAY5BIf46Av1eywX69wBBXDfvN19j9muEHZ1uS98MMbhEwx1Vyh+izi0XPJ8CzXbXKA 0iZUnPoz1RbetQAJnnwdRsl2TFNB5YqA+ZXsaWL8GBFU8wS3o653IKkbHZS5Q26t30h7 P/bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781595097; x=1782199897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xgq4liH7Jz4cbnB2BqbOfY+iuZH2QCjiC950WcU4bEA=; b=ReKnKn3fNPgGQ6BPq1cpIPVv2spmJTt4Z59Qg2wl5z2KDGZCokSmnT48RV3fy3Je8A knZgVpyuWlGtya6H19tLXYu15g+Zhm4laojJQRHlu14OI8TrTb0Ml1t540HE8Mbmb1Pa k/cJJjL4d+ytEJr/5mUAWmVsJ0WrjdeTB8cDdbAf0unaSH19pPqmQkvVaQTPBG9FxIJU Zyd699VQR+XIsEL3PaBHbyyHkwIpFMcmaCSAzIOkFj8Hgc5PnhcdkzHKudyqO4e0NSiF 9D0rIqGee3ig2d6OnKCa6LgCwRM5mmnHQ8ytxM3viEwfSWEjSjr/MCITM0b1gSwKKYrG h6iw== X-Forwarded-Encrypted: i=1; AFNElJ/r4DkFG3//h6R63ewWNmeCL1H8M0v9tQGNIaEWMF79ODYtYBbDWLomShTxPW02ePAO3eJVnki0mt0=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy2YOU9tjZj6nDRaeOSuYnzoUBoiZ9CKKYmCEIkWdRqmoLzVfBe NC8+xu0sbJtrbIeCL4c2cOkkrBsZ+zZx+Or9Psrfe7M2XIEZ1NHWiRA9hfPzxg== X-Gm-Gg: Acq92OFgRfN3lOcEp4CvdSc/uWaICQvdD+BxaHG0BWv1SSlD3MNcdhPxSCmKpqqJFLZ YC39GM7524a2dnFD3z2sFbE1wVA0nJTLJB4Z+FpPK+1D3hdH9le2fHdCYDKCFWnqRD3p2Ka0Xl/ oTk3WNdMBlywgD180oC4RIe7DEGAO2Q3mkanT1shnb7ZX4R5IRDqnwVGmG1KVMv6D0mtMQ8ak6O 2WGjiYad/bfCETXIbNuJErgd29/brbMLXdW6oJXg78So0V/DzO1ckabaoKoy1vCoSaA493kbICp TTQU23Gjod+JZ7O3Ta+7DN4T3eELWdGC9njplOl8WhVZj0CeIf5vlF3iBcaoMGsFgQGNs+sXrgJ DHIJzaA3t/a6A4ajy5MUeSgkreCvFdb62/9tE9VSoAsnJtQjz9fsUvMow0fw45qQq2ar1V40/dI LQIDilGbaZ0aRo4tu8/5cJRpL+Y8fnfjWDeDKCmf9B56lec77cEv9dYSTqZAKPqBJ9H62aPAQml Nkcbg== X-Received: by 2002:a17:907:a28a:b0:bee:1e36:8772 with SMTP id a640c23a62f3a-c043cdd53a7mr104867166b.20.1781595096024; Tue, 16 Jun 2026 00:31:36 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 09:31:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-4.22] Revert "xen/cpufreq: fix usages of align_timer() in the on-demand governor" To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jan Beulich Cc: Jason Andryuk , xen-devel@lists.xenproject.org References: <20260615193944.19392-1-jason.andryuk@amd.com> <1fbb67ab-09f3-4924-b6aa-139fc5d1acc7@suse.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-ID: tlsNG-720697/1781595097-AAD6F161-50A43679/10/73395122804 X-purgate-type: spam X-purgate-size: 1152 On 6/16/26 8:47 AM, Roger Pau Monné wrote: > On Tue, Jun 16, 2026 at 08:30:25AM +0200, Jan Beulich wrote: >> On 15.06.2026 21:39, Jason Andryuk wrote: >>> The original commit showed a ~6% regression in a benchmark. The call to >>> align_timer(firsttick, period) rounds firsttick up to the next mutiple >>> of the period, if firsttick % period != 0: >>> >>> align_timer(0, period) -> 0 >>> align_timer(1, period) -> period >>> align_timer(period, period) -> period >>> align_timer(period + 1, period) -> 2 * period >>> >>> So adding the period (sampling_rate) before calling align_timer() will >>> in most cases incease the expiration to 2 * period (sampling_rate) (the >>> exception being firsttick % period == 0). This longer timer slows the >>> reaction time of the algorithm. >>> >>> This reverts commit a0ed5bcfbeee81c91c574ad484faa057054eaf09. >>> >>> Signed-off-by: Jason Andryuk > > Acked-by: Roger Pau Monné > > Adding Oleksii for a release-ack. > Release-Acked-by: Oleksii Kurochko Thanks. ~ Oleksii