From: "its_Giaan (Code Review)" Date: Fri, 24 Jan 2025 14:08:37 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296..., a@...2181... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="t4Dzt2BJEs8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute: adapt to new protocol handling and hashing improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , cron2 , flichtenheld Cc: openvpn-devel --t4Dzt2BJEs8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, its_Giaan, ordex= , plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail to look at the new patch set (#16). The following approvals got outdated and were removed: Code-Review-1 by cron2 Change subject: mroute: adapt to new protocol handling and hashing improvem= ents ...................................................................... mroute: adapt to new protocol handling and hashing improvements Repurposing an unused field and renaming it to 'proto' instead of introducing a new field. The hashing now begins at the 'proto' field rather than the 'type' field. Additionally, the changes ensure that the correct protocol is consistently used with virtual addresses ensuring alignment. Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Signed-off-by: Gianmarco De Gregori --- M src/openvpn/mroute.c M src/openvpn/mroute.h M src/openvpn/mtcp.c M src/openvpn/mudp.c M src/openvpn/multi.c 5 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/765/16 diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c index 80e18b7..74923cf 100644 --- a/src/openvpn/mroute.c +++ b/src/openvpn/mroute.c @@ -454,6 +454,7 @@ buf_printf(&out, "UNKNOWN"); break; } + buf_printf(&out, "|%d", maddr.proto); return BSTR(&out); } else diff --git a/src/openvpn/mroute.h b/src/openvpn/mroute.h index 8b457d4..1c44b35 100644 --- a/src/openvpn/mroute.h +++ b/src/openvpn/mroute.h @@ -74,7 +74,7 @@ struct mroute_addr { uint8_t len; /* length of address */ - uint8_t unused; + uint8_t proto; uint8_t type; /* MR_ADDR/MR_WITH flags */ uint8_t netbits; /* number of bits in network part of address, * valid if MR_WITH_NETBITS is set */ @@ -183,6 +183,15 @@ { unsigned int ret =3D 0; verify_align_4(buf); + + /* + * Since we don't really need the protocol on vaddresses for internal = VPN + * payload packets, make sure we have the same value to avoid hashing = insert + * and search issues. + */ + src->proto =3D 0; + dest->proto =3D src->proto; + if (tunnel_type =3D=3D DEV_TYPE_TUN) { ret =3D mroute_extract_addr_ip(src, dest, buf); @@ -216,13 +225,13 @@ mroute_addr_hash_ptr(const struct mroute_addr *a) { /* NOTE: depends on ordering of struct mroute_addr */ - return (uint8_t *) &a->type; + return (uint8_t *) &a->proto; } static inline uint32_t mroute_addr_hash_len(const struct mroute_addr *a) { - return (uint32_t) a->len + 2; + return (uint32_t) a->len + 3; } static inline void diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index 6d1d5a0..62ed044 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -56,6 +56,7 @@ mi =3D multi_create_instance(m, NULL, ls); if (mi) { + mi->real.proto =3D ls->info.proto; struct hash_element *he; const uint32_t hv =3D hash_value(hash, &mi->real); struct hash_bucket *bucket =3D hash_bucket(hash, hv); diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index 6137578..4f2bbd7 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -192,6 +192,7 @@ struct mroute_addr real =3D {0}; struct multi_instance *mi =3D NULL; struct hash *hash =3D m->hash; + real.proto =3D ls->info.proto; if (mroute_extract_openvpn_sockaddr(&real, &m->top.c2.from.dest, true) && m->top.c2.buf.len > 0) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 3f55dd7..273aa05 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -1243,6 +1243,7 @@ CLEAR(remote_si); remote_si.addr.in4.sin_family =3D AF_INET; remote_si.addr.in4.sin_addr.s_addr =3D htonl(a); + addr.proto =3D 0; ASSERT(mroute_extract_openvpn_sockaddr(&addr, &remote_si, false)); if (netbits >=3D 0) @@ -3548,7 +3549,6 @@ const int dev_type =3D TUNNEL_TYPE(m->top.c1.tuntap); int16_t vid =3D 0; - #ifdef MULTI_DEBUG_EVENT_LOOP printf("TUN -> TCP/UDP [%d]\n", BLEN(&m->top.c2.buf)); #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Gerrit-Change-Number: 765 Gerrit-PatchSet: 16 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-MessageType: newpatchset --t4Dzt2BJEs8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, its_Giaan, o= rdex, plaisthos.

its_Giaan uploaded patch set #16 to this change.

= View Chan= ge

The following approvals got outdated and were removed: Code-Review-1 by cron2

mroute: adapt to new protocol handling and hashing i=
mprovements

Repurposing an unused field and renaming it to 'prot= o'
instead of introducing a new field. The hashing now
begins at = the 'proto' field rather than the 'type'
field. Addition= ally, the changes ensure that the
correct protocol is consistently used = with virtual
addresses ensuring alignment.

Change-Id: Ic66eccb505= 8fe9c0fae64d8e2ca88728068a92ab
Signed-off-by: Gianmarco De Gregori <g= ianmarco@...2726...>
---
M src/openvpn/mroute.c
M src/openvpn/m= route.h
M src/openvpn/mtcp.c
M src/openvpn/mudp.c
M src/openvpn/mu= lti.c
5 files changed, 16 insertions(+), 4 deletions(-)

git pu= ll ssh://gerrit.openvpn.net:29418/openvpn refs/changes/65/765/16
di=
ff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c
inde= x 80e18b7..74923cf 100644
--- a/src/openvpn/mroute.c=
+++ b/src/openvpn/mroute.c
@@ -454,6 +454,7 @@
buf_printf(&out, "UNKNOWN");
break;
}+ buf_printf(&out, = "|%d", maddr.proto);
return BSTR(&ou= t);
}
else
diff -= -git a/src/openvpn/mroute.h b/src/openvpn/mroute.h
index 8b= 457d4..1c44b35 100644
--- a/src/openvpn/mroute.h
= +++ b/src/openvpn/mroute.h
@@ -74,7 +74,7 @@
struct mroute_addr {
uint8_= t len; /* length of address */
- uint8_t unused;
+ uint8_t proto;
uint8_t type; /* MR_A= DDR/MR_WITH flags */
uint8_t netbits; /* number of bit= s in network part of address,
* vali= d if MR_WITH_NETBITS is set */
@@ -183,6 +183,15 @@<= br> {
unsigned int ret =3D 0;
= verify_align_4(buf);
+
+ /*+ * Since we don't re= ally need the protocol on vaddresses for internal VPN
+ * payload packets, make sure we have= the same value to avoid hashing insert
+ * and search issues.
+ */
+ src->proto =3D 0;
+ dest->proto =3D src->proto;
+
if (tunnel_type = =3D=3D DEV_TYPE_TUN)
{
ret = =3D mroute_extract_addr_ip(src, dest, buf);
@@ -216,13 +225= ,13 @@
mroute_addr_hash_ptr(const struct mroute_addr *a)
{
/* NOTE: depends on ordering of stru= ct mroute_addr */
- = return (uint8_t *) &a->type;
+ return (uint8_t *) &a->proto;
}=

static inline uint32_t
= mroute_addr_hash_len(const struct mroute_addr *a)
{
- return (uint32_t) a->= ;len + 2;
+ return= (uint32_t) a->len + 3;
}

<= span> static inline void

diff --git a/src/openvpn/mtcp.c b/= src/openvpn/mtcp.c
index 6d1d5a0..62ed044 100644
= --- a/src/openvpn/mtcp.c
+++ b/src/openvpn/mtcp.c
@@ -56,6 +56,7 @@
mi =3D multi_create_ins= tance(m, NULL, ls);
if (mi)
{
+ mi->real.pro= to =3D ls->info.proto;
struct hash_element *he;=
const uint32_t hv =3D hash_value(hash, &mi-&g= t;real);
struct hash_bucket *bucket =3D hash_bucke= t(hash, hv);
diff --git a/src/openvpn/mudp.c b/src/openvpn/= mudp.c
index 6137578..4f2bbd7 100644
--- a/= src/openvpn/mudp.c
+++ b/src/openvpn/mudp.c
@@ -192,6 +192,7 @@

struct mroute_addr real =3D {0};<= /span>
struct multi_instance *mi =3D NULL;
= struct hash *hash =3D m->hash;
+ real.proto =3D ls->info.proto;

if (mroute_extract_openvpn_sockaddr(&real, &m-&g= t;top.c2.from.dest, true)
&& m->top.c2.= buf.len > 0)
diff --git a/src/openvpn/multi.c b/src/open= vpn/multi.c
index 3f55dd7..273aa05 100644
-= -- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c@@ -1243,6 +1243,7 @@
CLEAR(remote_si);=
remote_si.addr.in4.sin_family =3D AF_INET;
= remote_si.addr.in4.sin_addr.s_addr =3D htonl(a);
+ addr.proto =3D 0;
= ASSERT(mroute_extract_openvpn_sockaddr(&addr, &remote_si, false))= ;

if (netbits >=3D 0)
<= span>@@ -3548,7 +3549,6 @@

const int dev_type =3D = TUNNEL_TYPE(m->top.c1.tuntap);
int16_t vid =3D = 0;

-<= /span>
#ifdef MULTI_DEBUG_EVENT_LOOP
pri= ntf("TUN -> TCP/UDP [%d]\n", BLEN(&m->top.c2.buf));
#endif

To view, visit change 765. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca= 88728068a92ab
Gerrit-Change-Number: 765
Gerrit-PatchSet: 16
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-MessageType: newpatchset
--t4Dzt2BJEs8=--