From: "flichtenheld (Code Review)" Date: Wed, 7 Jan 2026 17:58:07 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="cBIaYZYsIcI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Add a first unit test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --cBIaYZYsIcI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1459?usp=3Demail to review the following change. Change subject: openvpnserv: Add a first unit test ...................................................................... openvpnserv: Add a first unit test This adds the required build infrastructure and adds tests for two functions related to GetItfDnsDomains(). Change-Id: I33583e51e1143c53fbe0aef16546fa3f602b17c0 Signed-off-by: Frank Lichtenheld --- M src/openvpnserv/CMakeLists.txt M tests/unit_tests/Makefile.am M tests/unit_tests/openvpn/test_common.h A tests/unit_tests/openvpnserv/Makefile.am A tests/unit_tests/openvpnserv/test_openvpnserv.c 5 files changed, 172 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/59/1459/1 diff --git a/src/openvpnserv/CMakeLists.txt b/src/openvpnserv/CMakeLists.txt index 2c8f310..67a89ef 100644 --- a/src/openvpnserv/CMakeLists.txt +++ b/src/openvpnserv/CMakeLists.txt @@ -74,3 +74,44 @@ endif() add_dependencies(openvpnserv msg_mc_gen) + +if (BUILD_TESTING) + set(unit_tests + "test_openvpnserv" + ) + + foreach (test_name ${unit_tests}) + add_test(${test_name} ${test_name}) + add_executable(${test_name} + ../../tests/unit_tests/openvpnserv/${test_name}.c + ${MC_GEN_DIR}/eventmsg.h + ) + + target_link_libraries(${test_name} PUBLIC ${CMOCKA_LIBRARIES}) + target_include_directories(${test_name} PRIVATE + . + ../../include + ../openvpn + ${MC_GEN_DIR} + ../../tests/unit_tests/openvpn + ) + target_compile_options(${test_name} PRIVATE + -D_UNICODE + -UNTDDI_VERSION + -D_WIN32_WINNT=3D_WIN32_WINNT_VISTA + ) + target_link_libraries(${test_name} PRIVATE + advapi32.lib userenv.lib iphlpapi.lib fwpuclnt.lib rpcrt4.lib + shlwapi.lib netapi32.lib ws2_32.lib ntdll.lib ole32.lib pathcc= h.lib) + if (MINGW) + target_compile_options(${test_name} PRIVATE -municode) + target_link_options(${test_name} PRIVATE -municode) + endif () + endforeach() + + target_sources(test_openvpnserv PRIVATE + common.c + validate.c + ../openvpn/wfp_block.c ../openvpn/wfp_block.h + ) +endif () diff --git a/tests/unit_tests/Makefile.am b/tests/unit_tests/Makefile.am index 33fefaa..ce6278e 100644 --- a/tests/unit_tests/Makefile.am +++ b/tests/unit_tests/Makefile.am @@ -1,5 +1,5 @@ AUTOMAKE_OPTIONS =3D foreign if ENABLE_UNITTESTS -SUBDIRS =3D example_test openvpn plugins +SUBDIRS =3D example_test openvpn openvpnserv plugins endif diff --git a/tests/unit_tests/openvpn/test_common.h b/tests/unit_tests/open= vpn/test_common.h index 3a0598d..4153ca3 100644 --- a/tests/unit_tests/openvpn/test_common.h +++ b/tests/unit_tests/openvpn/test_common.h @@ -20,8 +20,9 @@ * with this program; if not, see . */ -#include #include +#include +#include #include /* Do we use cmocka < 2.0.0? */ diff --git a/tests/unit_tests/openvpnserv/Makefile.am b/tests/unit_tests/op= envpnserv/Makefile.am new file mode 100644 index 0000000..5758cd4 --- /dev/null +++ b/tests/unit_tests/openvpnserv/Makefile.am @@ -0,0 +1,15 @@ +AUTOMAKE_OPTIONS =3D foreign + +EXTRA_DIST =3D input + +AM_TESTSUITE_SUMMARY_HEADER =3D ' for $(PACKAGE_STRING) service Unit-Tests' + +if WIN32 +test_binaries =3D openvpnserv_testdriver +endif + +openvpnserv_testdriver_CFLAGS =3D -I$(top_srcdir)/include -I$(top_srcdir)= /src/openvpn -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpnserv @TE= ST_CFLAGS@ +openvpnserv_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ -L$(top_srcdir)/src/open= vpn +openvpnserv_testdriver_SOURCES =3D test_openvpnserv.c \ + $(top_srcdir)/src/openvpnserv/common.c + diff --git a/tests/unit_tests/openvpnserv/test_openvpnserv.c b/tests/unit_t= ests/openvpnserv/test_openvpnserv.c new file mode 100644 index 0000000..348de4f --- /dev/null +++ b/tests/unit_tests/openvpnserv/test_openvpnserv.c @@ -0,0 +1,113 @@ +/* + * OpenVPN -- An application to securely tunnel IP networks + * over a single UDP port, with support for SSL/TLS-based + * session authentication and key exchange, + * packet encryption, packet authentication, and + * packet compression. + * + * Copyright (C) 2025 Frank Lichtenheld + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by t= he + * Free Software Foundation, either version 2 of the License, + * or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, see . + */ + +#include +#include +#include "test_common.h" + +#include +#include + +#include "interactive.c" + +BOOL +ReportStatusToSCMgr(SERVICE_STATUS_HANDLE service, SERVICE_STATUS *status) +{ + return TRUE; +} + +static void +test_list_contains_domain(void **state) +{ + PCWSTR domain =3D L"openvpn.net"; + size_t domain_len =3D wcslen(domain); + assert_true(ListContainsDomain(domain, domain, domain_len)); + assert_true(ListContainsDomain(L"openvpn.com,openvpn.net", domain, dom= ain_len)); + assert_true(ListContainsDomain(L"openvpn.net,openvpn.com", domain, dom= ain_len)); + + assert_false(ListContainsDomain(L"openvpn.com", domain, domain_len)); + assert_false(ListContainsDomain(L"internal.openvpn.net", domain, domai= n_len)); +} + +#define BUF_SIZE 64 +static void +test_convert_itf_dns_domains(void **state) +{ + DWORD size, orig_size, len, res_len; + LSTATUS err; + const DWORD glyph_size =3D sizeof(wchar_t); + + wchar_t domains_1[BUF_SIZE] =3D L"openvpn.com"; + len =3D (DWORD)wcslen(domains_1) + 1; + size =3D orig_size =3D len * glyph_size; + wchar_t domains_1_res[BUF_SIZE] =3D L".openvpn.com"; + res_len =3D len + 2; /* adds . and \0 */ + err =3D ConvertItfDnsDomains(L"openvpn.net", domains_1, &size, BUF_SIZ= E); + assert_memory_equal(domains_1, domains_1_res, size); + assert_int_equal(size, res_len * glyph_size); + assert_int_equal(err, NO_ERROR); + + wchar_t domains_2[BUF_SIZE] =3D L"openvpn.com,openvpn.net"; + len =3D (DWORD)wcslen(domains_2) + 1; + size =3D orig_size =3D len * glyph_size; + wchar_t domains_2_res[BUF_SIZE] =3D L".openvpn.com"; + res_len =3D (DWORD)wcslen(domains_2_res) + 2; + err =3D ConvertItfDnsDomains(L"openvpn.net", domains_2, &size, BUF_SIZ= E); + assert_memory_equal(domains_2, domains_2_res, size); + assert_int_equal(size, res_len * glyph_size); + assert_int_equal(err, NO_ERROR); + + wchar_t domains_3[BUF_SIZE] =3D L"openvpn.com,openvpn.net"; + len =3D (DWORD)wcslen(domains_3) + 1; + size =3D orig_size =3D len * glyph_size; + wchar_t domains_3_res[BUF_SIZE] =3D L".openvpn.net"; + res_len =3D (DWORD)wcslen(domains_3_res) + 2; + err =3D ConvertItfDnsDomains(L"openvpn.com", domains_3, &size, BUF_SIZ= E); + assert_memory_equal(domains_3, domains_3_res, size); + assert_int_equal(size, res_len * glyph_size); + assert_int_equal(err, NO_ERROR); + + wchar_t domains_4[BUF_SIZE] =3D L"openvpn.com,openvpn.net"; + len =3D (DWORD)wcslen(domains_4) + 1; + size =3D orig_size =3D len * glyph_size; + wchar_t domains_4_res[BUF_SIZE] =3D L".openvpn.com\0.openvpn.net"; + res_len =3D len + 3; /* adds two . and one \0 */ + err =3D ConvertItfDnsDomains(NULL, domains_4, &size, BUF_SIZE); + assert_memory_equal(domains_4, domains_4_res, size); + assert_int_equal(size, res_len * glyph_size); + assert_int_equal(err, NO_ERROR); +} + +int +wmain(void) +{ + openvpn_unit_test_setup(); + const struct CMUnitTest tests[] =3D { + cmocka_unit_test(test_list_contains_domain), + cmocka_unit_test(test_convert_itf_dns_domains), + }; + + int ret =3D cmocka_run_group_tests_name("openvpnserv tests", tests, NU= LL, NULL); + + return ret; +} -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1459?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I33583e51e1143c53fbe0aef16546fa3f602b17c0 Gerrit-Change-Number: 1459 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --cBIaYZYsIcI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

openvpnserv: Add a first unit test

T= his adds the required build infrastructure
and adds tests for two functi= ons related to
GetItfDnsDomains().

Change-Id: I33583e51e1143c53fb= e0aef16546fa3f602b17c0
Signed-off-by: Frank Lichtenheld <frank@...2716...= 1...>
---
M src/openvpnserv/CMakeLists.txt
M tests/unit_tests/M= akefile.am
M tests/unit_tests/openvpn/test_common.h
A tests/unit_test= s/openvpnserv/Makefile.am
A tests/unit_tests/openvpnserv/test_openvpnser= v.c
5 files changed, 172 insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/59/1= 459/1
diff --git a/src/openvpnserv/CMakeLists.txt b/src/openvpnserv=
/CMakeLists.txt
index 2c8f310..67a89ef 100644
--- a/src/openvpnserv/CMakeLists.txt
+++ b/src/openvpnse= rv/CMakeLists.txt
@@ -74,3 +74,44 @@
endif= ()

add_dependencies(openvpnserv msg_mc_g= en)
+
+if (BUILD_TESTING)
+ set(unit_tests
+ "test_openvpnserv"<= /span>
+ )
+

+ foreach (test_name ${unit_tests})
+ add_test(${test_name} ${tes= t_name})
+ add= _executable(${test_name}
+ ../../tests/unit_tests/openvpnserv/${test_name}.c+ ${MC_GEN_DIR}/ev= entmsg.h
+ )
+
+ target_link_libraries(${test_nam= e} PUBLIC ${CMOCKA_LIBRARIES})
+ target_include_directories(${test_name} PRIVATE+ .
+ ../../include
+ ../openvpn

+ ${MC_GEN_DIR}=
+ ../../t= ests/unit_tests/openvpn
+ )
+ = target_compile_options(${test_name} PRIVATE
+ -D_UNICODE
+ -UNTDDI_VERSION
+ -D_WIN32_WINNT=3D_WIN32_WI= NNT_VISTA
+ )<= /span>
+ target_link_= libraries(${test_name} PRIVATE
+ advapi32.lib userenv.lib iphlpapi.lib fwpuclnt.lib r= pcrt4.lib
+ = shlwapi.lib netapi32.lib ws2_32.lib ntdll.lib ole32.lib pathcch.lib)
+ if (MINGW)

+ target_compil= e_options(${test_name} PRIVATE -municode)
+ target_link_options(${test_name} PRIVATE = -municode)
+ e= ndif ()
+ endforea= ch()
+
+ target_sources(test_openvpnser= v PRIVATE
+ co= mmon.c
+ valid= ate.c
+ ../ope= nvpn/wfp_block.c ../openvpn/wfp_block.h
+ )
+endif ()
diff --git a/tests/unit_tests/Makefile.am b/= tests/unit_tests/Makefile.am
index 33fefaa..ce6278e 100644<= /span>
--- a/tests/unit_tests/Makefile.am
+++ b/te= sts/unit_tests/Makefile.am
@@ -1,5 +1,5 @@
= AUTOMAKE_OPTIONS =3D foreign

if ENABLE_= UNITTESTS
-SUBDIRS =3D = example_test openvpn plugins
+SUBDIRS =3D example_test openvpn openvpnserv plugins
endif

diff --git a/tests/unit_tests/openvpn/test_common= .h b/tests/unit_tests/openvpn/test_common.h
index 3a0598d..= 4153ca3 100644
--- a/tests/unit_tests/openvpn/test_common.h=
+++ b/tests/unit_tests/openvpn/test_common.h
@@ -20,8 +20,9 @@
* with this program; if not, see &l= t;https://www.gnu.org/licenses/>.
*/
=
-#include <stdio.h&= gt;
#include <setjmp.h>
+#include <stdio.h>
+#include <stdlib.h>
#include <cmocka.h>

/* Do we use= cmocka < 2.0.0? */
diff --git a/tests/unit_tests/openvp= nserv/Makefile.am b/tests/unit_tests/openvpnserv/Makefile.am
new file mode 100644
index 0000000..5758cd4
--- /dev/null
+++ b/tests/unit_tests/openvpnserv/Makefil= e.am
@@ -0,0 +1,15 @@
+AUTOMAKE_OPTIONS =3D foreign
+
+EXTRA_DIST =3D input
+
+AM_TESTSUI= TE_SUMMARY_HEADER =3D ' for $(PACKAGE_STRING) service Unit-Tests'
+
+if WIN32
+test_binaries =3D openvpnserv_testdriver
= +endif
+
+openvpnserv_testdriver_CFLAGS =3D -I$(top_srcdir)/include -I$(= top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/open= vpnserv @TEST_CFLAGS@
+openvpnserv_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ -L$(top_srcdir)/src/ope= nvpn
+openvpnserv_tes= tdriver_SOURCES =3D test_openvpnserv.c \
+ $(top_srcdir)/src/openvpnserv/common.c
+

diff --git a/test= s/unit_tests/openvpnserv/test_openvpnserv.c b/tests/unit_tests/openvpnserv/= test_openvpnserv.c
new file mode 100644
ind= ex 0000000..348de4f
--- /dev/null
+++ b/tes= ts/unit_tests/openvpnserv/test_openvpnserv.c
@@ -0,0 +1,113= @@
+/*
+ * OpenVPN -- An application to = securely tunnel IP networks
+ * over a single UDP port, with support for SSL/TLS-bas= ed
+ * se= ssion authentication and key exchange,
+ * packet encryption, packet authentication,= and
+ * = packet compression.
+= *
+ * Copyright (C)= 2025 Frank Lichtenheld <frank@...2641...>
+ *
+ * This program is free software; you can redistribute it and/= or modify
+ * it und= er the terms of the GNU General Public License as published by the+ * Free Software Foundation= , either version 2 of the License,
+ * or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it wi= ll be useful,
+ * bu= t WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR= A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU Gene= ral Public License along
+ * with this program; if not, see <https://www.gnu.org/licenses/&g= t;.
+ */
+
+#include <setjmp.h>
+#include <cmocka.h>
+#include "test_common.h"

+
+#include <winsock2.h>
+#include <windows.h>=
+
+#include "interactive.c"
= +
+BOOL
+ReportStatusToSCMgr(SERVICE_STATUS_HANDLE service, SERVICE_STATU= S *status)
+{<= br>+ return TRUE;
= +}
+
+static void
+= test_list_contains_domain(void **state)
+{
+ PCWSTR domain =3D L"openvpn.net";
+ size_t domain_len =3D wcslen(domain);

+ assert_true(ListCon= tainsDomain(domain, domain, domain_len));
+ assert_true(ListContainsDomain(L"openvpn.com= ,openvpn.net", domain, domain_len));
+ assert_true(ListContainsDomain(L"openvpn.net= ,openvpn.com", domain, domain_len));
+
+ asse= rt_false(ListContainsDomain(L"internal.openvpn.net", domain, doma= in_len));
+}+
+#define BUF_SIZE 64
+static void
+test_convert_itf_dns_domains(void **state)
+{
+ DWORD size, orig_size, len, res_len;+ LSTATUS err;
+ const DWORD glyph_size =3D s= izeof(wchar_t);
+

+ wchar_t domains_1[B= UF_SIZE] =3D L"openvpn.com";
+ len =3D (DWORD)wcslen(domains_1) + 1;
+ size =3D orig_size =3D len * g= lyph_size;
+ wchar= _t domains_1_res[BUF_SIZE] =3D L".openvpn.com";
+ res_len =3D len + 2; /* adds . an= d \0 */
+ err =3D = ConvertItfDnsDomains(L"openvpn.net", domains_1, &size, BUF_SI= ZE);
+ assert_memo= ry_equal(domains_1, domains_1_res, size);
+ assert_int_equal(size, res_len * glyph_size);

+ assert_int_equal(er= r, NO_ERROR);
+

+ wchar_t domains_2[BUF= _SIZE] =3D L"openvpn.com,openvpn.net";
+ len =3D (DWORD)wcslen(domains_2) + 1;

+ size =3D orig_size = =3D len * glyph_size;
+ wchar_t domains_2_res[BUF_SIZE] =3D L".openvpn.com";=
+ res_len =3D (DWORD)wcs= len(domains_2_res) + 2;
+ err =3D ConvertItfDnsDomains(L"openvpn.net", domains_2, &= amp;size, BUF_SIZE);
= + assert_memory_equal(domains_2, domains_2_res, size);
+ assert_int_equal(size, res_len * = glyph_size);
+ ass= ert_int_equal(err, NO_ERROR);
+
+ wchar= _t domains_3[BUF_SIZE] =3D L"openvpn.com,openvpn.net";
= + len =3D (DWORD)wcslen(doma= ins_3) + 1;
+ size= =3D orig_size =3D len * glyph_size;
+ wchar_t domains_3_res[BUF_SIZE] =3D L".openvpn.ne= t";
+ res_len= =3D (DWORD)wcslen(domains_3_res) + 2;
+ err =3D ConvertItfDnsDomains(L"openvpn.com"= ;, domains_3, &size, BUF_SIZE);
+ assert_memory_equal(domains_3, domains_3_res, size);
+ assert_int_equal(s= ize, res_len * glyph_size);
+ assert_int_equal(err, NO_ERROR);
+
+ wchar_t domains_4[BUF_SIZE] =3D L"openvpn.com,openvpn.net&qu= ot;;
+ len =3D (DW= ORD)wcslen(domains_4) + 1;
+ size =3D orig_size =3D len * glyph_size;
+ wchar_t domains_4_res[BUF_SIZE] =3D L= ".openvpn.com\0.openvpn.net";
+ res_len =3D len + 3; /* adds two . and one \0 */
+ err =3D ConvertItf= DnsDomains(NULL, domains_4, &size, BUF_SIZE);
+ assert_memory_equal(domains_4, domains_4_= res, size);
+ asse= rt_int_equal(size, res_len * glyph_size);
+ assert_int_equal(err, NO_ERROR);
+}
+
+int
+wmain(void)
+{
+ openvpn_unit_test_setup();+ const struct CMUnitTest t= ests[] =3D {
+ = cmocka_unit_test(test_list_contains_domain),
+ cmocka_unit_test(test_convert_itf_dns_dom= ains),
+ };=
+
+ int ret =3D cmocka_run_group_tests_name(&= quot;openvpnserv tests", tests, NULL, NULL);
+
+ return ret;
+}

To view, visit change 1459. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I33583e51e1143c53fbe0aef1654= 6fa3f602b17c0
Gerrit-Change-Number: 1459
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --cBIaYZYsIcI=--