From: "flichtenheld (Code Review)" Date: Fri, 8 Dec 2023 16:29:53 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="r/xSRpfkpXg="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: add basic tests for static/dynamic challenges List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --r/xSRpfkpXg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=3Demail to review the following change. Change subject: test_user_pass: add basic tests for static/dynamic challeng= es ...................................................................... test_user_pass: add basic tests for static/dynamic challenges Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 61 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/475/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 600ec80..d006ab4 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -337,12 +337,73 @@ expect_assert_failure(get_user_pass_cr(&up, authfile, "UT", flags, NUL= L)); } +#ifdef ENABLE_MANAGEMENT +static void +test_get_user_pass_dynamic_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y= 3Ix:Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cr1"); + assert_string_equal(up.password, "CRV1::Om01u7Fh4LrGBS7uh0SWmzwabUiGiW= 6l::challenge_response"); +} + +static void +test_get_user_pass_static_challenge(void **state) +{ + struct user_pass up =3D { 0 }; + reset_user_pass(&up); + const char *challenge =3D "Please enter token PIN"; + unsigned int flags =3D GET_USER_PASS_STATIC_CHALLENGE; + + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); + will_return(query_user_exec_builtin, "cpassword"); + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, NULL, "UT", flags, challenge)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + /* SCRV1:cpassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); + + reset_user_pass(&up); + + flags |=3D GET_USER_PASS_INLINE_CREDS; + + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + expect_string(query_user_exec_builtin, query_user[i].prompt, "CHALLENG= E: Please enter token PIN"); + will_return(query_user_exec_builtin, "challenge_response"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "iuser\nipassword", "UT", flags, cha= llenge)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + /* SCRV1:ipassword:challenge_response but base64-encoded */ + assert_string_equal(up.password, "SCRV1:aXBhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc= 3BvbnNl"); +} +#endif /* ENABLE_MANAGEMENT */ + const struct CMUnitTest user_pass_tests[] =3D { cmocka_unit_test(test_get_user_pass_defined), cmocka_unit_test(test_get_user_pass_needok), cmocka_unit_test(test_get_user_pass_inline_creds), cmocka_unit_test(test_get_user_pass_authfile_stdin), cmocka_unit_test(test_get_user_pass_authfile_file), +#ifdef ENABLE_MANAGEMENT + cmocka_unit_test(test_get_user_pass_dynamic_challenge), + cmocka_unit_test(test_get_user_pass_static_challenge), +#endif /* ENABLE_MANAGEMENT */ }; int -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/475?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Gerrit-Change-Number: 475 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --r/xSRpfkpXg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

Vi= ew Change

test_user_pass: add basic tests for static/dynamic challenges=


Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a
Signed-off-= by: Frank Lichtenheld <frank@...2641...>
---
M tests/unit_tests= /openvpn/test_user_pass.c
1 file changed, 61 insertions(+), 0 deletions(= -)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/7=
5/475/1
diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/te=
sts/unit_tests/openvpn/test_user_pass.c
index 600ec80..d006= ab4 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c<= /span>
+++ b/tests/unit_tests/openvpn/test_user_pass.c
<= span>@@ -337,12 +337,73 @@

expect_assert_failure(get_u= ser_pass_cr(&up, authfile, "UT", flags, NULL));
}

+#ifdef ENABLE_MANAGEMENT
+static void
= +test_get_user_pass_dynamic_challenge(void **state)
+{
+ struct user_pass up =3D { 0 };
+ reset_user_pass(&up);
+ const char *challenge =3D &quo= t;CRV1:R,E:Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l:Y3Ix:Please enter token PIN&quo= t;;
+ unsigned int= flags =3D GET_USER_PASS_DYNAMIC_CHALLENGE;
+
+ expect_string(query_user_exec_builtin, query_user[i].prompt, "= ;CHALLENGE: Please enter token PIN");
+ will_return(query_user_exec_builtin, "chall= enge_response");
+ will_return(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, NUL= L, "UT", flags, challenge));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "cr1&= quot;);
+ assert_s= tring_equal(up.password, "CRV1::Om01u7Fh4LrGBS7uh0SWmzwabUiGiW6l::chal= lenge_response");
+
+static void
+test_get_user_pass_static_challenge(void = **state)
+{+ struct user_pass up =3D {= 0 };
+ reset_user= _pass(&up);
+ = const char *challenge =3D "Please enter token PIN";
+ unsigned int flags =3D GET_US= ER_PASS_STATIC_CHALLENGE;
+
+ expect_st= ring(query_user_exec_builtin, query_user[i].prompt, "Enter UT Username= :");
+ will_r= eturn(query_user_exec_builtin, "cuser");
+ expect_string(query_user_exec_builtin, q= uery_user[i].prompt, "Enter UT Password:");
+ will_return(query_user_exec_builtin, = "cpassword");
+ will_return(query_user_exec_builtin, true);
+ expect_string(query_user_exec_builtin= , query_user[i].prompt, "CHALLENGE: Please enter token PIN");

+ will_return(query_u= ser_exec_builtin, "challenge_response");
+ will_return(query_user_exec_builtin, tru= e);
+ assert_true(= get_user_pass_cr(&up, NULL, "UT", flags, challenge));<= br>+ assert_true(up.defined)= ;
+ assert_string_= equal(up.username, "cuser");
+ /* SCRV1:cpassword:challenge_response but base64-enc= oded */
+ assert_s= tring_equal(up.password, "SCRV1:Y3Bhc3N3b3Jk:Y2hhbGxlbmdlX3Jlc3BvbnNl&= quot;);
+
<= span style=3D"color: hsl(120, 100%, 40%);">+ reset_user_pass(&up);
+
+ flags |=3D GET_USER_PASS_INLINE_CRED= S;
+
+ /*FIXME: query_user_exec() calle= d even though nothing queued */
+ will_return(query_user_exec_builtin, true);
+ expect_string(query_user_exec_b= uiltin, query_user[i].prompt, "CHALLENGE: Please enter token PIN"= );
+ will_return(q= uery_user_exec_builtin, "challenge_response");
+ will_return(query_user_exec_builti= n, true);
+ assert= _true(get_user_pass_cr(&up, "iuser\nipassword", "UT"= ;, flags, challenge));
+ assert_string_equal(up.username, "iuser");=
+ /* SCRV1:ipassword:cha= llenge_response but base64-encoded */
+ assert_string_equal(up.password, "SCRV1:aXBhc3N3= b3Jk:Y2hhbGxlbmdlX3Jlc3BvbnNl");
+}
+= #endif /* ENABLE_MANAGEMENT */
+
const struct CMUnitTest user_pass_tests[] =3D = {
cmocka_unit_test(test_get_user_pass_defined),=
cmocka_unit_test(test_get_user_pass_needok),
cmocka_unit_test(test_get_user_pass_inline_creds),
= cmocka_unit_test(test_get_user_pass_authfile_stdin),
= cmocka_unit_test(test_get_user_pass_authfile_file),
+#ifdef ENABLE_MANAGEMENT
+ cmocka_unit_test(test_get_user_p= ass_dynamic_challenge),
+ cmocka_unit_test(test_get_user_pass_static_challenge),
+#endif /* ENABLE_MANAGEMENT */
};

int
<= /span>

To view, visit change 475. To unsubscribe, or for help writin= g mail filters, visit settin= gs.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b5570f6314e917f92dce072279= efe415d79b22a
Gerrit-Change-Number: 475
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--r/xSRpfkpXg=--