From: "cron2 (Code Review)" Date: Tue, 13 Jan 2026 07:23:25 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="x7C3Xbry4uI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: socks: Fix wrong success check in socks_username_password_auth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --x7C3Xbry4uI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1466?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: socks: Fix wrong success check in socks_username_password_a= uth ...................................................................... socks: Fix wrong success check in socks_username_password_auth Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466 Message-Id: <20260112180304.8742-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 219.html Signed-off-by: Gert Doering --- M src/openvpn/socks.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/1466/2 diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index 671d33c..078b4e1 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -143,7 +143,7 @@ } /* VER =3D 5, SUCCESS =3D 0 --> auth success */ - if (buf[0] !=3D 5 && buf[1] !=3D 0) + if (buf[0] !=3D 5 || buf[1] !=3D 0) { msg(D_LINK_ERRORS, "socks_username_password_auth: server refused t= he authentication"); goto cleanup; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Gerrit-Change-Number: 1466 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --x7C3Xbry4uI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

socks: Fix wrong success check in s=
ocks_username_password_auth

Due to wrong boolean operator the functi= on did not
correctly detect when the authentication failed.

Repor= ted-By: Joshua Rogers <contact@...2949...>
Found-By: ZeroPath (htt= ps://zeropath.com)
Github: openvpn-private-issues#4
Change-Id: I13b41= 1fb3e8b913ae049c6ca8a1cf5a2edbab0fb
Signed-off-by: Frank Lichtenheld <= ;frank@...2641...>
Acked-by: Gert Doering <gert@...1296...>
= Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466
Message-Id: <= 20260112180304.8742-1-gert@...1296...>
URL: https://www.mail-archive.= com/openvpn-devel@lists.sourceforge.net/msg35219.html
Signed-off-by: Ger= t Doering <gert@...1296...>
---
M src/openvpn/socks.c
1 file= changed, 1 insertion(+), 1 deletion(-)

git pull=
 ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/1466/2
diff=
 --git a/src/openvpn/socks.c b/src/openvpn/socks.c
index 67= 1d33c..078b4e1 100644
--- a/src/openvpn/socks.c
<= span>+++ b/src/openvpn/socks.c
@@ -143,7 +143,7 @@ }

/* VER =3D 5, SUCCESS= =3D 0 --> auth success */
- if (buf[0] !=3D 5 && buf[1] !=3D 0)
+ if (buf[0] !=3D 5 || buf[1] !=3D 0)=
{
msg(D_LINK_ERRORS, "s= ocks_username_password_auth: server refused the authentication");
goto cleanup;

To v= iew, visit change 1466. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1= cf5a2edbab0fb
Gerrit-Change-Number: 1466
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --x7C3Xbry4uI=--