From: "cron2 (Code Review)" Date: Tue, 13 Jan 2026 07:23:28 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uOyG59nUSUE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: socks: Fix wrong success check in socks_username_password_auth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --uOyG59nUSUE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/14= 66?usp=3Demail ) Change subject: socks: Fix wrong success check in socks_username_password_a= uth ...................................................................... socks: Fix wrong success check in socks_username_password_auth Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466 Message-Id: <20260112180304.8742-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 219.html Signed-off-by: Gert Doering --- M src/openvpn/socks.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index 671d33c..078b4e1 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -143,7 +143,7 @@ } /* VER =3D 5, SUCCESS =3D 0 --> auth success */ - if (buf[0] !=3D 5 && buf[1] !=3D 0) + if (buf[0] !=3D 5 || buf[1] !=3D 0) { msg(D_LINK_ERRORS, "socks_username_password_auth: server refused t= he authentication"); goto cleanup; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Gerrit-Change-Number: 1466 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --uOyG59nUSUE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

socks: Fix wrong success check in socks_username=
_password_auth

Due to wrong boolean operator the function did notcorrectly detect when the authentication failed.

Reported-By: Joshu= a Rogers <contact@...2949...>
Found-By: ZeroPath (https://zeropath= .com)
Github: openvpn-private-issues#4
Change-Id: I13b411fb3e8b913ae0= 49c6ca8a1cf5a2edbab0fb
Signed-off-by: Frank Lichtenheld <frank@...2716...= 1...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: h= ttps://gerrit.openvpn.net/c/openvpn/+/1466
Message-Id: <2026011218030= 4.8742-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-d= evel@lists.sourceforge.net/msg35219.html
Signed-off-by: Gert Doering <= ;gert@...1296...>
---
M src/openvpn/socks.c
1 file changed, 1 i= nsertion(+), 1 deletion(-)

diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c
i= ndex 671d33c..078b4e1 100644
--- a/src/openvpn/socks.c
+++ b/src/openvpn/socks.c
@@ -143,7 +143,7 @@
}

/* VER =3D 5, = SUCCESS =3D 0 --> auth success */
- if (buf[0] !=3D 5 && buf[1] !=3D 0)
+ if (buf[0] !=3D 5 || buf[1] = !=3D 0)

{
msg(D_LINK_ERRORS, = "socks_username_password_auth: server refused the authentication"= );
goto cleanup;

=

To view, visit change 1466. To unsubscribe, or for help writing mail filters= , visit settings= .

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1= cf5a2edbab0fb
Gerrit-Change-Number: 1466
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --uOyG59nUSUE=--