Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E004C001DF for ; Mon, 31 Jul 2023 14:48:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.573121.897518 (Exim 4.92) (envelope-from ) id 1qQUBn-0006hm-UP; Mon, 31 Jul 2023 14:48:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573121.897518; Mon, 31 Jul 2023 14:48:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQUBn-0006hf-QL; Mon, 31 Jul 2023 14:48:03 +0000 Received: by outflank-mailman (input) for mailman id 573121; Mon, 31 Jul 2023 14:48:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQUBm-0006hX-Rs for xen-devel@lists.xenproject.org; Mon, 31 Jul 2023 14:48:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ebd030c-2fb1-11ee-8613-37d641c3527e; Mon, 31 Jul 2023 16:48:00 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 14CAC4EE0737; Mon, 31 Jul 2023 16:48:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ebd030c-2fb1-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 31 Jul 2023 16:48:00 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/4] xen/pci: rename local variable to address MISRA C:2012 Rule 5.3 In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 31/07/2023 16:16, Jan Beulich wrote: > On 31.07.2023 15:34, Nicola Vetrini wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -650,12 +650,12 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn, >> struct pci_seg *pseg; >> struct pci_dev *pdev; >> unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn); >> - const char *pdev_type; >> + const char *pci_dev_type; > > I've always been wondering what purpose the pdev_ prefix served here. > There's no other "type" variable in the function, so why make the name > longer? (I'm okay to adjust on commit, provided you agree.) > > Jan No objections. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)