Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71DC1C2D0A8 for ; Mon, 28 Sep 2020 14:49:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1304A21941 for ; Mon, 28 Sep 2020 14:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="hwnjsq//" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1304A21941 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMuT8-0004Zv-6A; Mon, 28 Sep 2020 14:49:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMuT7-0004Zq-1P for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 14:49:33 +0000 X-Inumbo-ID: d8b3f5b8-98fe-42f4-9351-1dc60cf21e62 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8b3f5b8-98fe-42f4-9351-1dc60cf21e62; Mon, 28 Sep 2020 14:49:32 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601304571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fig0WtH43WaF4/PZ1MYTmGpfGIGdKmVWSYlRVCSj7tI=; b=hwnjsq//77OT9Jydq7yrkquXa9tpM/MgJs9uS89IWG8QiA8W+jMvKp61907kjlFUkpQgH/ Iu4kQ/CJvBEaw2xvl7HEKcL06rh+G8LivuU/hUhgurQCtRHQVA68l65uRXOhQiK5Oru/OM aXP9by+hRHjPiovmb9t1GlJXWhQ8uug= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4FD13B18A; Mon, 28 Sep 2020 14:49:31 +0000 (UTC) Subject: Re: [PATCH 1/5] x86: introduce read_sregs() to allow storing to memory directly To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <6cd5dfca-a10c-0847-c084-a511ab2cbb1c@suse.com> <46c1f7b6-6c96-9c81-849e-4e44ed341ccb@citrix.com> From: Jan Beulich Message-ID: Date: Mon, 28 Sep 2020 16:49:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <46c1f7b6-6c96-9c81-849e-4e44ed341ccb@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 28.09.2020 14:47, Andrew Cooper wrote: > On 28/09/2020 13:05, Jan Beulich wrote: >> --- a/xen/include/asm-x86/regs.h >> +++ b/xen/include/asm-x86/regs.h >> @@ -15,4 +15,18 @@ >> (diff == 0); \ >> }) >> >> +#define read_sreg(name) ({ \ >> + unsigned int __sel; \ >> + asm volatile ( "mov %%" STR(name) ",%0" : "=r" (__sel) ); \ >> + __sel; \ >> +}) >> + >> +static inline void read_sregs(struct cpu_user_regs *regs) >> +{ >> + asm volatile ( "mov %%ds, %0" : "=m" (regs->ds) ); >> + asm volatile ( "mov %%es, %0" : "=m" (regs->es) ); >> + asm volatile ( "mov %%fs, %0" : "=m" (regs->fs) ); >> + asm volatile ( "mov %%gs, %0" : "=m" (regs->gs) ); > > It occurs to me that reads don't need to be volatile.  There are no side > effects. I'll do the same for what patches 3 and 5 alter anyway, assuming this won't invalidate your R-b there. Jan