From: Maarten Lankhorst Subject: Re: [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2. Date: Mon, 6 Nov 2017 16:43:17 +0100 Message-ID: References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> <20171101152903.GF10981@intel.com> <20171101170019.GG10981@intel.com> <20171106140120.GH10981@intel.com> <20171106140607.GI10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171106140607.GI10981@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMDYtMTEtMTcgb20gMTU6MDYgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gTW9uLCBO b3YgMDYsIDIwMTcgYXQgMDQ6MDE6MjBQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ PiBPbiBUaHUsIE5vdiAwMiwgMjAxNyBhdCAwOTo1NTo0MEFNICswMTAwLCBNYWFydGVuIExhbmto b3JzdCB3cm90ZToKPj4+IE9wIDAxLTExLTE3IG9tIDE4OjAwIHNjaHJlZWYgVmlsbGUgU3lyasOk bMOkOgo+Pj4+IE9uIFdlZCwgTm92IDAxLCAyMDE3IGF0IDA0OjU1OjA2UE0gKzAxMDAsIE1hYXJ0 ZW4gTGFua2hvcnN0IHdyb3RlOgo+Pj4+PiBPcCAwMS0xMS0xNyBvbSAxNjoyOSBzY2hyZWVmIFZp bGxlIFN5cmrDpGzDpDoKPj4+Pj4+IE9uIFdlZCwgTm92IDAxLCAyMDE3IGF0IDA0OjA0OjMzUE0g KzAxMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+Pj4+Pj4+IFRoaXMgaW50cm9kdWNlcyBh IHNsaWdodCBiZWhhdmlvcmFsIGNoYW5nZSB0byBybWZiLiBJbnN0ZWFkIG9mCj4+Pj4+Pj4gZGlz YWJsaW5nIGEgY3J0YyB3aGVuIHRoZSBwcmltYXJ5IHBsYW5lIGlzIGRpc2FibGVkLCB3ZSB0cnkg dG8KPj4+Pj4+PiBwcmVzZXJ2ZSBpdC4KPj4+Pj4+Pgo+Pj4+Pj4+IEFwYXJ0IGZyb20gb2xkIHZl cnNpb25zIG9mIHRoZSB2bXdnZnggeG9yZyBkcml2ZXIsIHRoZXJlIGlzCj4+Pj4+Pj4gbm90aGlu ZyBkZXBlbmRpbmcgb24gcm1mYiBkaXNhYmxpbmcgYSBjcnRjLgo+Pj4+Pj4+Cj4+Pj4+Pj4gVm13 Z2Z4JyBhbmQgc2ltcGxlIGttcyBoZWxwZXIgYXRvbWljIGltcGxlbWVudGF0aW9uIHJlamVjdHMg Q1JUQwo+Pj4+Pj4+IGVuYWJsZWQgd2l0aG91dCBwbGFuZSwgc28gd2UgY2FuIGRvIHRoaXMgc2Fm ZWx5Lgo+Pj4+IFRoZSBjb2RlIGZvciB0aG9zZSBzZWVtcyBhIGJpdCBpbmNvbnNpc3RlbnQuIFRo ZSBjcnRjIGNoZWNrIHJlcXVpcmVzCj4+Pj4gdGhhdCB0aGUgY3J0YyBzdGF0ZSBhbmQgcGxhbmUg c3RhdGUgbWF0Y2guIEJ1dCB0aGUgcGxhbmUgY2hlY2sgYWxsb3dzCj4+Pj4gdGhlIHBsYW5lIHRv IGJlIGVuYWJsZWQgdy9vIHRoZSBjcnRjIGJlaW5nIGVuYWJsZWQuIEkgZ3Vlc3MgaXQgZG9lc24n dAo+Pj4+IG1hdHRlciByZWFsbHkgc2luY2UgeW91IGNhbid0IGVuYWJsZSB0aGUgcGxhbmUgd2l0 aG91dCBhIGNydGMsIGFuZCB0aGUKPj4+PiBjcnRjIGNoZWNrIHdvdWxkIHRoZW4gY2F0Y2ggdGhl IGNhc2Ugd2hlcmUgdGhlIGNydGMgd291bGQgYmUgZGlzYWJsZWQuCj4+PiBFeGFjdGx5LiA6LSkg T25seSB3aGVuIGEgcGxhbmUgaXMgdW5ib3VuZCBhbmQgc3RheXMgdW5ib3VuZCwgdGhlIGNydGMg Y2hlY2sgd29uJ3QKPj4+IGJlIGludm9rZWQuIEhlbmNlIGl0J3MgdGhlIG1vc3QgYWNjdXJhdGUg d2F5IG9mIG1ha2luZyBzdXJlIHRoYXQKPj4+IGNydGMgZW5hYmxlZCA8PT4gcHJpbWFyeSBwbGFu ZSBib3VuZC4KPj4+Cj4+PiBJZiB0aGUgY2hlY2sgd2FzIGRvbmUgaW4gdGhlIHByaW1hcnkgcGxh bmUsIGFuIGF0b21pYyBtb2Rlc2V0IGNvdWxkIGVuYWJsZQo+Pj4gdGhlIGNydGMgd2l0aG91dCBl bmFibGluZyB0aGUgcHJpbWFyeSBwbGFuZSwgd2hpY2ggc2hvdWxkbid0IGJlIGFsbG93ZWQgYnV0 Cj4+PiBhIHBsYW5lIGNoZWNrIHdvbid0IGNhdGNoIGl0Lgo+Pj4gVGhpcyBoYXMgYmVlbiBhIGJ1 ZyBpbiBzaW1wbGUta21zLWhlbHBlciwgZml4ZWQgaW4gdGhlIGJlbG93IGNvbW1pdDoKPj4+Cj4+ PiBjb21taXQgNzY1ODMxZGMyN2FiMTQxYjNhMGJlMWFiNTViOTIyYjAxMjQyNzkwMgo+Pj4gQXV0 aG9yOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29t Pgo+Pj4gRGF0ZTogICBXZWQgSnVsIDEyIDEwOjEzOjI5IDIwMTcgKzAyMDAKPj4+Cj4+PiAgICAg ZHJtL3NpbXBsZS1rbXMtaGVscGVyOiBGaXggdGhlIGNoZWNrIGZvciB0aGUgbWlzbWF0Y2ggYmV0 d2VlbiBwbGFuZSBhbmQgQ1JUQyBlbmFibGVkLgo+PiBIbW0uIE9LIHRoYXQgcGFydCBsb29rcyBP Sy4gV2hhdCBkb2VzIHNlZW0gYSBiaXQgaW5jb25zaXN0ZW50IGlzIHRoZQo+PiBmYWN0IHRoYXQg d2UgcGFzcyBjYW5fdXBkYXRlX2Rpc2FibGVkPXRydWUsIGJ1dCBsYXRlciBvbiB3ZSByZWplY3Qg dGhlCj4+IHVwZGF0ZSB3aGVuIHZpc2libGU9PWZhbHNlLiBUaGUgb2xkIGNvZGUgd291bGQgaGF2 ZSBhY2NlcHRlZCB0aGF0Cj4+IGJlY2F1c2UgaXQgZGlkbid0IGV2ZW4gY2FsbCBkcm1fcGxhbmVf aGVscGVyX2NoZWNrX3N0YXRlKCkgd2hlbiB0aGUKPj4gY3J0YyAoYW5kIHRodXMgYWxzbyB0aGUg cGxhbmUpIHdhcyBkaXNhYmxlZC4KPiBBY3R1YWxseSBob3cgZG9lcyB0aGlzIHdvcmsgYXQgYWxs PyBJZiB5b3UgdHVybiBvZmYgYm90aCB0aGUgY3J0YyBhbmQKPiBwbGFuZSwgdGhlbiB0aGUgcGxh bmUgY2hlY2sgd2lsbCBhbHdheXMgcmV0dXJuIC1FSU5WQUwgb24gYWNjb3VudCBvZgo+IHZpc2li bGU9PWZhbHNlPwo+CklmIHRoZSBjcnRjIGlzIHR1cm5lZCBvZmYsIGVuYWJsZWQgPSBmYWxzZSBh bmQgdGhlIHByaW1hcnkgcGxhbmUgaXMgbm90IGluIGNydGNfc3RhdGUtPnBsYW5lX21hc2suwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCgpW aXNpYmlsaXR5IGlzIGlnbm9yZWQgaW4gdGhpcyBjaGVjaywgdGhhdCBwYXJ0IGlzIGhhbmRsZWQg aW4gcGxhbmUgY2hlY2sgdGhhdCB0aGUgZnJhbWVidWZmZXIgaGFzIHRvIHNwYW4gdGhlIGVudGly ZSBjcnRjIGlmIGVuYWJsZWQuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK