Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4F8B2AF1D for ; Wed, 15 Jul 2026 00:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074262; cv=none; b=i6zH1M0tY+UylPZR8h3o7NpkmcxyekaDEqcwoIdhwVZ8pjRoAusSf05CRyNDJm9RKCKgLdfcEaS0FVfPBfxDPaAIDuYMBM5cTfRHtdAEqnMG+UatrWkON9k7xRbByVEnj+0Rdlulbm1XeBWWlIdq7PIkQJAtAN2xRxCcsV0JF4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784074262; c=relaxed/simple; bh=jyuIb9mUMhDLcJdZztNW/kggE4C4qT3I1JbKcllNvbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=af5oRmambTQX2uRFEEg/sljEN+d1fjtHFUSZCripTV95oIM4x4GUe/uuIe09f/ygYxlMSiB/Uzoj9arcdEd+lZqgkLPAxC2+kN7fR4oO2qpxZXwCTOak9zSXW/hYL/pRdyVcyHMXnx9OI4UcPNQhlNqqMVrxl2tnwzLjAdSAI5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FcX++nky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RHBVfvjV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FcX++nky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RHBVfvjV" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EIw9re1136462 for ; Wed, 15 Jul 2026 00:11:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=FcX++nky+6nttwcS 1fmRDRruTiF9tAVKFfDzbeFXAL6ULDCdWlA5wiKPP5AuweEW7F6qGxUPPzHZINbl YDpUR64KjcCPF+tPkj4hM+vYKWvIo+miKIKTWkFwV5B2i1W0+sd552SchGt4nH+C bWZJRym20fmj1y/h9HVagYJ9Bg9pVx132noahPceJ/m7UvJLVExO8vDwNyMzugR1 qtfCjOGkX69er+84c5t3xebI4urvLrE83/lI0aCJpZZuu8XgkOHvI8joammuOmZR bs0oDoayBBdFMwZTwiSNISeh8/BtLCFabEgHw74Wvj7AXayv3DBO6IEU3FXzNeUm wgxkrA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fds9mh76h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 00:11:00 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2caa9a3cf7aso1426075ad.0 for ; Tue, 14 Jul 2026 17:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784074259; x=1784679059; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=RHBVfvjVObL+oKPfxPhy5rIgsC1I6Sp12vIi4/cqRWiH7V7J2qfN4StyAT7/k6nAAx 0Zy9sEFtlr+BD7iVmo9s1fxo3yCp93vq7E13w9DJ5Mo80Xluf85KCD3Cyh1KsWhqOl5c R/0bdJQDOKeDLpqTmWwSEWfe0UiIdArluzk90JyUTTL4c3OvLnG6puk1lFGdBoeQE7et UpPw6eSGdR+OB+gm1m0oviBpI2G7Nik3yjOIyeftm4udo6EqJc/79g0pl1f7/i8mjg9K Re7K2Wh1wo/xVAtuEp7nwS4i/jZeQJ33ZcFBnAKsrXuBBAruvKnm6thiD1rbPxdgcUFE 9zbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784074259; x=1784679059; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/0LJ9xDxqz4B6c+cfB3c1tEAaHQFTTe9Ptnd/5JugYI=; b=EFapwK7as1IkH5vWv/1KAvAScX2Z2KFG/kb9bbH1d6FytiPTMJVZlP0FhlGWq2eUsX ZOeT6SOEU5ZFJYBhaWH/+fvTAVK6v8WXyxC2LgEaKOF2+QZ7DUgW35AzPulKjbuL42tk A9igaOcyfDk8aMXrUstq3bUh2xWiYJS4vM1AzW6Xa9iGvpicxpsOm2Bn+4p8zBRWUqwf eXPRD6khlxNnNxH+siEhghL1spb3z8y8JWpfV6FGSph8BMu29NuLGcHqnbf87l8gHd4D F3MIlg3Ll75rjICVvr6RD+ISJ9FbTDKcSwDt6mhsL+O3T2V/7PsrwZ3gbSg7VPl6lwbK Q+Eg== X-Forwarded-Encrypted: i=1; AHgh+Ro8Q8PKlI9uLep50G5aCt20SiBzKQR2cvZ7OLKZTj24qGvxgDY3A5+3Lm/E/OXq3n9oaU/8tCNDh2R4ldWZ9lI=@vger.kernel.org X-Gm-Message-State: AOJu0YyBggqWge//8QaHmqMpeH+5wzEJx5BC1UNp2QgGaHcfIq0Ux8jC 9nN5qWF2fAFMtfeZP9BPp2OS1lw6vf0LtdI3gTMfEjki/+vXRHFmLRdxWnYtJOzDPp1tTllsRKC L4LEWnPGldoJg0Cj9YtSncA22dydLUXjdvoSJh2PUA8Ygztm1FIeTiqpTIh9O1UYcv3e2D40= X-Gm-Gg: AfdE7cm51rZ0d3er0+JpXqBMbrVnHLiN2F4UpQQQZTnar5tcY1saKkabTb55/VO8FXj F1L6jS4nwafp64zDYYs3avL+0fYu6d1qw0EQbpZG7Tnoyskobe8cqLTLLEq+vFn3epxCwEG/VWB J+xkWuspUA29vUCQKkXJ0LecTbi/TL4iXF+lwDrIaRSKEKmNhZZzFEOOq6YCIRHa90vK95hiZHd wkrAGz1wRwZM/XIDih2ktCGPYi2fr6DzcxfsAf+ujPfk4CvCJwlEaK5AydM4tMu2GEb42Ebdm5F FUmn5dOw+D7FEtblDp5Vj6v+FKs57C3H8L1tNY9fzgw0VS21++gDC5lCuelr1SDn6Zi4i1Thjlp YXSd0PrnxgjngCfwtwBn9bK1x2j0m7JAIRIgKh8O2 X-Received: by 2002:a17:903:2406:b0:2c7:c385:c5a7 with SMTP id d9443c01a7336-2ce8297869amr179293305ad.26.1784074259345; Tue, 14 Jul 2026 17:10:59 -0700 (PDT) X-Received: by 2002:a17:903:2406:b0:2c7:c385:c5a7 with SMTP id d9443c01a7336-2ce8297869amr179293065ad.26.1784074258759; Tue, 14 Jul 2026 17:10:58 -0700 (PDT) Received: from [10.239.133.197] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d59e40sm124537915ad.75.2026.07.14.17.10.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 17:10:58 -0700 (PDT) Message-ID: Date: Wed, 15 Jul 2026 08:10:53 +0800 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cpufreq: spear: Fix an IS_ERR() vs NULL bug in spear1340_set_cpu_rate() To: Dan Carpenter , Deepak Sikri Cc: "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: Content-Language: en-US From: Zhongqiu Han In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDI0OSBTYWx0ZWRfX3Jb74nTQ763P 1iqia3nnkJ0Tb27dHx5B0eOhmeKlnJSlELZ9r38OVdhpprVfLUW59LlCfJyJURRnrV1EuGrC1zm Dod6+TabpXSH5wDnhJNWPSiCqJCxYLSw4L1hQY4FzTH18MNAnYYDcT6s0yhVrMEeA0RuY8frJU0 PfyX/COpIkd4LHA8VXCkxwtNQTTN2PHarBav0Wl6JIjL6X5lyF/NgoKTgCKaa9gu1QwUPtGQfqZ htrR0uRmjWj227HqoSC5oRuIEmJvGoFQ+DIeJyTH51Rtbp32kSh/HK3v0Y7YxA/nY/wzr79KV/v 3EYe/SzASllDOTMpEOwfYJUHi29ZqpFIpmYufHx+1zq9GMUrCybVJDjlXPSYG8PA4ocb32qJ6R9 /yTCyqRxlGbocc5tpnLxH/+HnGlClx4ITRG/pUi4XWwVIEVI4+lUhkIBoRkGjSwTTua9AwKxeLa q6XcE6uf/mc3oGkeGoQ== X-Proofpoint-ORIG-GUID: Ityb8bS3Gg4h7QwdEf18a51OBf8dWx2Y X-Proofpoint-GUID: Ityb8bS3Gg4h7QwdEf18a51OBf8dWx2Y X-Authority-Analysis: v=2.4 cv=E+79Y6dl c=1 sm=1 tr=0 ts=6a56d014 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=N0crexS4lfU0QNQj-gkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDI0OSBTYWx0ZWRfX7TaBEIHUy/yk WB11jH23I6fEi54maOCYp/tndQmTkBXR8XoEsUo0k4gGEoJBtJ5k2h1WwciTRYK4lj5Ub0MN4Z8 yYFDeS0hHJ3VgZ5EL19UruRfRC+lCsc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_05,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140249 On 7/14/2026 11:46 PM, Dan Carpenter wrote: > The clk_get_parent() function doesn't return error pointers, it returns > NULL on error. Update the error checking to match. > > Fixes: 420993221175 ("cpufreq: SPEAr: Add CPUFreq driver") > Signed-off-by: Dan Carpenter > --- > v2: fix subsystem prefix in subject Reviewed-by: Zhongqiu Han > > drivers/cpufreq/spear-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 81a0780b2ebf..ffe5eda82f0b 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -79,9 +79,9 @@ static int spear1340_set_cpu_rate(struct clk *sys_pclk, unsigned long newfreq) > int ret = 0; > > sys_clk = clk_get_parent(spear_cpufreq.clk); > - if (IS_ERR(sys_clk)) { > + if (!sys_clk) { > pr_err("failed to get cpu's parent (sys) clock\n"); > - return PTR_ERR(sys_clk); > + return -EINVAL; > } > > /* Set the rate of the source clock before changing the parent */ -- Thx and BRs, Zhongqiu Han