From: "plaisthos (Code Review)"
Date: Tue, 20 Jan 2026 18:18:07 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="4WvkDMxloPU="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Silence compiler
truncation warning by checking snprintf return value
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , openvpn-devel
--4WvkDMxloPU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by plaisthos. ( http://gerrit.=
openvpn.net/c/openvpn/+/1272?usp=3Demail )
Change subject: Silence compiler truncation warning by checking snprintf re=
turn value
......................................................................
Patch Set 4:
(2 comments)
File src/openvpn/tun.c:
http://gerrit.openvpn.net/c/openvpn/+/1272/comment/82bebc2d_983e8fec?usp=3D=
email :
PS3, Line 3565: M_FATAL
> I think M_FATAL is too drastic here. [=E2=80=A6]
changed to M_WARN and continue
http://gerrit.openvpn.net/c/openvpn/+/1272/comment/79e63da6_66dea17c?usp=3D=
email :
PS3, Line 3680: msg(M_FATAL, "Error constructing connection str=
ing for %s", enum_name);
> I think M_FATAL is too drastic here. [=E2=80=A6]
changed to M_WARN and continue
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1272?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852
Gerrit-Change-Number: 1272
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 20 Jan 2026 18:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
--4WvkDMxloPU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: flichtenheld.
View =
Change
2 comments:
changed to M_WARN and continue
Patch S=
et #3, Line 3680: =
msg(M_FATAL, "Error constructing connection string for %s"=
, enum_name);
I think M_FATAL is too drastic here. [=
=E2=80=A6]
changed to M_WARN and continue
To view, visit change 1272. To unsubscribe, or for help writing mail =
filters, visit s=
ettings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I54b11a5540fb236580a3b80c6d1=
e8678b24bd852
Gerrit-Change-Number: 1272
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 20 Jan 2026 18:18:07=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
=
--4WvkDMxloPU=--