Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 021CCC0015E for ; Fri, 14 Jul 2023 17:34:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 07BD786E01; Fri, 14 Jul 2023 19:34:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="mPGwrGom"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="DdTexXw0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B7AED86DF4; Fri, 14 Jul 2023 19:34:11 +0200 (CEST) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1392086DF7 for ; Fri, 14 Jul 2023 19:34:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4R2drJ5gPFz9ssn; Fri, 14 Jul 2023 19:34:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1689356048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WpbJWI4gi5t7DMSQpG55nkTmFmsDOlHemsWKz04fuXE=; b=mPGwrGomGndDSMix1eor1BMyYRfS0YKkqnPO23EFu5K/TpdKFa+qCtU1krbBq77aiu+ATf Y4kcjaWVBeu5gf0Zh6vlJKIoCWpDlsNsc4XCOWDMi+lPHsGa1lb31lBXsNk8OOVlZlNP9e 5pa72NnD6P965zLQfxzv7ixFNSHMgPSXb1cjpwjlWLqn7O1Ndxh3A/nv++3F2hQp262xWi 1pkh/cDoTHmNhm/gDomvIKUdeIOHllN19QSggJDtQkcPdD79URN1H2xAc4GDchwRlqxdms 89Y/eZMaFTCUh8W0ZJ7HZk0yEKOaxtaQp+vwCCaspnH/SDsow8jMSG5JGeHwJg== Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1689356047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WpbJWI4gi5t7DMSQpG55nkTmFmsDOlHemsWKz04fuXE=; b=DdTexXw00nd++9enGmCc6pAsCeq3Ai9/VfwYtarZXEnE/LmQpcDgtWZusFm7N73bp9hPsG WU1E/J4U5uaE3VcTkui1TwnRAF3qLvDliffYQXSzQoNKou66hEAQuXzau049SVTTmk6LuB iREU7zBg5ZeYR0HD3fgOMo0OZzBwpCQgufJ8tDu6ZkvUMHV6/1cwbc+5F7rJMEItarmEHk MKEMvikJ52vd3mTyzw3NZNgMzZvnkonEtv/FARcT0migoGYoep9oY4woDtmW6RFUTjmPsw lbBVMv9EXE5eDscQ8QWanHn9BTZ0M9GO9eSA1OAc8ttEO9cxxCNbqjzAI9HPeg== Date: Fri, 14 Jul 2023 19:33:01 +0200 MIME-Version: 1.0 Subject: Re: [PATCH v3 5/6] sysinfo: rcar3: Use int instead of char for revision Content-Language: en-US To: Detlev Casanova , u-boot@lists.denx.de Cc: Marek Vasut , Hai Pham , Tam Nguyen , Simon Glass References: <20230714164424.838842-1-detlev.casanova@collabora.com> <20230714164424.838842-6-detlev.casanova@collabora.com> From: Marek Vasut In-Reply-To: <20230714164424.838842-6-detlev.casanova@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: d103e326a4def800409 X-MBO-RS-META: p8kjsc1ieg5gtony4hncxzorp1qymt7y X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/14/23 18:43, Detlev Casanova wrote: > To be used with the sysinfo command, revision values must be considered > as integers, not chars as some boards will implement BOARD_REVISION_* > and might use numbers greater than 9. > > Signed-off-by: Detlev Casanova > --- > drivers/sysinfo/rcar3.c | 104 ++++++++++++++++++++++++---------------- > 1 file changed, 62 insertions(+), 42 deletions(-) > > diff --git a/drivers/sysinfo/rcar3.c b/drivers/sysinfo/rcar3.c > index 7b127986da7..450a4c26773 100644 > --- a/drivers/sysinfo/rcar3.c > +++ b/drivers/sysinfo/rcar3.c > @@ -68,90 +68,110 @@ static void sysinfo_rcar_parse(struct sysinfo_rcar_priv *priv) > bool salvator_xs = false; > bool ebisu_4d = false; > bool condor_i = false; > - char rev_major = '?'; > - char rev_minor = '?'; > + char model[64]; > + char rev[4] = "?.?"; > + u8 rev_major = 0; > + u8 rev_minor = 0; > > switch (board_id) { > case BOARD_SALVATOR_XS: > salvator_xs = true; > fallthrough; > case BOARD_SALVATOR_X: > + snprintf(model, sizeof(model), > + "Renesas Salvator-X%s board", salvator_xs ? "S" : ""); > if (!(board_rev & ~1)) { /* Only rev 0 and 1 is valid */ > - rev_major = '1'; > - rev_minor = '0' + (board_rev & BIT(0)); > + rev_major = 1; > + rev_minor = board_rev & BIT(0); > + snprintf(rev, sizeof(rev), "%u.%u", rev_major, rev_minor); > } > - snprintf(priv->boardmodel, sizeof(priv->boardmodel), > - "Renesas Salvator-X%s board rev %c.%c", > - salvator_xs ? "S" : "", rev_major, rev_minor); > + > + snprintf(priv->boardmodel, sizeof(priv->boardmodel), "%s rev %s", > + model, rev); Is there really no way to do this with single snprintf() call instead of two snprintf() calls ?