From: "cron2 (Code Review)" Date: Mon, 4 Aug 2025 19:57:28 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="VMih2Ci2c6I="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix build error with clang-cl on latest Windows SDK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --VMih2Ci2c6I= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1127?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fix build error with clang-cl on latest Windows SDK ...................................................................... Fix build error with clang-cl on latest Windows SDK Found when testing windows-2025 runner in GHA. So switch to that to make sure the error is fixed. Change-Id: I3046f4b09a4700001a1d9dcce802990dfa701b52 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250804195054.21729-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 513 Signed-off-by: Gert Doering --- M .github/workflows/build.yaml M src/openvpn/syshead.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/27/1127/2 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b2bfd21..f7883c7 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -116,7 +116,7 @@ arch: [x86, x64] test: [argv, auth_token, buffer, cryptoapi, crypto, misc, ncp, pac= ket_id, pkt, provider, ssl, tls_crypt, user_pass] - runs-on: windows-latest + runs-on: windows-2025 name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL" steps: - name: Checkout OpenVPN @@ -264,7 +264,7 @@ env: BUILD_CONFIGURATION: Release - runs-on: windows-latest + runs-on: windows-2025 steps: - uses: actions/checkout@...2844... # v4.2.2 - uses: lukka/get-cmake@...2897... # v4.0.3 diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index 524923b..26a553b 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/syshead.h @@ -44,7 +44,7 @@ #define srandom srand #endif -#ifdef _MSC_VER /* Visual Studio */ +#if defined(_MSC_VER) && !defined(__clang__) /* Microsoft compiler */ #define __func__ __FUNCTION__ #define __attribute__(x) #endif -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1127?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3046f4b09a4700001a1d9dcce802990dfa701b52 Gerrit-Change-Number: 1127 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --VMih2Ci2c6I= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

Fix build error with clang-cl on latest Windows SDK<=
br>
Found when testing windows-2025 runner in GHA.
So switch to that = to make sure the error is fixed.

Change-Id: I3046f4b09a4700001a1d9dc= ce802990dfa701b52
Signed-off-by: Frank Lichtenheld <frank@...2641...&= gt;
Acked-by: Gert Doering <gert@...1296...>
Message-Id: <20= 250804195054.21729-1-gert@...1296...>
URL: https://www.mail-archive.c= om/openvpn-devel@lists.sourceforge.net/msg32513
Signed-off-by: Gert Doer= ing <gert@...1296...>
---
M .github/workflows/build.yaml
M s= rc/openvpn/syshead.h
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/27/112=
7/2
diff --git a/.github/workflows/build.yaml b/.github/workflows/b=
uild.yaml
index b2bfd21..f7883c7 100644
---= a/.github/workflows/build.yaml
+++ b/.github/workflows/bui= ld.yaml
@@ -116,7 +116,7 @@
arch: = [x86, x64]
test: [argv, auth_token, buffer, crypto= api, crypto, misc, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass= ]

- = runs-on: windows-latest
+ runs-on: windows-2025
name: "mingw unit= test ${{ matrix.test }} - ${{ matrix.arch }} - OSSL"
= steps:
- name: Checkout OpenVPN
= @@ -264,7 +264,7 @@
env:
BU= ILD_CONFIGURATION: Release

- runs-on: windows-latest
+ runs-on: windows-2025
steps:
- uses: actions/checkout@...2844...= # v4.2.2
- uses: lukka/get-cmake@...2897... # v4.0.= 3
diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.= h
index 524923b..26a553b 100644
--- a/src/o= penvpn/syshead.h
+++ b/src/openvpn/syshead.h
@@ -44,7 +44,7 @@
#define srandom srand
#endif

-#ifdef _MSC_VER /* Visual Studio */
+#if defined(_MSC_VER) && !defined(__clang__) /= * Microsoft compiler */
#define __func__ __FUNCTION__

#define __attribute__(x)
#endif

To view, visit change 1127. To unsubscribe, or for help = writing mail filters, visit = settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3046f4b09a4700001a1d9dcce80= 2990dfa701b52
Gerrit-Change-Number: 1127
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--VMih2Ci2c6I=--