Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52412C77B71 for ; Tue, 18 Apr 2023 08:19:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 304D710E6EC; Tue, 18 Apr 2023 08:19:57 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11ED010E6EC for ; Tue, 18 Apr 2023 08:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681805996; x=1713341996; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=BUDt7Leg5YNsBfAufyHE9J891sNBSaCcNnWZI81W9tU=; b=BmRcezWM7nZEI4Ii43e3fp9nQAbH9g+15nVWCMtyPITQmGbsqTgo91De NGKvA3ASfQq3/6qy824BetKkreE/kD1bJa9FKfqnWTD3E4ccTq65cuSsZ vsaEAKy+xJ6sndmXl3NKy0uQVac+DZSOhJvazOuDXRQeFDZlen7ir1BMH e7bUZz+kn5Jgaazv65EZQRMSAUuXdxJgyC4ulmmnQfBOa/Q4MfHi8Y6W3 pd1l+MaGQf+rGcrRGJaSHQennFU5KbAiX62ovzZazDyJ22CpjCtHDIIWP DKBkLxFjslNwwl2GhKXuL0tYssS7FhCHZSCCkDCLKHSyITrUY8x9hzqat Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="347858343" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="347858343" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 01:19:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10683"; a="641288458" X-IronPort-AV: E=Sophos;i="5.99,206,1677571200"; d="scan'208";a="641288458" Received: from dilipban-mobl.ger.corp.intel.com (HELO [10.213.234.43]) ([10.213.234.43]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 01:19:51 -0700 Message-ID: Date: Tue, 18 Apr 2023 09:19:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC 1/3] drm/doc: Relax fdinfo string constraints Content-Language: en-US To: Rob Clark , dri-devel@lists.freedesktop.org References: <20230417201215.448099-1-robdclark@gmail.com> <20230417201215.448099-2-robdclark@gmail.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20230417201215.448099-2-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Thomas Zimmermann , Jonathan Corbet , "open list:DOCUMENTATION" , open list Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 17/04/2023 21:12, Rob Clark wrote: > From: Rob Clark > > The restriction about no whitespace, etc, really only applies to the > usage of strings in keys. Values can contain anything (other than > newline). > > Signed-off-by: Rob Clark > --- > Documentation/gpu/drm-usage-stats.rst | 29 ++++++++++++++------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst > index 258bdcc8fb86..8e00d53231e0 100644 > --- a/Documentation/gpu/drm-usage-stats.rst > +++ b/Documentation/gpu/drm-usage-stats.rst > @@ -24,7 +24,7 @@ File format specification > - All keys shall be prefixed with `drm-`. > - Whitespace between the delimiter and first non-whitespace character shall be > ignored when parsing. > -- Neither keys or values are allowed to contain whitespace characters. > +- Keys are not allowed to contain whitespace characters. > - Numerical key value pairs can end with optional unit string. > - Data type of the value is fixed as defined in the specification. > > @@ -39,12 +39,13 @@ Data types > ---------- > > - - Unsigned integer without defining the maximum value. > -- - String excluding any above defined reserved characters or whitespace. > +- - String excluding any above defined reserved characters or whitespace. > +- - String. Makes sense I think. At least I can't remember that I had special reason to word it as strict as it was. Lets give it some time to marinade so for later: Acked-by: Tvrtko Ursulin Regards, Tvrtko > > Mandatory fully standardised keys > --------------------------------- > > -- drm-driver: > +- drm-driver: > > String shall contain the name this driver registered as via the respective > `struct drm_driver` data structure. > @@ -69,10 +70,10 @@ scope of each device, in which case `drm-pdev` shall be present as well. > Userspace should make sure to not double account any usage statistics by using > the above described criteria in order to associate data to individual clients. > > -- drm-engine-: ns > +- drm-engine-: ns > > GPUs usually contain multiple execution engines. Each shall be given a stable > -and unique name (str), with possible values documented in the driver specific > +and unique name (keystr), with possible values documented in the driver specific > documentation. > > Value shall be in specified time units which the respective GPU engine spent > @@ -84,16 +85,16 @@ larger value within a reasonable period. Upon observing a value lower than what > was previously read, userspace is expected to stay with that larger previous > value until a monotonic update is seen. > > -- drm-engine-capacity-: > +- drm-engine-capacity-: > > Engine identifier string must be the same as the one specified in the > -drm-engine- tag and shall contain a greater than zero number in case the > +drm-engine- tag and shall contain a greater than zero number in case the > exported engine corresponds to a group of identical hardware engines. > > In the absence of this tag parser shall assume capacity of one. Zero capacity > is not allowed. > > -- drm-memory-: [KiB|MiB] > +- drm-memory-: [KiB|MiB] > > Each possible memory type which can be used to store buffer objects by the > GPU in question shall be given a stable and unique name to be returned as the > @@ -126,10 +127,10 @@ The total size of buffers that are purgeable. > > The total size of buffers that are active on one or more rings. > > -- drm-cycles-: > +- drm-cycles-: > > Engine identifier string must be the same as the one specified in the > -drm-engine- tag and shall contain the number of busy cycles for the given > +drm-engine- tag and shall contain the number of busy cycles for the given > engine. > > Values are not required to be constantly monotonic if it makes the driver > @@ -138,12 +139,12 @@ larger value within a reasonable period. Upon observing a value lower than what > was previously read, userspace is expected to stay with that larger previous > value until a monotonic update is seen. > > -- drm-maxfreq-: [Hz|MHz|KHz] > +- drm-maxfreq-: [Hz|MHz|KHz] > > Engine identifier string must be the same as the one specified in the > -drm-engine- tag and shall contain the maximum frequency for the given > -engine. Taken together with drm-cycles-, this can be used to calculate > -percentage utilization of the engine, whereas drm-engine- only reflects > +drm-engine- tag and shall contain the maximum frequency for the given > +engine. Taken together with drm-cycles-, this can be used to calculate > +percentage utilization of the engine, whereas drm-engine- only reflects > time active without considering what frequency the engine is operating as a > percentage of it's maximum frequency. >