From: "flichtenheld (Code Review)" Date: Sat, 4 Apr 2026 16:43:22 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tulBrcf57w8="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Remove various unused structs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --tulBrcf57w8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1607?usp=3Demail to review the following change. Change subject: Remove various unused structs ...................................................................... Remove various unused structs Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Signed-off-by: Frank Lichtenheld --- M src/openvpn/mtcp.c M src/openvpn/multi_io.c M src/openvpn/networking_sitnl.c M src/openvpn/route.c 4 files changed, 0 insertions(+), 31 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/07/1607/1 diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c index b7bef46..2eab7b7 100644 --- a/src/openvpn/mtcp.c +++ b/src/openvpn/mtcp.c @@ -37,14 +37,6 @@ #include #endif -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - struct multi_instance * multi_create_instance_tcp(struct multi_context *m, struct link_socket *soc= k) { diff --git a/src/openvpn/multi_io.c b/src/openvpn/multi_io.c index f484fe2..e6f4e9c 100644 --- a/src/openvpn/multi_io.c +++ b/src/openvpn/multi_io.c @@ -46,14 +46,6 @@ #define MULTI_IO_FILE_CLOSE_WRITE ((void *)5) #define MULTI_IO_DCO ((void *)6) =20 -struct ta_iow_flags -{ - unsigned int flags; - unsigned int ret; - unsigned int tun; - unsigned int sock; -}; - #ifdef ENABLE_DEBUG static const char * pract(int action) diff --git a/src/openvpn/networking_sitnl.c b/src/openvpn/networking_sitnl.c index b88f03c..baf6f89 100644 --- a/src/openvpn/networking_sitnl.c +++ b/src/openvpn/networking_sitnl.c @@ -124,15 +124,6 @@ typedef int (*sitnl_parse_reply_cb)(struct nlmsghdr *msg, void *arg); /** - * Object returned by route request operation - */ -struct sitnl_route_data_cb -{ - unsigned int iface; - inet_address_t gw; -}; - -/** * Helper function used to easily add attributes to a rtnl message */ static int diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 1cfbf80..3b18f74 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3257,12 +3257,6 @@ * netlink(3), netlink(7), rtnetlink(7) * https://www.virtualbox.org/svn/vbox/trunk/src/VBox/NetworkServices/NAT/ */ -struct rtreq -{ - struct nlmsghdr nh; - struct rtmsg rtm; - char attrbuf[512]; -}; void get_default_gateway_ipv6(struct route_ipv6_gateway_info *rgi6, const struc= t in6_addr *dest, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1607?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288 Gerrit-Change-Number: 1607 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --tulBrcf57w8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

Remove various unused structs

Change= -Id: I46499ff1f40dbdb94b84d58d17457d0ccdd75288
Signed-off-by: Frank Lich= tenheld <frank@...2641...>
---
M src/openvpn/mtcp.c
M src/op= envpn/multi_io.c
M src/openvpn/networking_sitnl.c
M src/openvpn/route= .c
4 files changed, 0 insertions(+), 31 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/07/160=
7/1
diff --git a/src/openvpn/mtcp.c b/src/openvpn/mtcp.c
= index b7bef46..2eab7b7 100644
--- a/src/openvpn/mtcp.= c
+++ b/src/openvpn/mtcp.c
@@ -37,14 +37,6 = @@
#include <sys/inotify.h>
#endif<= /span>

-stru= ct ta_iow_flags
-{
- unsigned int flags;
- unsigned int ret;
- unsigned int tun;
- unsigned int sock;
-};
-
struct multi_instance *<= /span>
multi_create_instance_tcp(struct multi_context *m, struct = link_socket *sock)
{
diff --git a/src/open= vpn/multi_io.c b/src/openvpn/multi_io.c
index f484fe2..e6f4= e9c 100644
--- a/src/openvpn/multi_io.c
+++= b/src/openvpn/multi_io.c
@@ -46,14 +46,6 @@
#define MULTI_IO_FILE_CLOSE_WRITE ((void *)5)

#define M= ULTI_IO_DCO ((void *)6)

-struct ta_iow_flags
-{
- unsigned int flags;
- unsigned int ret;
- unsigned int tun;
- unsigned int sock;
-};
-
#ifdef ENABLE_DEBUG
static const char *
pract(int action)
diff --git a/src/openvpn/net= working_sitnl.c b/src/openvpn/networking_sitnl.c
index b88f= 03c..baf6f89 100644
--- a/src/openvpn/networking_sitnl.c
+++ b/src/openvpn/networking_sitnl.c
@@ -124,= 15 +124,6 @@
typedef int (*sitnl_parse_reply_cb)(struct nl= msghdr *msg, void *arg);

/**
<= span style=3D"color: hsl(0, 100%, 40%);">- * Object returned by route reque= st operation

- */
-struct sitnl_route_data_cb<= /span>
-{
- unsigned int iface;
- inet_address_t gw;
-};
-
-/**<= /span>
* Helper function used to easily add attributes to a rtnl= message
*/
static int
d= iff --git a/src/openvpn/route.c b/src/openvpn/route.c
index= 1cfbf80..3b18f74 100644
--- a/src/openvpn/route.c+++ b/src/openvpn/route.c
@@ -3257,12 +3257,6 @@
* netlink(3), netlink(7), rtnetlink(7)
* = https://www.virtualbox.org/svn/vbox/trunk/src/VBox/NetworkServices/NAT/
*/
-stru= ct rtreq
-{
<= span style=3D"color: hsl(0, 100%, 40%);">- struct nlmsghdr nh;
- struct rtmsg rtm;- char attrbuf[512];-};
void
get_default_gateway_ipv6(struct route_ipv6_ga= teway_info *rgi6, const struct in6_addr *dest,

<= /pre>

To view, visit change 1607. To unsubscribe, or for help writing mail fi= lters, visit set= tings.

=
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I46499ff1f40dbdb94b84d58d174= 57d0ccdd75288
Gerrit-Change-Number: 1607
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --tulBrcf57w8=--