From: "its_Giaan (Code Review)"
Date: Tue, 20 Feb 2024 13:58:11 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="RMlqdtVYUDU="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support
for user defined routing table
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--RMlqdtVYUDU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/524?usp=3Demail )
Change subject: Route: add support for user defined routing table
......................................................................
Patch Set 2:
(5 comments)
File doc/man-sections/vpn-network-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/524/comment/8ef327d5_482e958e :
PS1, Line 407: default taken from ``--route-table`` if set, otherwise :cod=
e:`0`.
> Please change tab to spaces
Done
http://gerrit.openvpn.net/c/openvpn/+/524/comment/9c8be01e_92c07a0f :
PS1, Line 408:
> Should document that table-id can't be pushed.
Done
http://gerrit.openvpn.net/c/openvpn/+/524/comment/2891fff7_f030a0a0 :
PS1, Line 464:
> might be a good opportunity to make the description of --route-ipv6 more =
consistent with --route? Cu [=E2=80=A6]
Done
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/524/comment/0ca031f1_18cfb87a :
PS1, Line 205: "--route-table [table_id] : Specify a custom routing tab=
le for use with --route(-ipv6).\n"
> table_id is not optional, so don't use brackets here
Done
http://gerrit.openvpn.net/c/openvpn/+/524/comment/e912ffc8_22f4e21d :
PS1, Line 6992: msg(M_WARN, "NOTE: --route-table specified, but not=
supported on this platform");
> Sounds good to me.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: its_Giaan
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--RMlqdtVYUDU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View C=
hange
5 comments:
=
Patch Set #1, Line 464:
might be a good opportunity to make the descri=
ption of --route-ipv6 more consistent with --route? Cu [=E2=80=A6]Done
=
File src/openvpn/opt=
ions.c:
Patch Set #=
1, Line 205: "=
--route-table [table_id] : Specify a custom routing table for use with --ro=
ute(-ipv6).\n"
table_id is not optional, so don&=
#39;t use brackets here
Done
Patch Set #1, Line 6992: =
msg(M_WARN, "N=
OTE: --route-table specified, but not supported on this platform");
Sounds good to me.
Done
To vi=
ew, visit change 524. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56=
17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Tue, 20 Feb 2024 13:58:11=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: its_Giaan <gianmarco@...220...=
..2726...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--RMlqdtVYUDU=--