Message-ID: Date: Tue, 15 Mar 2022 16:11:25 +0100 MIME-Version: 1.0 Content-Language: en-US References: <20220313193154.9350-1-openvpn@...2080...> <20220313193154.9350-3-openvpn@...2080...> From: Antonio Quartulli In-Reply-To: <20220313193154.9350-3-openvpn@...2080...> Subject: Re: [Openvpn-devel] [PATCH v4 2/3] plug-ins: Disallow multiple deferred authentication plug-ins List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: David Sommerseth , openvpn-devel@lists.sourceforge.net Hi, On 13/03/2022 20:31, David Sommerseth wrote: > From: David Sommerseth > > The plug-in API in OpenVPN 2.x is not designed for running multiple > deferred authentication processes in parallel. The authentication > results of such configurations are not to be trusted. For now we bail > out when this discovered with an error in the log. > > CVE: 2022-0547 > Signed-off-by: David Sommerseth Same as the patch for master. Acked-by: Antonio Quartulli > + error = true; > + msg(M_FATAL, > + "Exiting due to multiple authentication plug-ins " > + "performing deferred authentication. Only one " > + "authentication plug-in doing deferred auth is " > + "allowed. Ignoring the result and stopping now, " > + "the current authentication result is not to be " > + "trusted."); Frank reported that we should use double space after the full-stop. Honestly I'd prefer just single-space everywhere as it is more "traditional". This said, Gert can make the final decision and modify the patch on the fly. Cheers, -- Antonio Quartulli