From: "flichtenheld (Code Review)" Date: Thu, 28 Nov 2024 09:52:42 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Ktip7hOXw6E="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: stipa , plaisthos , openvpn-devel --Ktip7hOXw6E= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/808/comment/cd014878_336b1231 : PS4, Line 817: src/openvpn/platform.c buffer.c and platform.c are always added by foreach loop above. So they are= redundant here. File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/808/comment/654dd17f_91aed2e0 : PS4, Line 791: #define PUF_TYPE_UNDEF 0 /** undefined filter type */ You didn't resolve the conflict correctly when rebasing. Please copy the ne= w code here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 4 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: mrbff Gerrit-Comment-Date: Thu, 28 Nov 2024 09:52:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Ktip7hOXw6E= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mrbff, plaisthos.

Patch set 4:Code-Review -1=

Vi= ew Change

2 comments:

  • File CMakeLists.txt:

    • Patch Set #4, Line 817: <= code style=3D"font-family:monospace,monospace"> src/openvpn/platform.c<= /code>

      buffer= .c and platform.c are always added by foreach loop above. So they are redun= dant here.

  • File s= rc/openvpn/options.h:

    • Patch Set #4, Line 791: #define PUF_TYPE_UNDEF 0 /** undefined filter type */

      You didn't reso= lve the conflict correctly when rebasing. Please copy the new code here.

To view, visit change 808. To unsubscribe, or for help w= riting mail filters, visit s= ettings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 4
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Thu, 28 Nov 2024 09:52:42= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--Ktip7hOXw6E=--