Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5807C47082 for ; Wed, 26 May 2021 21:50:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8ACA613C5 for ; Wed, 26 May 2021 21:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234181AbhEZVvf (ORCPT ); Wed, 26 May 2021 17:51:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21309 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233790AbhEZVvf (ORCPT ); Wed, 26 May 2021 17:51:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622065803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s2jDM/TpmfLpzDZ7Dd8kJfaXr/uLu6JzfCGH8PAhY6A=; b=f1DJ2axgBoIulDfVYjmYedXEoJuVCl0QzYGDGYYrOes44/lV8ePZCR6jaS9XfSy2ZI6gNY h9q7f/cEJWGIraVtz5EiUIJK35rcIhWb9ER7x3HfVLd8zjSOMcRuQyzN2J078J1bzmqM80 Rr2Cuo9D/iBnZ4u7hhxjPAS92ltHFIk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-PZVAsyq2NdCLMl4UXya-wQ-1; Wed, 26 May 2021 17:50:02 -0400 X-MC-Unique: PZVAsyq2NdCLMl4UXya-wQ-1 Received: by mail-wm1-f69.google.com with SMTP id y205-20020a1ce1d60000b029019278214067so772567wmg.3 for ; Wed, 26 May 2021 14:50:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s2jDM/TpmfLpzDZ7Dd8kJfaXr/uLu6JzfCGH8PAhY6A=; b=smX87QvDJw8WIf4txANojM05M+NiaqfiTBeEvRVqIM4dz4s5ue+QAkwDzI1BvFwp3v kOlF2NhPCqCxf2X93AxYXIYxKQY2swjzQrG24dPMaMIfWPd1xCGKZu2m34FkMH2ELlgm QGfUAOLYZHmR2cXoE96/dmKEhfA8sw6YfwAZtKhnic1a6g+sPSQNc3zpIncdWUZ2b6ZY Bm9YrnFm+M+/S/9hd2BrmxU+Ub5RcFGWp4boKgqPQv0H05bNRtgxVLaDTbcYa72kJt+L Cmxpg3GMuRf1rrzLnQgBm1rBKncAp36bh215FMIrgbHVKf1NH5QigGubM2IncLJijYX0 Vdgw== X-Gm-Message-State: AOAM530EHFEPFCiq6q64XhxY5pldjq21byli3JDozS70qXiJs1j/Au71 xnRHN01GzwiQUpShnKpF3tJS6sr8MpW958cItJNYLjVOZ5QNohgJBt0B8SpVwy1W+GpzggYWaVW Pen9sJj1YUzV08CYC8QM0mV7cyPSG8+X2ucF532NLp66+UlZJBhUaELFKBqC9vL93dw0hwyxgvo 0= X-Received: by 2002:a05:6000:118c:: with SMTP id g12mr85977wrx.320.1622065800515; Wed, 26 May 2021 14:50:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX3XLrans83aVeEW49CvKbVeLkqlNa3AgNJRBQ+d+nHfyxrTBw4pmjGbjCUesYgRVfH6dHEg== X-Received: by 2002:a05:6000:118c:: with SMTP id g12mr85963wrx.320.1622065800347; Wed, 26 May 2021 14:50:00 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id f14sm235371wry.40.2021.05.26.14.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 14:49:59 -0700 (PDT) Subject: Re: [PATCH] kbuild: quote OBJCOPY var to avoid a pahole call break the build To: Andrii Nakryiko , Masahiro Yamada Cc: open list , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Marek , Linux Kbuild mailing list References: <20210518142302.1046718-1-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: Date: Wed, 26 May 2021 23:49:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On 5/26/21 11:02 PM, Andrii Nakryiko wrote: [snip] >> >> BTW, I see similar code in scripts/link-vmlinux.sh too. >> >> LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${extra_paholeopt} ${1} >> >> Is it OK to leave it unquoted? > > You are right, link-vmlinux.sh should be updated accordingly. > Good catch. I'll include this in v2 as well. > Javier, can you please send v2 and cc bpf@vger.kernel.org? Thanks! > Sure, thanks! Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering