From: "cron2 (Code Review)" Date: Mon, 4 Aug 2025 15:18:30 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., antonio@...2726... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="s5YnN9kYKNE="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --s5YnN9kYKNE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/791?usp=3Demail ) Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 23: Code-Review+2 (3 comments) Patchset: PS23: So, reviewed most of this, and especially tested this on all the testbeds (= nothing fails). As agreed, move to "ColumnLimit: 0" afterwards with a clea= nup patch, as the force-unwrapping by "100" creates ugliness and also "surp= rising submit fails" - we use common sense ;-) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/9105cd07_6cc952af : PS18, Line 391: epoch); not sure what happened here... http://gerrit.openvpn.net/c/openvpn/+/791/comment/ce26f764_3092ba12 : PS18, Line 1604: msg(M_FATAL, this is another one where the result is uglier than the start... maybe it n= eeds manual breaking of the string so it can fit "properly" in 2 lines -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 23 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Mon, 04 Aug 2025 15:18:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --s5YnN9kYKNE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

Patch set 23:Code-Review +2

V= iew Change

3 comments:

  • Patchset:

    • Patch Set #23:

      So, reviewed most of this, and especially t= ested this on all the testbeds (nothing fails). As agreed, move to "C= olumnLimit: 0" afterwards with a cleanup patch, as the force-unwrappin= g by "100" creates ugliness and also "surprising submit fail= s" - we use common sense ;-)

  • File src/openvpn/crypto.c:

    • Patch Set #18, Line 391: epoch);

      not sure what happened here...

      =
    • Patch Set #18, Line 1604: msg(M_FATAL,

      this is another one where the result is ugl= ier than the start... maybe it needs manual breaking of the string so it ca= n fit "properly" in 2 lines

To view, vi= sit chang= e 791. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b= 8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 23
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Mon, 04 Aug 2025 15:18:30= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--s5YnN9kYKNE=--