Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.96 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795043632; b=yr0MD4RwMH8El4eCQ/BQPsqrzyhIQ6L72wA+lH0roMK3ckh+0ri0hqYBjRasYF0Hr3R1 whNp2uLTbhNasDYts4e0OXBB32QAS2cAIgtIkgLTXngWhLFN0WyYF3IJA1BR1G4WSKWEI RKMsLU6xreLS7ZfGmIqQCjWVF1v2WowPEaLsFOHogj/wJWXvBbckZ01Ua6AAyA1gjlerH EkAhToxRxbMoFw3hiswmZ9VBJ3ZHhZqLGbJ7aHtNRiOsgELGBxf1oqx+tAMkfS74L5tbr HqdLg/zfVqkT/gbxCVVrKv0qxvT2yhoT/r5xGK4Npm4CssGYYFm9dA+Tr/nhx088rdw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795043632; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=ffLc8M6kgUXDxTvAEIl4EfnyU6vkbLzw92jR7anCh+k=; b=fBwfjRmEEm0Y+AspYGJXDdKQG8KqgkpbGu8VN6k9lZUPVh65l0eq0tzuxnzRPW0VzVHl Vj512S7B+CwQjZdCCcxRfW5nxEZOoSoaJeiVci3rHJQhAt4E9xJa9aEK11nV/pxoTn0bd ZBP0b8Gmlcb0mG7ak6uDBGNFvA3nrAcxRhwxg+mtHYcEYbfF1Z/jNDjVAtqYm9m6CFA3T QopbmDXN7hCPBwwXpXCAZkacfdBaJxxDso8yg7K8AGwsHLYI+hkX5RK1XSdnhwCPUWmwr wE1ZNh2nX6RbUiq3dvW0Gh8ZDhAQrT1TiaAZjPQmPVMhsd5tIADMxQFQQTTrBvxQ7jg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pkNX7Yzw; arc=none smtp.remote-ip=95.215.58.96 Received: from mta1.migadu.com (out-96.mta1.migadu.com [95.215.58.96]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B75606A331 for ; Wed, 18 Nov 2026 23:13:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B3B75606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pkNX7Yzw X-Envelope-To: bpf@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=tQf2RroZFgidYhH8VlIC9DnLVfLCV5SLUf0kaG6u5o8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795043629; v=1; x=1795648429; b=pkNX7YzwK+FuVIyZfuh5RjJtDnRvtBq+7ZddG4QVLwCF9uT8BupvhW/uLdI4cBZwoGEcRDBM vIq5v4fDzsNHFN+ygqXlBv5iKS7uBPpK1NKr+sPVsRE4k80UtSn5QtCWgwJWngejOO4iRwiOgIw Iid1i5Gt9taTIgFrkozNOEMc= X-Envelope-To: bpf@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id db2b73d50699373c; Wed, 18 Nov 2026 23:13:49 +0000 X-Mizu-Trace-ID: db2b73d50699373c X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 18 Nov 2026 16:13:44 -0700 X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors To: Eduard Zingerman , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Kumar Kartikeya Dwivedi Cc: Alan Maguire , Emil Tsalapatis , Jiri Olsa , Song Liu , Tejun Heo , Yonghong Song , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev References: <20261117192153.3384031-1-ihor.solodrai@linux.dev> <6a1b6f05-448e-461c-bd79-0acd67fb7edc@linux.dev> Content-Language: en-US From: Ihor Solodrai In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-11-18 3:11 p.m., Eduard Zingerman wrote: > On Wed, 2026-11-18 at 14:37 -0700, Ihor Solodrai wrote: >> On 2026-11-18 2:12 p.m., Eduard Zingerman wrote: >>> On Tue, 2026-11-17 at 12:21 -0700, Ihor Solodrai wrote: >>>> An incompatible change to a kfunc's prototype, such as an added >>>> parameter, breaks BPF programs built against the old one. libbpf >>>> ignores the ___ suffix of a kfunc declared in a BPF program, >>>> but makes an exact name look up on the kernel side, so the kernel >>>> can't keep the old prototype available under the kfunc's name. >>>> >>>> sched_ext ran into this. cded46d97159 ("sched_ext: Make >>>> scx_bpf_dsq_insert*() return bool") kept the old prototype as >>>> scx_bpf_dsq_insert___compat, expecting libbpf to bind old binaries to >>>> it, and broke them. 2dbbdeda77a6 ("sched_ext: Fix scx_bpf_dsq_insert() >>>> backward binary compatibility") reversed the naming. A ___v2 kfunc >>>> declared as vmlinux.h spells it doesn't bind: 56bbc91219c0 >>>> ("sched_ext: Fix scx_bpf_dsq_move_to_local___v2 compat detection") >>>> fixed a compat macro that silently dropped enq_flags because of this. >>> >>> Please prefer examples to prose in cover letters. >> >> The sched_ext story above narrates the commit history to illustrate >> the motivation for the feature.  Would you like to see code samples >> from there, or are you suggesting to drop the paragraph? >> >> The documentation patch includes code examples of the new binding >> rules, I didn't want to duplicate that in the cover. > > There are two ways to act while reading the above paragraph: > - follow the referenced commits and reconstruct the issue (time consuming). > - ignore it (not helpful). sigh... There are more: - Read the paragraph to understand the issue on the high level, without loading the entirety of the details into your head. Example interpretation: - sched-ext had a problem with scx_bpf_dsq_insert() changing the return type, which led to reverts and inconvenient hacks - Give the paragraph to your helpful assistant and ask it exact questions that interest you. Since the paragraph has commit hashes, it's trivial for ai to navigate this. And other approaches in between. It all depends on how deeply do you want/need to understand the specific thing. > >>> Also, please de-Claude the included prose. >> >> Please be more specific. Which "included prose"? > > sched_ext ran into this. cded46d97159 ... kept the old prototype as > scx_bpf_dsq_insert___compat, expecting libbpf to bind old binaries to > it, and broke them. 2dbbdeda77a6 ... reversed the naming. A ___v2 > kfunc declared as vmlinux.h spells it doesn't bind: 56bbc91219c0 ... > fixed a compat macro that silently dropped enq_flags because of this. > > This screams Claude from 1000 miles distance. Sure. So what? Have you read the bpf list lately? (I also use Codex and Muse btw, not only Claude) AI-generated prose is not a bad thing by itself. It can be no less useful than human-written prose. Yes there is a wide spectrum of slopiness, and submitters need to know what they are posting. Personally, I try to be careful about commit messages and cover letters. I iterate on them multiple times with AI, then I read them and edit by hand. If I posted the first generated thing it would look much worse. Look around on the list. Do you think this paragraph is the worst slop cover letter compared to things that have been landed already? I'm a little annoyed by your comment, because the slop filter you are applying now is not applied uniformly on the list. It's not fair. I would write the cover entirely by hand if that was a strict rule here, because I respect the rules. But it's not. > Maybe I have reading comprehension issues, but in order to decipher it > one has to: > - "kept old prototype" - figure out that two functions were declared > "scx_bpf_dsq_insert" and "scx_bpf_dsq_insert___compat" > - "bind old binaries to it and broke them" - figure out that existing > bpf programs referred to "scx_bpf_dsq_insert" and libbpf mechanics > didn't work as expected. > - "reversed the naming" - like a new function became ___compat or what > happened? > - "A ___v2 kfunc declared as vmlinux.h spells it ..." > Now there is a ___v2 in the picture. > - "... doesn't bind" - figure out that this refers to libbpf mechanics. > - "fixed a compat macro that silently dropped enq_flags because of this." > Incomprehensible w/o looking in the code. Your reading is a valid approach to understand the history in more details, and you are correct that the paragraph does not provide them. However IMO those details are unnecessary in the cover, but pointers are useful. Which is why I left this ai-generated paragraph be. It's a minor issue, however. I'm happy to drop the paragraph, I just disagree that "it screams Claude" is a valid reason. > >>> >>>> [...]