Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jABIu-0007C2-OT for mharc-grub-devel@gnu.org; Fri, 06 Mar 2020 06:38:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34760) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jABIr-00079A-Td for grub-devel@gnu.org; Fri, 06 Mar 2020 06:38:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jABIq-0004BF-M7 for grub-devel@gnu.org; Fri, 06 Mar 2020 06:38:05 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:38961 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jABIq-00047g-IQ for grub-devel@gnu.org; Fri, 06 Mar 2020 06:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583494683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tpLVhjrH7JofekcALsQ/g/HXwW6ME+y3P7R1bhbRxWc=; b=C0GDAkBvCBZ5VrJJiALuABO5kt9hiIP4/7kagvD4MQhNZWa8s/N5kihlyoT8oaJXPIrXwc LUM/VkY2evi4fRvq7BSXkI39LLwAc7e9yoX1pvmbkBE9qBI/34Vj+RIsn7hTkeDrvFjmTH X99lx4GYTKpYIePHYkIq/Wp/tfKYbrM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-pqTzrqY_PeSXlG8as1s78g-1; Fri, 06 Mar 2020 06:38:00 -0500 X-MC-Unique: pqTzrqY_PeSXlG8as1s78g-1 Received: by mail-wm1-f70.google.com with SMTP id c18so786922wml.0 for ; Fri, 06 Mar 2020 03:38:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qY5dw7lxvjI17mIgogaMToQJQdiFAXioM3n7D7M7VJc=; b=YQsNE5S0dp2PtDltGoBKe3ptdy/6Moog+jPCZJF8HkjcUTGwv3U8rppz7tO3YY2sNS yXqAY83MG0vURVF3/n3CdgwCLZoLjY0wv+io6T3W02qhHmw747awtlu3INMaoEWrImT4 HGxFWP1dn5yc5+DPWyk5a3g22GheUnxeFlz81qZye/XvmPJfRilKagAhY0n9hjuMkFzB xiXBxnUS8a3Z4H2whWdCEUCB5G5rHMhysrjgPAK2wREzqCuhONpLlvisC+lIK/NpEG6y xzKwjn1hr3skwEkJ3ge26yMNmVEgLQj0hb9RDHgOCxvmn+k/TLHkjxW9Pxnz+Jyz9LGG Xtqg== X-Gm-Message-State: ANhLgQ0DJ0l/qPTZIaSX0aWg+U6sGyaIUke5wIH2IyGmtFPXwqPQPuR+ lwv86SwpXuYQm7Y9JV94sJBdizSbphrY62l8VnpidH19Gg+3EjwgKdBvdpG/mqXV1rP14hRBaHQ ahvoayPPJ+L4= X-Received: by 2002:a5d:68ce:: with SMTP id p14mr3559602wrw.315.1583494679729; Fri, 06 Mar 2020 03:37:59 -0800 (PST) X-Google-Smtp-Source: ADFU+vtPdqn7AFzeerC2j7NBiAsaBXK4LmF4MA9R/hScD0DDMYkxsST8avYzQ1DEQqstQreqLoHebw== X-Received: by 2002:a5d:68ce:: with SMTP id p14mr3559587wrw.315.1583494679530; Fri, 06 Mar 2020 03:37:59 -0800 (PST) Received: from [10.201.33.17] ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id s7sm10056145wrm.13.2020.03.06.03.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2020 03:37:58 -0800 (PST) Subject: Re: [PATCH v2 08/12] kern: Make grub_error() more verbose To: The development of GNU GRUB , Vladimir 'phcoder' Serbinenko References: <20200304115851.3474263-1-javierm@redhat.com> <20200304115851.3474263-9-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: Date: Fri, 6 Mar 2020 12:37:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2020 11:38:07 -0000 Hello Vladimir, Thanks a lot for your feedback. On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size >=20 > Le mer. 4 mars 2020 =C3=A0 13:01, Javier Martinez Canillas > a =C3=A9crit : >=20 For a x86_64-pc build with platform=3Dpc on master with and without the pat= ch: $ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$ 2740 total $ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$ 2756 total so in this case the increase is a 0.6% in size. And doing the same in a x86_64 with platform=3Defi build: $ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$ 4296 total $ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$ 4356 total The size increase it's a little bigger but just a 1.4%. You are right that there's a size increase but I wouldn't call it huge and I think that's a good trade off for the convenience of having that info. Best regards, --=20 Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat