Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 513E4C433EF for ; Mon, 7 Mar 2022 11:41:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0162283C32; Mon, 7 Mar 2022 12:41:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="Ds/lm4aV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C757E81DCA; Mon, 7 Mar 2022 12:41:49 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C24E783BE5 for ; Mon, 7 Mar 2022 12:41:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 0FF642223A; Mon, 7 Mar 2022 12:41:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1646653305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0UQDCM6jpFf22NaJkOa2nIHr9h51IpVNdrYTiHXI+c=; b=Ds/lm4aVI15NCGrCWehMN7INZg543XQZi1b+hdX/RT3oqcszsyhNemQSuNxYTRGTF5eCf8 A466PXeKSvj9mAvy8Le62ULyEk0X2wHT55ZXOXx72paiBBr+bEv7frfGiZFVbcJa98AWLQ c2+Jrgl78E0ChSGcto0c1RNWjHxDO/k= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Mar 2022 12:41:44 +0100 From: Michael Walle To: Gaurav Jain Cc: sbabic@denx.de, Varun Sethi , Adrian Alonso , Alison Wang , Andy Tang , festevam@gmail.com, Franck Lenormand , Horia Geanta , Ji Luo , marex@denx.de, Meenakshi Aggarwal , Mingkai Hu , olteanv@gmail.com, Pankaj Gupta , Peng Fan , Pramod Kumar , Priyanka Jain , Rajesh Bhagat , Sahil Malhotra , Shengzhou Liu , Silvano Di Ninno , sjg@chromium.org, u-boot@lists.denx.de, dl-uboot-imx , Wasim Khan , Ye Li Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model In-Reply-To: References: <6a620def-8189-cf26-de81-2d2fa9c6f0f1@denx.de> <20220307095819.3480138-1-michael@walle.cc> <71356e5efd2f0abe0bf98712ec1a14ba@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 2022-03-07 12:33, schrieb Gaurav Jain: >> -----Original Message----- >> From: Michael Walle >> Sent: Monday, March 7, 2022 4:39 PM >> To: Gaurav Jain >> Cc: sbabic@denx.de; Varun Sethi ; Adrian Alonso >> ; Alison Wang ; Andy Tang >> ; festevam@gmail.com; Franck Lenormand >> ; Horia Geanta ; Ji >> Luo >> ; marex@denx.de; Meenakshi Aggarwal >> ; Mingkai Hu ; >> olteanv@gmail.com; Pankaj Gupta ; Peng Fan >> ; Pramod Kumar ; Priyanka >> Jain ; Rajesh Bhagat ; >> Sahil >> Malhotra ; Shengzhou Liu >> ; >> Silvano Di Ninno ; sjg@chromium.org; u- >> boot@lists.denx.de; dl-uboot-imx ; Wasim Khan >> ; Ye Li >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for >> CAAM Job >> ring driver model >> >> Caution: EXT Email >> >> Am 2022-03-07 11:56, schrieb Gaurav Jain: >> >> -----Original Message----- >> >> From: Michael Walle >> >> Sent: Monday, March 7, 2022 3:28 PM >> >> To: sbabic@denx.de >> >> Cc: Varun Sethi ; Adrian Alonso >> >> ; Alison Wang ; Andy >> Tang >> >> ; festevam@gmail.com; Franck Lenormand >> >> ; Gaurav Jain ; Horia >> >> Geanta ; Ji Luo ; >> >> marex@denx.de; Meenakshi Aggarwal ; >> >> Mingkai Hu ; olteanv@gmail.com; Pankaj Gupta >> >> ; Peng Fan ; Pramod Kumar >> >> ; Priyanka Jain ; >> >> Rajesh Bhagat ; Sahil Malhotra >> >> ; Shengzhou Liu ; >> >> Silvano Di Ninno ; sjg@chromium.org; u- >> >> boot@lists.denx.de; dl-uboot-imx ; Wasim Khan >> >> ; Ye Li ; Michael Walle >> >> >> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for >> >> CAAM Job ring driver model >> >> >> >> Caution: EXT Email >> >> >> >> > On 03.03.22 14:41, Gaurav Jain wrote: >> >> >> As we have not received any response from imx6dl_mamoj board >> maintainer. >> >> >> I propose the below solution >> >> >> >> >> >> --- a/arch/arm/mach-imx/Kconfig >> >> >> +++ b/arch/arm/mach-imx/Kconfig >> >> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN config IMX_HAB >> >> >> - select FSL_CAAM if HAS_CAAM >> >> >> - imply CMD_DEKBLOB if HAS_CAAM >> >> >> + imply FSL_CAAM if HAS_CAAM >> >> >> + imply CMD_DEKBLOB if FSL_CAAM >> >> >> Help >> >> >> >> >> > >> >> > IMO this is ok, I was also wrong, Marek is not the maintainer of >> >> > this board. This was the only board with broken build - let's say, >> >> > I will still wait a couple of days, and if there is no comments, I >> >> > will apply your series (but then V10). I can apply this fix myself, >> >> > no need to post the series again (I have not seen any other comment >> >> > or request to >> >> change). >> >> >> >> I don't understand why the solution isn't the same one as for the >> >> layerscape part in this series[1]: enable the config per board (that >> >> is your boards) and leave all others the same as before? >> > >> > imx6dl_mamoj caam driver is not enabled by any of my changes. >> > This board is enabling IMX_HAB which select FSL_CAAM. >> > Proposed changes making it imply so that FSL_CAAM can be disabled in >> > board defconfig. >> >> Ahh it was already selected before. But mhh, does IMX_HAB even makes >> sense >> without FSL_CAAM? Why was is a hard dependency before? > > With imply, this will still enable FSL_CAAM unless it is explicitly > disabled in defconfig. With select I do not have choice of disabling > FSL_CAAM in defconfig. Now I have disabled FSL_CAAM only for > imx6dl_mamoj_defconfig, as it is reporting spl size issues with caam > driver model approach. I can see *what* you are doing, but that doesn't answer *why* it was a hard dependency before and why now of a sudden can be a soft dependency. -michael