From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Consolidate checks for engine stats availability Date: Fri, 24 Nov 2017 10:08:07 +0000 Message-ID: References: <20171122120518.11561-1-tvrtko.ursulin@linux.intel.com> <151135424158.9619.15331899828809996656@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A8126E8F2 for ; Fri, 24 Nov 2017 10:08:10 +0000 (UTC) In-Reply-To: <151135424158.9619.15331899828809996656@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzExLzIwMTcgMTI6MzcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE3LTExLTIyIDEyOjA1OjE4KQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBTYWdhciBub3RpY2VkIHRoZSBjaGVjayBj YW4gYmUgY29uc29saWRhdGVkIGJldHdlZW4gdGhlIGVuZ2luZSBzdGF0cwo+PiBpbXBsZW1lbnRh dGlvbiBhbmQgdGhlIFBNVS4KPj4KPj4gTXkgZmlyc3QgY2hvaWNlIHdhcyBhIHN0YXRpYyBpbmxp bmUgaGVscGVyIGJ1dCB0aGF0IGdvdCBpbnRvIGluY2x1ZGUKPj4gb3JkZXJpbmcgbWVzcyBxdWlj a2x5IGZhc3Qgc28gSSB3ZW50IHdpdGggYSBtYWNybyBpbnN0ZWFkLiBBdCBzb21lIHBvaW50Cj4+ IHdlIHNob3VsZCBwZXJoYXBzIGxvb2tpbmcgaW50byB0YWtpbmcgb3V0IHRoZSBub24tcmluZ3Vi ZmZlciBiaXRzIGZyb20KPj4gaW50ZWxfcmluZ2J1ZmZlci5oIGludG8gYSBuZXcgaW50ZWxfZW5n aW5lLmggb3Igc29tZXRoaW5nLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBTdWdnZXN0ZWQtYnk6IFNhZ2FyIEFydW4gS2Ft YmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4+IENjOiBTYWdhciBBcnVuIEthbWJsZSA8 c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3BtdS5jICAgICAgICAgfCA5ICsrLS0tLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2VuZ2luZV9jcy5jICB8IDQgKystLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuaCB8IDIgKysKPj4gICAzIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcG11LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+IGlu ZGV4IDEwNzE5MzViZmE2Ny4uMTEyMjQzNzIwZmYzIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cG11LmMKPj4gQEAgLTkwLDExICs5MCw2IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgZXZlbnRfZW5h YmxlZF9iaXQoc3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50KQo+PiAgICAgICAgICByZXR1cm4gY29u ZmlnX2VuYWJsZWRfYml0KGV2ZW50LT5hdHRyLmNvbmZpZyk7Cj4+ICAgfQo+PiAgIAo+PiAtc3Rh dGljIGJvb2wgc3VwcG9ydHNfYnVzeV9zdGF0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkx NSkKPj4gLXsKPj4gLSAgICAgICByZXR1cm4gSU5URUxfR0VOKGk5MTUpID49IDg7Cj4+IC19Cj4+ IC0KPj4gICBzdGF0aWMgYm9vbCBwbXVfbmVlZHNfdGltZXIoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUsIGJvb2wgZ3B1X2FjdGl2ZSkKPj4gICB7Cj4+ICAgICAgICAgIHU2NCBlbmFibGU7 Cj4+IEBAIC0xMjQsNyArMTE5LDcgQEAgc3RhdGljIGJvb2wgcG11X25lZWRzX3RpbWVyKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICppOTE1LCBib29sIGdwdV9hY3RpdmUpCj4+ICAgICAgICAgICAq IEFsc28gdGhlcmUgaXMgc29mdHdhcmUgYnVzeW5lc3MgdHJhY2tpbmcgYXZhaWxhYmxlIHdlIGRv IG5vdAo+PiAgICAgICAgICAgKiBuZWVkIHRoZSB0aW1lciBmb3IgSTkxNV9TQU1QTEVfQlVTWSBj b3VudGVyLgo+PiAgICAgICAgICAgKi8KPj4gLSAgICAgICBlbHNlIGlmIChzdXBwb3J0c19idXN5 X3N0YXRzKGk5MTUpKQo+PiArICAgICAgIGVsc2UgaWYgKGludGVsX3N1cHBvcnRzX2VuZ2luZV9z dGF0cyhpOTE1KSkKPj4gICAgICAgICAgICAgICAgICBlbmFibGUgJj0gfkJJVChJOTE1X1NBTVBM RV9CVVNZKTsKPj4gICAKPj4gICAgICAgICAgLyoKPj4gQEAgLTQ2Myw3ICs0NTgsNyBAQCBzdGF0 aWMgdm9pZCBpOTE1X3BtdV9ldmVudF9yZWFkKHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkKPj4g ICAKPj4gICBzdGF0aWMgYm9vbCBlbmdpbmVfbmVlZHNfYnVzeV9zdGF0cyhzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICplbmdpbmUpCj4+ICAgewo+PiAtICAgICAgIHJldHVybiBzdXBwb3J0c19idXN5 X3N0YXRzKGVuZ2luZS0+aTkxNSkgJiYKPj4gKyAgICAgICByZXR1cm4gaW50ZWxfc3VwcG9ydHNf ZW5naW5lX3N0YXRzKGVuZ2luZS0+aTkxNSkgJiYKPj4gICAgICAgICAgICAgICAgIChlbmdpbmUt PnBtdS5lbmFibGUgJiBCSVQoSTkxNV9TQU1QTEVfQlVTWSkpOwo+PiAgIH0KPj4gICAKPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPj4gaW5kZXggZmVkZTYyZGFmM2UxLi5k NTM2ODBjMDhjYjAgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Vu Z2luZV9jcy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j Cj4+IEBAIC0xODYzLDcgKzE4NjMsNyBAQCBpbnQgaW50ZWxfZW5hYmxlX2VuZ2luZV9zdGF0cyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgewo+PiAgICAgICAgICB1bnNpZ25l ZCBsb25nIGZsYWdzOwo+PiAgIAo+PiAtICAgICAgIGlmIChJTlRFTF9HRU4oZW5naW5lLT5pOTE1 KSA8IDgpCj4+ICsgICAgICAgaWYgKCFpbnRlbF9zdXBwb3J0c19lbmdpbmVfc3RhdHMoZW5naW5l LT5pOTE1KSkKPj4gICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT0RFVjsKPj4gICAKPj4gICAg ICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2luZS0+c3RhdHMubG9jaywgZmxhZ3MpOwo+PiBA QCAtMTkyNCw3ICsxOTI0LDcgQEAgdm9pZCBpbnRlbF9kaXNhYmxlX2VuZ2luZV9zdGF0cyhzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgewo+PiAgICAgICAgICB1bnNpZ25lZCBs b25nIGZsYWdzOwo+PiAgIAo+PiAtICAgICAgIGlmIChJTlRFTF9HRU4oZW5naW5lLT5pOTE1KSA8 IDgpCj4+ICsgICAgICAgaWYgKCFpbnRlbF9zdXBwb3J0c19lbmdpbmVfc3RhdHMoZW5naW5lLT5p OTE1KSkKPj4gICAgICAgICAgICAgICAgICByZXR1cm47Cj4+ICAgCj4+ICAgICAgICAgIHNwaW5f bG9ja19pcnFzYXZlKCZlbmdpbmUtPnN0YXRzLmxvY2ssIGZsYWdzKTsKPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+PiBpbmRleCAzYmQzMGQwMTE4NjYuLjM3YTM4OWZm MDMxZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+PiBA QCAtMTA1NCw2ICsxMDU0LDggQEAgc3RhdGljIGlubGluZSB2b2lkIGludGVsX2VuZ2luZV9jb250 ZXh0X291dChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICAgICAgICAgIHNwaW5f dW5sb2NrX2lycXJlc3RvcmUoJmVuZ2luZS0+c3RhdHMubG9jaywgZmxhZ3MpOwo+PiAgIH0KPj4g ICAKPj4gKyNkZWZpbmUgaW50ZWxfc3VwcG9ydHNfZW5naW5lX3N0YXRzKGk5MTUpIChJTlRFTF9H RU4oaTkxNSkgPj0gOCkKPiAKPiBIbW0sIGRvIHdlIGhhdmUgYW4gZW5naW5lLT5mbGFncyBmb3Ig Y2Fwcz8gSnVzdCB0aGlua2luZyB0aGF0IHdvdWxkIGJlCj4gbW9yZSBhY2N1cmF0ZSB0aGFuIGEg Z2VuIHRlc3Qgc3R1ZmZlZCBhd2F5IGluIGEgaGVhZGVyLiBTbyBhdCBwcmVzZW50IHdlCj4gaGF2 ZSBubyBlbmdpbmUtPmZsYWdzLCBidXQgd2UgZG8gYWxyZWFkeSBoYXZlIG9uZSBib29sIG5lZWRz X2NtZF9wYXJzZXIKPiB0aGF0IGNvdWxkIGJlIHB1bGxlZCBpbnRvIGFuIGVuZ2luZS0+ZmxhZ3Mu IChOb3Qgc3VyZSBpZiBlbmdpbmUtPmNhcHMgaXMKPiBhIGdvb2QgbmFtZSBpZiB3ZSBhcmUgYWRk aW5nIEhXIGNhcHMgYXQgYSBsYXRlciBwb2ludC4pCgpJIGNhbiBkbyB0aGF0IHN1cmUsIEkgbWVh biBJIGNhbid0IGltYWdpbmUgdGhlIHNldHRpbmcgYmVpbmcgYWN0dWFsbHkgCnBlci1lbmdpbmUg KGNtZCBwYXJzZXIgYWxzbyByZWFsbHkgaXNuJ3QsIG5vPyksIGJ1dCBhdCBsZWFzdCBpdCB3b3Vs ZCAKaGF2ZSB0aGUgYmVuZWZpdCBvZiBhdm9pZGluZyB0aGUgaGVhZGVyIG9yZGVyaW5nIHByb2Js ZW1zLiBJIHRoaW5rIGF0IApsZWFzdCwgd2lsbCBzZWUuCgpXaWxsIGdvIHdpdGggZW5naW5lLT5m bGFncywgTkVFRFNfQ01EX1BBUlNFUiBhbmQgU1VQUE9SVFNfU1RBVFMuCgpSZWdhcmRzLAoKVHZy dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=