From: Andrey Grodzovsky Subject: Re: [PATCH 1/5] drm/amdgpu: cleanup GPU recovery check a bit Date: Wed, 22 Aug 2018 10:56:49 -0400 Message-ID: References: <20180822100531.52863-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180822100531.52863-1-christian.koenig-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org U2VyaWVzIGlzIEFja2VkLWJ5OiBBbmRyZXkgR3JvZHpvdnNreSA8YW5kcmV5Lmdyb2R6b3Zza3lA YW1kLmNvbT4KCkFuZHJleQoKCk9uIDA4LzIyLzIwMTggMDY6MDUgQU0sIENocmlzdGlhbiBLw7Zu aWcgd3JvdGU6Cj4gQ2hlY2sgaWYgd2Ugc2hvdWxkIGNhbGwgdGhlIGZ1bmN0aW9uIGluc3RlYWQg b2YgcHJvdmlkaW5nIHRoZSBmb3JjZWQKPiBmbGFnLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0 aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmggICAgICAgIHwgIDMgKystCj4gICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCAzOCArKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9mZW5jZS5j ICB8ICAyICstCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfaXJxLmMgICAg fCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMgICAg fCAgMyArKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L214Z3B1X2FpLmMgICAgICB8 ICA0ICsrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L214Z3B1X3ZpLmMgICAgICB8 ICAzICsrLQo+ICAgNyBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUu aCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gaW5kZXggMTllZjc3MTFk OTQ0Li4zNDBlNDBkMDNkNTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+ IEBAIC0xMTU4LDggKzExNTgsOSBAQCBpbnQgZW11X3NvY19hc2ljX2luaXQoc3RydWN0IGFtZGdw dV9kZXZpY2UgKmFkZXYpOwo+ICAgI2RlZmluZSBhbWRncHVfYXNpY19uZWVkX2Z1bGxfcmVzZXQo YWRldikgKGFkZXYpLT5hc2ljX2Z1bmNzLT5uZWVkX2Z1bGxfcmVzZXQoKGFkZXYpKQo+ICAgCj4g ICAvKiBDb21tb24gZnVuY3Rpb25zICovCj4gK2Jvb2wgYW1kZ3B1X2RldmljZV9zaG91bGRfcmVj b3Zlcl9ncHUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpOwo+ICAgaW50IGFtZGdwdV9kZXZp Y2VfZ3B1X3JlY292ZXIoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gLQkJCSAgICAgIHN0 cnVjdCBhbWRncHVfam9iKiBqb2IsIGJvb2wgZm9yY2UpOwo+ICsJCQkgICAgICBzdHJ1Y3QgYW1k Z3B1X2pvYiogam9iKTsKPiAgIHZvaWQgYW1kZ3B1X2RldmljZV9wY2lfY29uZmlnX3Jlc2V0KHN0 cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsKPiAgIGJvb2wgYW1kZ3B1X2RldmljZV9uZWVkX3Bv c3Qoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4IGMyMzMzOWQ4YWUyZC4uOWY1ZTRiZTc2 ZDVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp Y2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ IEBAIC0zMjQ0LDMyICszMjQ0LDQ0IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2RldmljZV9yZXNldF9z cmlvdihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAlyZXR1cm4gcjsKPiAgIH0KPiAg IAo+ICsvKioKPiArICogYW1kZ3B1X2RldmljZV9zaG91bGRfcmVjb3Zlcl9ncHUgLSBjaGVjayBp ZiB3ZSBzaG91bGQgdHJ5IEdQVSByZWNvdmVyeQo+ICsgKgo+ICsgKiBAYWRldjogYW1kZ3B1IGRl dmljZSBwb2ludGVyCj4gKyAqCj4gKyAqIENoZWNrIGFtZGdwdV9ncHVfcmVjb3ZlcnkgYW5kIFNS SU9WIHN0YXR1cyB0byBzZWUgaWYgd2Ugc2hvdWxkIHRyeSB0byByZWNvdmVyCj4gKyAqIGEgaHVu ZyBHUFUuCj4gKyAqLwo+ICtib29sIGFtZGdwdV9kZXZpY2Vfc2hvdWxkX3JlY292ZXJfZ3B1KHN0 cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICt7Cj4gKwlpZiAoIWFtZGdwdV9kZXZpY2VfaXBf Y2hlY2tfc29mdF9yZXNldChhZGV2KSkgewo+ICsJCURSTV9JTkZPKCJUaW1lb3V0LCBidXQgbm8g aGFyZHdhcmUgaGFuZyBkZXRlY3RlZC5cbiIpOwo+ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiAr Cj4gKwlpZiAoYW1kZ3B1X2dwdV9yZWNvdmVyeSA9PSAwIHx8IChhbWRncHVfZ3B1X3JlY292ZXJ5 ID09IC0xICAmJgo+ICsJCQkJCSAhYW1kZ3B1X3NyaW92X3ZmKGFkZXYpKSkgewo+ICsJCURSTV9J TkZPKCJHUFUgcmVjb3ZlcnkgZGlzYWJsZWQuXG4iKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9 Cj4gKwo+ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gICAvKioKPiAgICAqIGFtZGdwdV9kZXZp Y2VfZ3B1X3JlY292ZXIgLSByZXNldCB0aGUgYXNpYyBhbmQgcmVjb3ZlciBzY2hlZHVsZXIKPiAg ICAqCj4gICAgKiBAYWRldjogYW1kZ3B1IGRldmljZSBwb2ludGVyCj4gICAgKiBAam9iOiB3aGlj aCBqb2IgdHJpZ2dlciBoYW5nCj4gLSAqIEBmb3JjZTogZm9yY2VzIHJlc2V0IHJlZ2FyZGxlc3Mg b2YgYW1kZ3B1X2dwdV9yZWNvdmVyeQo+ICAgICoKPiAgICAqIEF0dGVtcHQgdG8gcmVzZXQgdGhl IEdQVSBpZiBpdCBoYXMgaHVuZyAoYWxsIGFzaWNzKS4KPiAgICAqIFJldHVybnMgMCBmb3Igc3Vj Y2VzcyBvciBhbiBlcnJvciBvbiBmYWlsdXJlLgo+ICAgICovCj4gICBpbnQgYW1kZ3B1X2Rldmlj ZV9ncHVfcmVjb3ZlcihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAtCQkJICAgICAgc3Ry dWN0IGFtZGdwdV9qb2IgKmpvYiwgYm9vbCBmb3JjZSkKPiArCQkJICAgICAgc3RydWN0IGFtZGdw dV9qb2IgKmpvYikKPiAgIHsKPiAgIAlpbnQgaSwgciwgcmVzY2hlZDsKPiAgIAo+IC0JaWYgKCFm b3JjZSAmJiAhYW1kZ3B1X2RldmljZV9pcF9jaGVja19zb2Z0X3Jlc2V0KGFkZXYpKSB7Cj4gLQkJ RFJNX0lORk8oIk5vIGhhcmR3YXJlIGhhbmcgZGV0ZWN0ZWQuIERpZCBzb21lIGJsb2NrcyBzdGFs bD9cbiIpOwo+IC0JCXJldHVybiAwOwo+IC0JfQo+IC0KPiAtCWlmICghZm9yY2UgJiYgKGFtZGdw dV9ncHVfcmVjb3ZlcnkgPT0gMCB8fAo+IC0JCQkoYW1kZ3B1X2dwdV9yZWNvdmVyeSA9PSAtMSAg JiYgIWFtZGdwdV9zcmlvdl92ZihhZGV2KSkpKSB7Cj4gLQkJRFJNX0lORk8oIkdQVSByZWNvdmVy eSBkaXNhYmxlZC5cbiIpOwo+IC0JCXJldHVybiAwOwo+IC0JfQo+IC0KPiAgIAlkZXZfaW5mbyhh ZGV2LT5kZXYsICJHUFUgcmVzZXQgYmVnaW4hXG4iKTsKPiAgIAo+ICAgCW11dGV4X2xvY2soJmFk ZXYtPmxvY2tfcmVzZXQpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZmVuY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9mZW5j ZS5jCj4gaW5kZXggZTc0ZDYyMGQ5Njk5Li42OGNjY2ViYjg0NjMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ZlbmNlLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZmVuY2UuYwo+IEBAIC03MDIsNyArNzAyLDcgQEAgc3Rh dGljIGludCBhbWRncHVfZGVidWdmc19ncHVfcmVjb3ZlcihzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZv aWQgKmRhdGEpCj4gICAJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBkZXYtPmRldl9wcml2 YXRlOwo+ICAgCj4gICAJc2VxX3ByaW50ZihtLCAiZ3B1IHJlY292ZXJcbiIpOwo+IC0JYW1kZ3B1 X2RldmljZV9ncHVfcmVjb3ZlcihhZGV2LCBOVUxMLCB0cnVlKTsKPiArCWFtZGdwdV9kZXZpY2Vf Z3B1X3JlY292ZXIoYWRldiwgTlVMTCk7Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2lycS5jIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2lycS5jCj4gaW5kZXggMWFiZjViNWJhYzllLi5i OTI3ZTg3OTg1MzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2lycS5j Cj4gQEAgLTEwNSw4ICsxMDUsOCBAQCBzdGF0aWMgdm9pZCBhbWRncHVfaXJxX3Jlc2V0X3dvcmtf ZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gICAJc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYgPSBjb250YWluZXJfb2Yod29yaywgc3RydWN0IGFtZGdwdV9kZXZpY2UsCj4gICAJCQkJ CQkgIHJlc2V0X3dvcmspOwo+ICAgCj4gLQlpZiAoIWFtZGdwdV9zcmlvdl92ZihhZGV2KSkKPiAt CQlhbWRncHVfZGV2aWNlX2dwdV9yZWNvdmVyKGFkZXYsIE5VTEwsIGZhbHNlKTsKPiArCWlmICgh YW1kZ3B1X3NyaW92X3ZmKGFkZXYpICYmIGFtZGdwdV9kZXZpY2Vfc2hvdWxkX3JlY292ZXJfZ3B1 KGFkZXYpKQo+ICsJCWFtZGdwdV9kZXZpY2VfZ3B1X3JlY292ZXIoYWRldiwgTlVMTCk7Cj4gICB9 Cj4gICAKPiAgIC8qKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfam9iLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMKPiBp bmRleCAzOTFlMmY3YzAzYWEuLjI2NWZmOTBmNGUwMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfam9iLmMKPiBAQCAtMzcsNyArMzcsOCBAQCBzdGF0aWMgdm9pZCBhbWRn cHVfam9iX3RpbWVkb3V0KHN0cnVjdCBkcm1fc2NoZWRfam9iICpzX2pvYikKPiAgIAkJICBqb2It PmJhc2Uuc2NoZWQtPm5hbWUsIGF0b21pY19yZWFkKCZyaW5nLT5mZW5jZV9kcnYubGFzdF9zZXEp LAo+ICAgCQkgIHJpbmctPmZlbmNlX2Rydi5zeW5jX3NlcSk7Cj4gICAKPiAtCWFtZGdwdV9kZXZp Y2VfZ3B1X3JlY292ZXIocmluZy0+YWRldiwgam9iLCBmYWxzZSk7Cj4gKwlpZiAoYW1kZ3B1X2Rl dmljZV9zaG91bGRfcmVjb3Zlcl9ncHUocmluZy0+YWRldikpCj4gKwkJYW1kZ3B1X2RldmljZV9n cHVfcmVjb3ZlcihyaW5nLT5hZGV2LCBqb2IpOwo+ICAgfQo+ICAgCj4gICBpbnQgYW1kZ3B1X2pv Yl9hbGxvYyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdW5zaWduZWQgbnVtX2licywKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvbXhncHVfYWkuYyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L214Z3B1X2FpLmMKPiBpbmRleCAwNzhmNzBmYWVkY2IuLjhj YmI0NjU1ODk2YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9teGdw dV9haS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvbXhncHVfYWkuYwo+IEBA IC0yNjYsOCArMjY2LDggQEAgc3RhdGljIHZvaWQgeGdwdV9haV9tYWlsYm94X2Zscl93b3JrKHN0 cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgIAl9Cj4gICAKPiAgIAkvKiBUcmlnZ2VyIHJlY292 ZXJ5IGZvciB3b3JsZCBzd2l0Y2ggZmFpbHVyZSBpZiBubyBURFIgKi8KPiAtCWlmIChhbWRncHVf bG9ja3VwX3RpbWVvdXQgPT0gMCkKPiAtCQlhbWRncHVfZGV2aWNlX2dwdV9yZWNvdmVyKGFkZXYs IE5VTEwsIHRydWUpOwo+ICsJaWYgKGFtZGdwdV9kZXZpY2Vfc2hvdWxkX3JlY292ZXJfZ3B1KGFk ZXYpKQo+ICsJCWFtZGdwdV9kZXZpY2VfZ3B1X3JlY292ZXIoYWRldiwgTlVMTCk7Cj4gICB9Cj4g ICAKPiAgIHN0YXRpYyBpbnQgeGdwdV9haV9zZXRfbWFpbGJveF9yY3ZfaXJxKHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2LAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9teGdwdV92aS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvbXhncHVfdmkuYwo+IGlu ZGV4IDlmYzFjMzczNDRjZS4uODQyNTY3YjUzZGY1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L214Z3B1X3ZpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9teGdwdV92aS5jCj4gQEAgLTUyMSw3ICs1MjEsOCBAQCBzdGF0aWMgdm9pZCB4Z3B1X3Zp X21haWxib3hfZmxyX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAgCX0KPiAgIAo+ ICAgCS8qIFRyaWdnZXIgcmVjb3ZlcnkgZHVlIHRvIHdvcmxkIHN3aXRjaCBmYWlsdXJlICovCj4g LQlhbWRncHVfZGV2aWNlX2dwdV9yZWNvdmVyKGFkZXYsIE5VTEwsIGZhbHNlKTsKPiArCWlmIChh bWRncHVfZGV2aWNlX3Nob3VsZF9yZWNvdmVyX2dwdShhZGV2KSkKPiArCQlhbWRncHVfZGV2aWNl X2dwdV9yZWNvdmVyKGFkZXYsIE5VTEwpOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50IHhncHVf dmlfc2V0X21haWxib3hfcmN2X2lycShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=