Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2085.outbound.protection.outlook.com [40.107.93.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id F063A10E0AB for ; Thu, 28 Apr 2022 21:58:47 +0000 (UTC) Message-ID: Date: Thu, 28 Apr 2022 17:58:44 -0400 Content-Language: en-US To: igt-dev@lists.freedesktop.org References: <20220415003328.514267-1-alex.hung@amd.com> <20220415003328.514267-2-alex.hung@amd.com> From: Rodrigo Siqueira Jordao In-Reply-To: <20220415003328.514267-2-alex.hung@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH 2/2] tests/kms_panel_fitting: Skip atomic-fastset for non-i915 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 2022-04-14 20:33, Alex Hung wrote: > In kernel function drm_atomic_check_only checks allow_modeset, > and it can return -EINVAL (-22) for non-i915 devices. > > Therefore, let's skip atomic-fastset subtest for non-i915 until > specific implementation is added for each gpu driver. > > Signed-off-by: Alex Hung > --- > tests/kms_panel_fitting.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c > index 7ed0d196..9f607376 100644 > --- a/tests/kms_panel_fitting.c > +++ b/tests/kms_panel_fitting.c > @@ -242,6 +242,7 @@ static void test_atomic_fastset(data_t *data) > int valid_tests = 0; > struct stat sb; > > + igt_require_f(is_i915_device(display->drm_fd), "not valid for non-i915 devices\n"); > > if (is_i915_device(display->drm_fd)) { > /* Until this is force enabled, force modeset evasion. */ Reviewed-by: Rodrigo.Siqueira