From: Thomas Zimmermann Subject: Re: [PATCH 0/3] Various clean-up patches for GEM VRAM Date: Tue, 21 May 2019 16:25:59 +0200 Message-ID: References: <20190521110831.20200-1-tzimmermann@suse.de> <20190521124022.GL21222@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1650383291==" Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6357E8908B for ; Tue, 21 May 2019 14:26:07 +0000 (UTC) In-Reply-To: <20190521124022.GL21222@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, ray.huang@amd.com, kraxel@redhat.com, sam@ravnborg.org, christian.koenig@amd.com List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1650383291== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1wI7gvrc6UKgCCk6kRGmdNKaJD2NQdlRb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1wI7gvrc6UKgCCk6kRGmdNKaJD2NQdlRb Content-Type: multipart/mixed; boundary="xUOujExXyi71Y4YYbTDyBVcGltPTVjG4G"; protected-headers="v1" From: Thomas Zimmermann To: Daniel Vetter Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, ray.huang@amd.com, kraxel@redhat.com, sam@ravnborg.org, christian.koenig@amd.com Message-ID: Subject: Re: [PATCH 0/3] Various clean-up patches for GEM VRAM References: <20190521110831.20200-1-tzimmermann@suse.de> <20190521124022.GL21222@phenom.ffwll.local> In-Reply-To: <20190521124022.GL21222@phenom.ffwll.local> --xUOujExXyi71Y4YYbTDyBVcGltPTVjG4G Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 21.05.19 um 14:40 schrieb Daniel Vetter: > On Tue, May 21, 2019 at 01:08:28PM +0200, Thomas Zimmermann wrote: >> Replacing drm_gem_vram_push_to_system() moves policy from drivers back= >> to the memory manager. Now, unused BOs are only evicted when the space= >> is required. >> >> The lock/unlock-renaming patch aligns the interface with other names >> in DRM. No functional changes are done. >> >> Finally, there's now a lockdep assert that ensures we don't call the >> GEM VRAM _locked() functions with an unlocked BO. >> >> Patches are against a recent drm-tip and tested on mgag200 and ast HW.= >> >> Thomas Zimmermann (3): >> drm: Replace drm_gem_vram_push_to_system() with kunmap + unpin >> drm: Rename reserve/unreserve to lock/unlock in GEM VRAM helpers >> drm: Assert that BO is locked in drm_gem_vram_{pin,unpin}_locked() >=20 > Awesome, thanks a lot for quickly working on this. On the series: >=20 > Acked-by: Daniel Vetter >=20 > But definitely get someone with more knowledge of the details to check > this all again. >=20 > Aside: Do you plan to continue working on drm drivers, Yes, that's my job at SUSE. > i.e. any need for > drm-misc commit rights? Sure. Thank you for your trust. From what I could found online, I guess [1] and [2] applies? Best regards Thomas [1] https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.htm= l [2] https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html= > Cheers, Daniel >=20 >> >> drivers/gpu/drm/ast/ast_fb.c | 11 ++- >> drivers/gpu/drm/ast/ast_mode.c | 26 ++++--- >> drivers/gpu/drm/drm_gem_vram_helper.c | 86 ++++++-----------------= - >> drivers/gpu/drm/drm_vram_helper_common.c | 2 - >> drivers/gpu/drm/mgag200/mgag200_cursor.c | 40 +++++------ >> drivers/gpu/drm/mgag200/mgag200_fb.c | 11 ++- >> drivers/gpu/drm/mgag200/mgag200_mode.c | 15 +++-- >> include/drm/drm_gem_vram_helper.h | 9 ++- >> 8 files changed, 80 insertions(+), 120 deletions(-) >> >> -- >> 2.21.0 >> >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --xUOujExXyi71Y4YYbTDyBVcGltPTVjG4G-- --1wI7gvrc6UKgCCk6kRGmdNKaJD2NQdlRb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAlzkCncACgkQaA3BHVML eiOS4Qf+PqT9m8udJX8FSAZVN4ifFaKKHyBBPJewMvzxAr3e+DlbzJy62ACtKPTh +S0JAq47knVH/LPhyrTicV/5sYZA3GGeYKRYyOkncDjs0ufkCfvMkdl49Ep1IjwP mGqsKjlP2ZyZ3mlW5x1f8Ruz0j2zIopKyPSdzQOZ6T4Zp0KFLz12vQ/kzwQZbyug 1ZaOEMDUi4sWs/ON7IBqUBoHWsvUYtSNXwRJEGIujZOHRmv4jhr9k+L/vaHWqHdc pgxKcYBLAoenGayU6KM3xxyZdvKMldfNiH1yTCrUfItuS0MVOtkjEITJETFps6Is CeWl53/Pk8gHZNPYcWBaC73mxyKubw== =Vzj4 -----END PGP SIGNATURE----- --1wI7gvrc6UKgCCk6kRGmdNKaJD2NQdlRb-- --===============1650383291== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1650383291==--