From: "cron2 (Code Review)" Date: Wed, 8 May 2024 13:49:12 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="G9aiYYH87dM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config first List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --G9aiYYH87dM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/556?usp=3Demail ) Change subject: configure: Try to detect LZO with pkg-config first ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Does not work for me yet. Applied this to a fresh git checkout on fbsd14, which has pkg-config and lz= o2.pc, but it still failed. Relevant parts from config.log: ``` configure:18781: checking for LZO configure:18788: $PKG_CONFIG --exists --print-errors "lzo2" configure:18791: $? =3D 0 configure:18805: $PKG_CONFIG --exists --print-errors "lzo2" configure:18808: $? =3D 0 configure:18848: result: yes configure:18850: checking for lzo1x_1_15_compress in -llzo2 configure:18879: cc -o conftest -g -O2 -std=3Dc99 conftest.c -llzo2 -ln= v >&5 ld: error: unable to find library -llzo2 ``` and from pkgconf output ``` gert@...2801... $ pkg-config --cflags lzo2 -I/usr/local/include/lzo gert@...2801... $ pkg-config --libs lzo2 -L/usr/local/lib -llzo2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee61fee74f26e693 Gerrit-Change-Number: 556 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 08 May 2024 13:49:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --G9aiYYH87dM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #2:

      Does not work for me yet.

      Applied this to a fresh git checkout = on fbsd14, which has pkg-config and lzo2.pc, but it still failed.

      Relevant parts from co= nfig.log:

      ```=
      configure:18781: checking for LZO
      configure:18788: $PKG_CONFIG --exi= sts --print-errors "lzo2"
      configure:18791: $? =3D 0
      configu= re:18805: $PKG_CONFIG --exists --print-errors "lzo2"
      configure= :18808: $? =3D 0
      configure:18848: result: yes
      configure:18850: checki= ng for lzo1x_1_15_compress in -llzo2
      configure:18879: cc -o conftest -g = -O2 -std=3Dc99 conftest.c -llzo2 -lnv >&5
      ld: error: unable t= o find library -llzo2
      ```

      and from pkgconf output
      ```
      gert@...2801... $ pkg-con= fig --cflags lzo2
      -I/usr/local/include/lzo
      gert@...2801... $ pkg-conf= ig --libs lzo2
      -L/usr/local/lib -llzo2

To view= , visit c= hange 556. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c038dc4ec80d3499582d81eee6= 1fee74f26e693
Gerrit-Change-Number: 556
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 08 May 2024 13:49:12= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--G9aiYYH87dM=--