From: Jon Hunter Subject: Re: [PATCH 4.4 000/159] 4.4.203-stable review Date: Mon, 25 Nov 2019 13:22:58 +0000 Message-ID: References: <20191122100704.194776704@linuxfoundation.org> <20191122133931.GA2033651@kroah.com> <20191122134131.GA2050590@kroah.com> <20191122134627.GB2050590@kroah.com> <9f976044-2dbc-6c19-11e7-210cd7ab35ea@nvidia.com> <7edc9531-347e-9ac7-2583-5efb49acffdb@nvidia.com> <20191125094116.GA2340170@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191125094116.GA2340170@kroah.com> Content-Language: en-US Sender: stable-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Guenter Roeck , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, stable@vger.kernel.org, linux-tegra List-Id: linux-tegra@vger.kernel.org On 25/11/2019 09:41, Greg Kroah-Hartman wrote: > On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote: >> >> On 23/11/2019 15:46, Guenter Roeck wrote: >>> On 11/22/19 6:48 AM, Jon Hunter wrote: >>> >>> [ ... ] >>> >>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path >>>> dwc3 not found >>>> FATAL ERROR: Syntax error parsing input tree >>>> scripts/Makefile.lib:293: recipe for target >>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed >>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1 >>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed >>>> make: *** [dtbs] Error 2 >>>> >>>> >>>> This is caused by the following commit ... >>>> >>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f >>>> Author: H. Nikolaus Schaller >>>> Date:=C2=A0=C2=A0 Fri Sep 28 17:54:00 2018 +0200 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 ARM: dts: omap5: enable OTG role for DWC3 con= troller >>>> >>> >>> On top of the breakage caused by this patch, I would also argue >>> that it is not a bug fix and should not have been included >>> in the first place. >>> >>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5: >>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of >>> that patch, I highly doubt that a backport to 4.4 would work. >=20 > Good catch, I have now dropped both of these patches and pushed out a > -rc3 >=20 >> FYI ... I am still seeing a build failure because of this with -rc2 ... >=20 > Can you see if -rc3 is also giving you problems? Better, but I appear to be seeing some random suspend failures with this now on one board. I will try to bisect this. Test results for stable-v4.4: 6 builds: 6 pass, 0 fail 12 boots: 12 pass, 0 fail 19 tests: 18 pass, 1 fail Linux version: 4.4.203-rc3-g2576206c30b5 Boards tested: tegra124-jetson-tk1, tegra20-ventana, tegra30-cardhu-a04 Cheers Jon --=20 nvpublic