Received: by 2002:a17:907:1627:b0:8ed:b3f:fd98 with SMTP id hb39csp800350ejc; Fri, 3 Mar 2023 00:33:25 -0800 (PST) X-Received: by 2002:a05:6870:a44a:b0:176:1fe8:8922 with SMTP id n10-20020a056870a44a00b001761fe88922mr536226oal.29.1677832405792; Fri, 03 Mar 2023 00:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677832405; cv=none; d=google.com; s=arc-20160816; b=hd3vIGkmvMmF+xzKnPZ8gh6OGl4VvgfsSYjASgG/KLOlGOEkQRRctULBiVHphRZJM/ IVl7pxuILOz/ogcG06cjWLznEDSnx2cmjoDGZ0IJ5OD8GCLUQF1HnqK9E9y/d7WIdPdC lt0XSopVV7NffbE8LAfAFqBKSMpxEdc3OzwYoiOKIEY6eVOUqEiuylfzzkNZ+7nA3MJw DMSC/i4WuaUGJSke0S6OqMAV+bsiJkJQv/SkekfhFH2s6Q8EQXxHeAQbeW3mNY5wgSTz 8sBUNhdG2vt+P8FkWdYd7tcUvAk1SAG2x6YNqBCrH81kdXbdrannzZXLqKrpqwNthcYc RQuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=5poiB9hHsOof3PcUw2itX1s4KSe9/ZAMgLRbkPBocmw=; b=Ok+qSlK3Bk5kDkF3A9WkXXPj2sJaQYKYjSnTdox4tYveTS0MHI7gJKotyalv1xsKLE PRa/LGpGLTh6oYaGX7txvObBxhqY+e0RCBjrInLd/Eu/mblGbhOr9hnT80rpNzdtF18u FTbuKVY+5hML0FxvN46+2ORGfiRN84/8pQWOAPXx59nFVUbQ2ZvxuH4QeV4ItUtzTHvm Bosl3e7cx4bFdJaMpgThfwxhwQM56UE56Kf7AmhJF+tHA3qHyoBl6ExNw5+gPr1612FI rZRCyt8n9vSBsZQluJSe7yrkn+AMCkUkZBQVIsw51HhRsLiyYXk8BLL6X+AutFufKAsO a4Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=FbWXFoPP; spf=pass (google.com: domain of dbarboza@ventanamicro.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dbarboza@ventanamicro.com Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id f4-20020a056870d30400b00172be654bb3sor578152oag.81.2023.03.03.00.33.25 for (Google Transport Security); Fri, 03 Mar 2023 00:33:25 -0800 (PST) Received-SPF: pass (google.com: domain of dbarboza@ventanamicro.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=FbWXFoPP; spf=pass (google.com: domain of dbarboza@ventanamicro.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=dbarboza@ventanamicro.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1677832405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5poiB9hHsOof3PcUw2itX1s4KSe9/ZAMgLRbkPBocmw=; b=FbWXFoPPCV2woaEFtMpP8EV9lfsqYjE40+w4F0JcHNkyd0MJuJ6EUuEOgBEQA1PceL MJdWRXjEsRaDpgpi8u9GxIdWJjGO3+tjQJAGR9xo0wE4n/72MD6s8caj291SKJtPb2VD Lt+sdzK58zf4LXGUtQtjQrPFMYZYp7SowvzVmVN+rfJu4LyVf6KnLIZhBZVlqXK49MOC IFiz6dQqt50J6W+y05GXsb0PxlVf44UrtH/QH+i0HscaFdFTddTOhMBebe0gDOMLAMCx 5xZS/KbOJI9rVUtQLXEMt/r7VNLkj5FAx91/mlFkQbmxIEmoYbBgQcHwnEPl/zybcjVT dJ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677832405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5poiB9hHsOof3PcUw2itX1s4KSe9/ZAMgLRbkPBocmw=; b=msuRwgvzok1GlyKqGvbPE+/ldmOCXTQI6gOLYkTpQUAsFf+EbUFxcqxCoCd2LJ3HHR vgMorWSxWlCYViCZRqhnLoAKbwhonzetepoXSJtTmipys1m6PHnMgtuLFJlom3PG38gF 7KL8kj5wE0QJliBKepSBJc+TtKRmYbKHNpt6iuk/72XpodGtdOJTtWJCxKDDn1he/i0/ kaC4alIZZMqVnaAHDUeruFyVhLntgmFxe22KqvTfYhd0iZOtRVZQzNp2hD8hip6G7t2A dQHYz3ogkZGNKLXBGrqtJVAnpKpxEszjqRBtbbjG6ErZC1ObF+Skjh0Wm4jbkbiEcxCc M4AQ== X-Gm-Message-State: AO0yUKVtbxyQ0v2R+YHji799PU8R46wjA6yDkTgYWXMWiBBlmRZRAcyg 4TpGqCs4lrL65hHoXHZ6C1inDWvanmyMiIjI X-Google-Smtp-Source: AK7set8hlr1yHx+OBqCBQiyW/tJc0LeKAGcAzKgQug0uqmMG1EmbLpBoo1gFuxZYTLA7H9cb7XHBMA== X-Received: by 2002:a05:6871:207:b0:172:7c37:69b with SMTP id t7-20020a056871020700b001727c37069bmr712055oad.5.1677832404958; Fri, 03 Mar 2023 00:33:24 -0800 (PST) Return-Path: Received: from [192.168.68.107] ([177.189.53.31]) by smtp.gmail.com with ESMTPSA id eg27-20020a056870989b00b001727d67f2dbsm746714oab.40.2023.03.03.00.33.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 00:33:24 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 05:33:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 04/26] gdbstub: clean-up indent on gdb_exit Content-Language: en-US To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: Weiwei Li , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Palmer Dabbelt , Laurent Vivier , nicolas.eder@lauterbach.com, Ilya Leoshkevich , kvm@vger.kernel.org, "Edgar E. Iglesias" , David Gibson , Max Filippov , Sunil Muthuswamy , qemu-s390x@nongnu.org, Stafford Horne , Bin Meng , Marek Vasut , Greg Kurz , Song Gao , Aleksandar Rikalo , Liu Zhiwei , Alistair Francis , Chris Wulff , qemu-riscv@nongnu.org, Michael Rolnik , qemu-arm@nongnu.org, Cleber Rosa , Artyom Tarasenko , Marcel Apfelbaum , Eduardo Habkost , Yoshinori Sato , Alexandre Iooss , Daniel Henrique Barboza , Jiaxun Yang , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , mads@ynddal.dk, Mark Cave-Ayland , qemu-ppc@nongnu.org, Richard Henderson , John Snow , Xiaojuan Yang , Thomas Huth , Paolo Bonzini , Mahmoud Mandour , Aurelien Jarno , Bastian Koppelmann , Yanan Wang , David Hildenbrand , Taylor Simpson , Peter Maydell References: <20230302190846.2593720-1-alex.bennee@linaro.org> <20230302190846.2593720-5-alex.bennee@linaro.org> From: Daniel Henrique Barboza In-Reply-To: <20230302190846.2593720-5-alex.bennee@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TUID: M03DQcjlZbku On 3/2/23 16:08, Alex Bennée wrote: > Otherwise checkpatch will throw a hissy fit on the later patches that > split this function up. > > Signed-off-by: Alex Bennée > --- Reviewed-by: Daniel Henrique Barboza > gdbstub/gdbstub.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > index fb9c49e0fd..63b56f0027 100644 > --- a/gdbstub/gdbstub.c > +++ b/gdbstub/gdbstub.c > @@ -3021,27 +3021,27 @@ static void gdb_read_byte(uint8_t ch) > /* Tell the remote gdb that the process has exited. */ > void gdb_exit(int code) > { > - char buf[4]; > + char buf[4]; > > - if (!gdbserver_state.init) { > - return; > - } > + if (!gdbserver_state.init) { > + return; > + } > #ifdef CONFIG_USER_ONLY > - if (gdbserver_state.socket_path) { > - unlink(gdbserver_state.socket_path); > - } > - if (gdbserver_state.fd < 0) { > - return; > - } > + if (gdbserver_state.socket_path) { > + unlink(gdbserver_state.socket_path); > + } > + if (gdbserver_state.fd < 0) { > + return; > + } > #endif > > - trace_gdbstub_op_exiting((uint8_t)code); > + trace_gdbstub_op_exiting((uint8_t)code); > > - snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); > - put_packet(buf); > + snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); > + put_packet(buf); > > #ifndef CONFIG_USER_ONLY > - qemu_chr_fe_deinit(&gdbserver_state.chr, true); > + qemu_chr_fe_deinit(&gdbserver_state.chr, true); > #endif > } >