References: <20190906174458.14975-1-matthias.andree@...68...> <20190906174458.14975-2-matthias.andree@...68...> From: Matthias Andree Message-ID: Date: Sun, 15 Sep 2019 11:39:37 +0200 MIME-Version: 1.0 In-Reply-To: <20190906174458.14975-2-matthias.andree@...68...> Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH] tests/t__lpback.sh: Switch sed(1) to POSIX-compatible regex. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net What is the review status of the change Kyle Evans proposed below that I've relayed on Sept 6th? Am 06.09.19 um 19:44 schrieb Matthias Andree: > From: Kyle Evans > > A test run with FreeBSD PR 229925 'Disallow escaping ordinary characters in regex(3)' > reveals one sed expression that uses the GNU-extension "\s". > Given that this is the only occurrence and it's a trivial fix, update it to be POSIX-compatible. > > Signed-off-by: Matthias Andree > --- > tests/t_lpback.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/t_lpback.sh b/tests/t_lpback.sh > index 2052c626..bb8a1d51 100755 > --- a/tests/t_lpback.sh > +++ b/tests/t_lpback.sh > @@ -26,7 +26,7 @@ trap "rm -f key.$$ log.$$ ; exit 1" 0 3 > > # Get list of supported ciphers from openvpn --show-ciphers output > CIPHERS=$(${top_builddir}/src/openvpn/openvpn --show-ciphers | \ > - sed -e '/The following/,/^$/d' -e s'/ .*//' -e '/^\s*$/d') > + sed -e '/The following/,/^$/d' -e s'/ .*//' -e '/^[[:space:]]*$/d') > > # SK, 2014-06-04: currently the DES-EDE3-CFB1 implementation of OpenSSL is > # broken (see http://rt.openssl.org/Ticket/Display.html?id=2867), so exclude > -- > 2.21.0