From: "stipa (Code Review)" Date: Wed, 9 Apr 2025 13:54:44 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7bT/12/os2Y="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support with NRPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: flichtenheld , plaisthos , openvpn-devel --7bT/12/os2Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 18: Code-Review+2 (1 comment) Patchset: PS18: I couldn't find any more issues in the code, I tested it and it works like = expected - I checked that the NRPT rules are created/removed and adapter-sp= ecific DNS suffixes are also respected in NRPT. Probably not directly related to this patch, but the behavior is now not ac= cording to man page. For example if server pushes push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" I would expect only .fi domains being resolved via 1.1.1.1, however ALL dom= ains are resolved via 1.1.1.1 - this is likely because we set 1.1.1.1 DNS o= n VPN adapter. why we do it in addition to NRPT? We should either change th= e man page or fix the behavior. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 18 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Wed, 09 Apr 2025 13:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --7bT/12/os2Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 18:Code-Review +2

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #18:

      I couldn't find any more issues in the c= ode, I tested it and it works like expected - I checked that the NRPT rules= are created/removed and adapter-specific DNS suffixes are also respected i= n NRPT.

      Proba= bly not directly related to this patch, but the behavior is now not accordi= ng to man page. For example if server pushes

        push "dns server 1 reso=
      lve-domains fi"
      push "dns server 1 address 1.1.1.1"
      =
      I would expect only .fi domains being resolved via 1.1.1.1, however A= LL domains are resolved via 1.1.1.1 - this is likely because we set 1.1.1.1= DNS on VPN adapter. why we do it in addition to NRPT? We should either cha= nge the man page or fix the behavior.

To view, = visit cha= nge 837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 18
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Wed, 09 Apr 2025 13:54:44= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--7bT/12/os2Y=--