Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64627C10F00 for ; Wed, 6 Mar 2019 13:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B45920684 for ; Wed, 6 Mar 2019 13:55:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=6wind-com.20150623.gappssmtp.com header.i=@6wind-com.20150623.gappssmtp.com header.b="wGdkF1jX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbfCFNz2 (ORCPT ); Wed, 6 Mar 2019 08:55:28 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:34259 "EHLO mail-wm1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbfCFNz2 (ORCPT ); Wed, 6 Mar 2019 08:55:28 -0500 Received: by mail-wm1-f48.google.com with SMTP id o10so4492982wmc.1 for ; Wed, 06 Mar 2019 05:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vauauh4Fdk29p7KwJL2v3Go5qVL0hQH7BgBF368lqdY=; b=wGdkF1jXFYDXMC6j8RovM89mNFj90+boXlnc3doQNbculzh2eQ6/84k7aycWD5rscU q0SbmJ5AoKViwgjfg/21SU3bfNYn1X5t2ik7H5jA/X0FZZh0eS9scaWCq2pY27jv3BEO BF2SN8sMVZIo44snJpkz4ezn8Di2vArfoSZEfnSrRQ/FMQdCAKZpNYkrhpojSi0aiHr/ acTC8W2F871wp9WmKp8GudUt7IFkgYVZwHyE23ls3VituxT1IKw5W43FHCe8xypMQ1pM eB1iFRAJGOyFFNSNEIxDGZPz76Bi+g6IXWj55ZzjilObyH+1CXGX74vyaRUKSx16GYk/ +4LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Vauauh4Fdk29p7KwJL2v3Go5qVL0hQH7BgBF368lqdY=; b=Y9g2mpuVHUg4gYT8X70Flrvtim2ZyIqT2/WfwdD5OlrM5HSB5yI4XKgQyebHYiJl4d rljR7Mpb/NI8jCv1PQe+JVZPnK73fhMYGncvrcVVi50O0SMWhDDBl2Ey1dyUdW2R7FE5 7d1CwgBEAFxUdP5eAvKYxxSr6YsfZg12TDi0XXD6K9fGmI2Sg4fJKyU3UKWZan6Zy+F5 PyimJV3Ec9Pza+Rjr+3f1zPFAy9y5hO/01xASfcrwdoJ1TXf+VE65dlavqhMzqjITWef Lq+shxqUxcTUS7mD6N0il1HvPl+sLl9+Nvi69gHkTFUUfwlXJobG7ERi0V1twYUNe3Pv cjsQ== X-Gm-Message-State: APjAAAXo/FsV/GIozjxKH/81I8Bm70yvyw9UJbZ4vndP1m0dZRkzQzQq iyt0MDvSzsw4gQzVbRtoSE9UKHH7KlQ= X-Google-Smtp-Source: APXvYqwBPHOlBIl8pkwivycsT/QyMvrgl57IbL4LCKaxtvlt/ajAqF/PlfcHR25/siNtcd9jepGBcQ== X-Received: by 2002:a1c:7e58:: with SMTP id z85mr2568707wmc.52.1551880526547; Wed, 06 Mar 2019 05:55:26 -0800 (PST) Received: from [10.16.0.69] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k6sm2586295wrq.82.2019.03.06.05.55.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 05:55:25 -0800 (PST) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net] gre: fix kernel panic when using lw tunnel To: davem@davemloft.net Cc: netdev@vger.kernel.org, wenxu , Alan Maguire References: <20190306103227.21279-1-nicolas.dichtel@6wind.com> From: Nicolas Dichtel Organization: 6WIND Message-ID: Date: Wed, 6 Mar 2019 14:55:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190306103227.21279-1-nicolas.dichtel@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le 06/03/2019 à 11:32, Nicolas Dichtel a écrit : > There was several problems: > - skb_dst(skb) can be NULL when the packet comes from a gretap tunnel; > - skb_dst(skb)->ops may point to md_dst_ops, which doesn't set ->mtu > handler, thus calling dst_mtu() leads to a panic. > > I also wonder if ->cow_metrics may be called if skb_dst(skb)->ops points > to ovs_dst_ops. > > Don't try to do anything in one of those cases. > > Fixes: 962924fa2b7a ("ip_gre: Refactor collect metatdata mode tunnel xmit to ip_md_tunnel_xmit") > CC: wenxu > Signed-off-by: Nicolas Dichtel Please, drop it, Alan's version is better. Regards, Nicolas