Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20FA11FBEB1 for ; Fri, 1 Aug 2025 08:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035937; cv=none; b=XQi/1LubRKFYBEmAropntAAl+JMwKEOZ4Uee9QLnGflgJ0KOLV0bNbFWsQss2NpHVmpVAWU4GbDAQrr/DOlr3525+ZJqPIUZC0U3otyePsByEbJTXBGkJ47gdGbz13nhDzx2IWOMXKZ9B4csGy/qX4WmjC1Ym7p9QPQKARKuepw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035937; c=relaxed/simple; bh=aoz4P1nsSkMEELyZypgyoeiSHhweBMFduFovE7Zb5oo=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=JVRYPJ9Rp4zwTKEZnRwo5B6kNx38ERKM4c7zmyWr0W6YC4O8uIFyQK9IZgSUnOw+/F1EExpYeBYWmFYiE784V/0AA9VVs2S3w2lbtnhovJlv1KoZrdDR3xBmfj/iZykkYFW4FdFCf4Y5xgoXFkgpA6U9uGq5goLY/9iHbrAXDmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dIr/M1IV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dIr/M1IV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E48F2C4CEE7; Fri, 1 Aug 2025 08:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754035936; bh=aoz4P1nsSkMEELyZypgyoeiSHhweBMFduFovE7Zb5oo=; h=Date:Reply-To:Subject:From:To:References:In-Reply-To:From; b=dIr/M1IVOYMJtBeGraV2QWGbmIq/aHvL+jQDDRSuCydjp892wvd5wFMrbWIX7vvCA /CKEHYOC7G6t/ya1VAKSLtzdv+UtsUcbg8S8iF1B8jc0h4IV+ayMM3wxTDlFOuZsCv GtRSTr+0h/QMVSSwWexYuUPI1NfyQuENiRy5BR7/Ahc/Vvg2nw/IPiSkowCxWijOf9 xK/VmU4k+9bG7xnwmUYIcFjCXsg1tVcJWs2JJnVhqkzu3GpArbkKOCeOLf7y14ShhL bFoWJ4sGnmE5Wrvq87oxmEqtgTpzeupg7SPPYQ8AniU2YX57WZBuSxwq63wXpllU/g qtaZ9vv4hC+pQ== Message-ID: Date: Fri, 1 Aug 2025 10:12:14 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 7/9] all: run black From: Daniel Gomez To: Luis Chamberlain , Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev References: <20250730060147.182140-1-mcgrof@kernel.org> <20250730060147.182140-8-mcgrof@kernel.org> Content-Language: en-US Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/07/2025 14.57, Daniel Gomez wrote: > On 30/07/2025 08.01, Luis Chamberlain wrote: >> Run black to fix tons of styling issues with tons of Python scripts. >> In order to help bots ensure they don't add odd styling we need a >> convention. >> >> Signed-off-by: Luis Chamberlain > > Acked-by: Daniel Gomez > > FYI, I'm working on b4 check stuff mentioned in the other thread. I think this > is really nice but it would be awesome to also extend it to Ansible files using > the Ansible linter: > > ansible-lint --help > {...} > --fix [WRITE_LIST] Allow ansible-lint to perform auto-fixes, including YAML > reformatting > > So, these changes with black/ansible-lint, etc make sense if: > 1. Add b4 integration > 2. Make CI run the scripts as well (make style, make check, etc) > > But I suspect a minimal testing may be needed. > > Thoughts? I'll send an RFC with more details.