Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38A133C1 for ; Mon, 6 Mar 2023 20:49:43 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id da10so44176349edb.3 for ; Mon, 06 Mar 2023 12:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678135782; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AR0RTzTpEWtFuffV0SrWkUkG0y4zet3XlibWdln0yDA=; b=HyfuVj6L8naGrI6ho4c5ZRMQCed3OnQv5JMirJm4TP6adfvJ5CacJ8uP3i065Sg9qY PFKBC008+ibnRGLq+jubs++BW7k08UBU56JgFvBo5bQwZ0vamL4gIAUnLo0HinHB8n/Z 3bAyLQX7FdVoTqaQ1Js7hRknztAQz7m1ggzPfVmm7/3CaRE0y6XDPgf1qNSIM0UOz+lC nnjPYaatPkP5aPpz0c/lc6c2BAfolN6kyYityKiy+1/3wEiVVl1l86bQf7F2eZO/jhRI jYEQlwBS4BO+CZ9d358L/uti7qjP/yXIntySLtC4LF+n8ZqJxWfouNYqGd/gWvv0BKpu Q8zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678135782; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AR0RTzTpEWtFuffV0SrWkUkG0y4zet3XlibWdln0yDA=; b=iTVp/L21+1RIppRsNQloBZVyPd+8sScTpa0FoheIDN61C+WYAr2tFhEQPlOxtN60kj NUYlEN4KK5zjmSzis1A9PuvV8CZF86/YZFpVSthBf7g1Tz1ZWRUfzZfb39KZi77tAMRE saEsxt97n7TOzfmpXFn7jgm9u+udo7S/Jhm9eevkYBhXHwyUCIv02ztX2WenoKiVhnFe RvJckr2nsQ1mG/br+WKrU1OHd8vHn0B6X/QUKtQwIfC6lw2W3E+0Zf306jXRS7fZVAsJ f6lHScGX2tZYMqkxUJQFPnUCsU+nVQmuNSTjRHq2DV7KbS72m8XEd4y9zlUIZrBA2yJG kkTA== X-Gm-Message-State: AO0yUKVwHweoxBjZMJw7XLzKA08vjQ9F9rNH4T4wTgbv2xQkb7aLOm3Q 6U8GgAvFK1MpdrmgSbQfF5I= X-Google-Smtp-Source: AK7set8snMKr45wof1XT1a17My+cz3Dv9cvJjNSYPmq/VL6nrLC/pOMGA7RVeMoqjp+lCogVoglEnw== X-Received: by 2002:a05:6402:274d:b0:4af:7bdc:18a5 with SMTP id z13-20020a056402274d00b004af7bdc18a5mr15401464edd.0.1678135781702; Mon, 06 Mar 2023 12:49:41 -0800 (PST) Received: from [192.168.0.102] (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id f14-20020a1709067f8e00b008c16025b318sm4992566ejr.155.2023.03.06.12.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 12:49:41 -0800 (PST) Message-ID: Date: Mon, 6 Mar 2023 21:49:40 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] staging: rtl8192e: Remove empty Array Rtl8192PciEPHY_REGArray Content-Language: en-US To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <511bd239bf033dca3efcc64a640d5343c98fa897.1677955334.git.philipp.g.hortmann@gmail.com> <7d3eaf69-8ddb-4b63-ae8c-89b6a34e9493@kili.mountain> From: Philipp Hortmann In-Reply-To: <7d3eaf69-8ddb-4b63-ae8c-89b6a34e9493@kili.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/23 10:25, Dan Carpenter wrote: > On Sat, Mar 04, 2023 at 08:13:22PM +0100, Philipp Hortmann wrote: >> Remove empty array Rtl8192PciEPHY_REGArray and the code where it is used >> because it is dead code. >> >> Signed-off-by: Philipp Hortmann >> --- >> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 5 +---- >> drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 2 -- >> drivers/staging/rtl8192e/rtl8192e/table.c | 2 -- >> drivers/staging/rtl8192e/rtl8192e/table.h | 2 -- > > What are these table.[ch] files? I don't seem to have them. > > regards, > dan carpenter > Hi Dan, thanks for the review. Here some answers to your questions: With patch: "[PATCH] staging: rtl8192e: Change filename r8192E_hwimg.x to table.x" I changed the filename of r8192E_hwimg.c to table.c and r8192E_hwimg.h to table.h to adapt filenames from drivers/net/wireless/realtek/rtlwifi rtl8192ee and rtl8192se. Task is from TODO file. Thanks for your support. Bye Philipp