From: "cron2 (Code Review)" Date: Thu, 30 Apr 2026 13:23:43 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7FZZrJmvujA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dns-scripts: Fix dnssec values in comments and Copyright statement fo... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --7FZZrJmvujA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1645?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dns-scripts: Fix dnssec values in comments and Copyright st= atement format ...................................................................... dns-scripts: Fix dnssec values in comments and Copyright statement format - Fix the example value of dnssec to an actual valid one - Fix the formatting of the Copyright statements to be consistent with all other files in the project Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645 Message-Id: <20260430130354.25337-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 800.html Signed-off-by: Gert Doering --- M distro/dns-scripts/haikuos_file-dns-updown.sh M distro/dns-scripts/macos-dns-updown.sh M distro/dns-scripts/openresolv-dns-updown.sh M distro/dns-scripts/resolvconf_file-dns-updown.sh M distro/dns-scripts/systemd-dns-updown.sh 5 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1645/2 diff --git a/distro/dns-scripts/haikuos_file-dns-updown.sh b/distro/dns-scr= ipts/haikuos_file-dns-updown.sh index 6da0954..e19b2b7 100644 --- a/distro/dns-scripts/haikuos_file-dns-updown.sh +++ b/distro/dns-scripts/haikuos_file-dns-updown.sh @@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying Haiku OS resolv.conf -# (C) Copyright 2024 OpenVPN Inc +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/macos-dns-updown.sh b/distro/dns-scripts/ma= cos-dns-updown.sh index fb17b2b0..fccc6b5 100644 --- a/distro/dns-scripts/macos-dns-updown.sh +++ b/distro/dns-scripts/macos-dns-updown.sh @@ -2,7 +2,7 @@ # # dns-updown - add/remove openvpn provided DNS information # -# (C) Copyright 2025 OpenVPN Inc +# Copyright (C) 2025-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/openresolv-dns-updown.sh b/distro/dns-scrip= ts/openresolv-dns-updown.sh index 1404819..4aca99f 100644 --- a/distro/dns-scripts/openresolv-dns-updown.sh +++ b/distro/dns-scripts/openresolv-dns-updown.sh @@ -1,8 +1,8 @@ #!/bin/sh # # Simple OpenVPN up/down script for openresolv integration -# (C) Copyright 2016 Baptiste Daroussin -# 2024 OpenVPN Inc +# Copyright (C) 2016 Baptiste Daroussin +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -22,7 +22,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/resolvconf_file-dns-updown.sh b/distro/dns-= scripts/resolvconf_file-dns-updown.sh index 70872c7..8d23ed6 100644 --- a/distro/dns-scripts/resolvconf_file-dns-updown.sh +++ b/distro/dns-scripts/resolvconf_file-dns-updown.sh @@ -1,7 +1,7 @@ #!/bin/sh # # Simple OpenVPN up/down script for modifying /etc/resolv.conf -# (C) Copyright 2024 OpenVPN Inc +# Copyright (C) 2024-2026 OpenVPN Inc # # SPDX-License-Identifier: BSD-2-Clause # @@ -21,7 +21,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # diff --git a/distro/dns-scripts/systemd-dns-updown.sh b/distro/dns-scripts/= systemd-dns-updown.sh index f91cde6..553056b 100644 --- a/distro/dns-scripts/systemd-dns-updown.sh +++ b/distro/dns-scripts/systemd-dns-updown.sh @@ -29,7 +29,7 @@ # dns_server_1_port_2 53 # dns_server_1_resolve_domain_1 mycorp.in # dns_server_1_resolve_domain_2 eu.mycorp.com -# dns_server_1_dnssec true +# dns_server_1_dnssec yes # dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in # -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1645?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b Gerrit-Change-Number: 1645 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --7FZZrJmvujA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

dns-scripts: Fix dnssec values in c=
omments and Copyright statement format

- Fix the example value of dn= ssec to an actual valid one
- Fix the formatting of the Copyright statem= ents to be
consistent with all other files in the project

Chang= e-Id: Id6832e3f56420debc8b19d0144d53ca41abb678b
Signed-off-by: Frank Lic= htenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1826...= 6...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1645
Mess= age-Id: <20260430130354.25337-1-gert@...1296...>
URL: https://www.= mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36800.html
Signe= d-off-by: Gert Doering <gert@...1296...>
---
M distro/dns-scrip= ts/haikuos_file-dns-updown.sh
M distro/dns-scripts/macos-dns-updown.shM distro/dns-scripts/openresolv-dns-updown.sh
M distro/dns-scripts/res= olvconf_file-dns-updown.sh
M distro/dns-scripts/systemd-dns-updown.sh5 files changed, 10 insertions(+), 10 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/1645/2<=
/pre>
-# (C) Copyrig=
ht 2024 OpenVPN Inc <sales@...515...>
+# Copyright (C) 2024-2026 OpenVPN Inc <sales@...493...= 515...>
#
# SPDX-License-Identifier: B= SD-2-Clause
#
@@ -21,7 +21,7 @@
= # dns_server_1_port_2 53
# dns_server_1_resolve= _domain_1 mycorp.in
# dns_server_1_resolve_domain_2 eu.m= ycorp.com
-# dns_serv= er_1_dnssec true
+# = dns_server_1_dnssec yes
# dns_server_1_transport DoH
# dns_server_1_sni dns.mycorp.in
#=
diff --git a/distro/dns-scripts/macos-dns-updown.sh b/distro/dns-= scripts/macos-dns-updown.sh
index fb17b2b0..fccc6b5 100644<= /span>
--- a/distro/dns-scripts/macos-dns-updown.sh
+++ b/distro/dns-scripts/macos-dns-updown.sh

@@ -2,7 +2,7= @@
#
# dns-updown - add/remove openvpn p= rovided DNS information
#
-# (C) Copyright 2025 OpenVPN Inc <sales@...515...&g= t;
+# Copyright (C) 2= 025-2026 OpenVPN Inc <sales@...515...>
#
<= span> # SPDX-License-Identifier: BSD-2-Clause

#
= @@ -21,7 +21,7 @@
# dns_server_1_port_2 53<= br> # dns_server_1_resolve_domain_1 mycorp.in
# = dns_server_1_resolve_domain_2 eu.mycorp.com
-# dns_server_1_dnssec true
+# dns_server_1_dnssec yes
= # dns_server_1_transport DoH
# dns_server_1_sni dns.m= ycorp.in
#
diff --git a/distro/dns-scripts= /openresolv-dns-updown.sh b/distro/dns-scripts/openresolv-dns-updown.sh
index 1404819..4aca99f 100644
--- a/distro/dns= -scripts/openresolv-dns-updown.sh
+++ b/distro/dns-scripts/= openresolv-dns-updown.sh
@@ -1,8 +1,8 @@
#= !/bin/sh
#
# Simple OpenVPN up/down scrip= t for openresolv integration
-# (C) Copyright 2016 Baptiste Daroussin
-# 2024 OpenVPN Inc <sales@...2092...= ..>
+# Copyright (= C) 2016 Baptiste Daroussin
+# Copyright (C) 2024-2026 OpenVPN Inc <sales@...515...>=
#
# SPDX-License-Identifier: BSD-2-Clause
#
@@ -22,7 +22,7 @@
# dns_se= rver_1_port_2 53
# dns_server_1_resolve_domain_1 mycorp.= in
# dns_server_1_resolve_domain_2 eu.mycorp.com<= br>-# dns_server_1_dnssec true<= /span>
+# dns_server_1_dns= sec yes
# dns_server_1_transport DoH
# = dns_server_1_sni dns.mycorp.in
#
diff --= git a/distro/dns-scripts/resolvconf_file-dns-updown.sh b/distro/dns-scripts= /resolvconf_file-dns-updown.sh
index 70872c7..8d23ed6 10064= 4
--- a/distro/dns-scripts/resolvconf_file-dns-updown.sh
+++ b/distro/dns-scripts/resolvconf_file-dns-updown.sh=
@@ -1,7 +1,7 @@
#!/bin/sh
#
# Simple OpenVPN up/down script for modifying /etc/resolv.con= f
-# (C) Copyright 2024= OpenVPN Inc <sales@...515...>
+# Copyright (C) 2024-2026 OpenVPN Inc <sales@...515...&= gt;
#
# SPDX-License-Identifier: BSD-2-Cl= ause
#
@@ -21,7 +21,7 @@
= # dns_server_1_port_2 53
# dns_server_1_resolve_domain= _1 mycorp.in
# dns_server_1_resolve_domain_2 eu.mycorp.c= om
-# dns_server_1_dn= ssec true
+# dns_se= rver_1_dnssec yes
# dns_server_1_transport DoH # dns_server_1_sni dns.mycorp.in
#
diff --git a/distro/dns-scripts/systemd-dns-updown.sh b/distro/dns-scrip= ts/systemd-dns-updown.sh

index f91cde6..553056b 100644
--- a/distro/dns-scripts/systemd-dns-updown.sh
= +++ b/distro/dns-scripts/systemd-dns-updown.sh
@@ -29,7 +29= ,7 @@
# dns_server_1_port_2 53
# dns_= server_1_resolve_domain_1 mycorp.in
# dns_server_1_resol= ve_domain_2 eu.mycorp.com
-# dns_server_1_dnssec true
+# dns_server_1_dnssec yes
# dns_server_1_= transport DoH
# dns_server_1_sni dns.mycorp.in #

To view, visit change 1645. To un= subscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6832e3f56420debc8b19d0144d= 53ca41abb678b
Gerrit-Change-Number: 1645
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --7FZZrJmvujA=--