From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: Add sysfs files for returning VRAM/GTT info Date: Thu, 28 Feb 2019 16:56:03 +0100 Message-ID: References: <20190228153244.32641-1-kent.russell@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190228153244.32641-1-kent.russell-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Russell, Kent" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMjguMDIuMTkgdW0gMTY6MzIgc2NocmllYiBSdXNzZWxsLCBLZW50Ogo+IEFkZCAzIGZpbGVz IHRoYXQgcmV0dXJuOgo+IFRoZSB0b3RhbCBhbW91bnQgb2YgVlJBTSBhbmQgdGhlIGN1cnJlbnQg dG90YWwgdXNlZCBWUkFNCj4gVGhlIHRvdGFsIGFtb3VudCBvZiBWUkFNIGFuZCB0aGUgY3VycmVu dCB0b3RhbCB1c2VkIHZpc2libGUgVlJBTQo+IFRoZSB0b3RhbCBHVFQgc2l6ZSBhbmQgdGhlIGN1 cnJlbnQgdG90YWwgb2YgdXNlZCBHVFQKPgo+IEVhY2ggcmV0dXJucyAyIGludGVnZXJzLCB0b3Rh bCBhbmQgdXNlZCwgaW4gYnl0ZXMKCldlbGwgdGhhdCBpcyBhIGdvb2Qgc3RhcnQsIGJ1dCB1bmZv cnR1bmF0ZWx5IHZpb2xhdGVzIHRoZSBydWxlcyBmb3IgCnN5c2ZzLiBZb3UgbmVlZCB0byByZXR1 cm4gb25lIHZhbHVlIHBlciBmaWxlLgoKU28geW91IHNob3VsZCBjcmVhdGUgNiBmaWxlcyBpbiB0 b3RhbC4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBDaGFuZ2UtSWQ6IEkwYmQ3MDJiMTY2YjQy NTM4ODdlZjc2ZmIxYmJhOGI5YWFkYzdlMmM1Cj4gU2lnbmVkLW9mZi1ieTogS2VudCBSdXNzZWxs IDxrZW50LnJ1c3NlbGxAYW1kLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9ndHRfbWdyLmMgIHwgMzYgKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jIHwgNjcgKysrKysrKysrKysrKysrKysrKysK PiAgIDIgZmlsZXMgY2hhbmdlZCwgMTAzIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ3R0X21nci5jIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2d0dF9tZ3IuYwo+IGluZGV4IGRhN2IxYjkyZDljZi4uYWRm YTIxMWM1MTUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9ndHRfbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ3R0 X21nci5jCj4gQEAgLTM2LDYgKzM2LDMwIEBAIHN0cnVjdCBhbWRncHVfZ3R0X25vZGUgewo+ICAg CXN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqdGJvOwo+ICAgfTsKPiAgIAo+ICsvKioKPiArICog RE9DOiBtZW1faW5mb19ndHQKPiArICoKPiArICogVGhlIGFtZGdwdSBkcml2ZXIgcHJvdmlkZXMg YSBzeXNmcyBBUEkgZm9yIHJlcG9ydGluZyBjdXJyZW50IEdUVCBpbmZvcm1hdGlvbgo+ICsgKiBU aGUgZmlsZSBtZW1faW5mb19ndHQgaXMgdXNlZCBmb3IgdGhpcy4KPiArICogVGhlIGZpbGUgcmV0 dXJucyB0aGUgdG90YWwgc2l6ZSBvZiB0aGUgR1RUIGJsb2NrIGFuZCB0aGUgY3VycmVudCBhbW91 bnQgb2YKPiArICogdXNlZCBHVFQgYXMgMiBzZXBhcmF0ZSBpbnRlZ2VycywgaW4gYnl0ZXMKPiAr ICovCj4gK3N0YXRpYyBzc2l6ZV90IGFtZGdwdV9tZW1faW5mb19ndHRfc2hvdyhzdHJ1Y3QgZGV2 aWNlICpkZXYsCj4gKwkJc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsIGNoYXIgKmJ1ZikK PiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRkZXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsK PiArCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwl1 aW50NjRfdCB1c2VkX2d0dCwgdG90YWxfZ3R0Owo+ICsKPiArCXVzZWRfZ3R0ID0gYW1kZ3B1X2d0 dF9tZ3JfdXNhZ2UoJmFkZXYtPm1tYW4uYmRldi5tYW5bVFRNX1BMX1RUXSk7Cj4gKwl0b3RhbF9n dHQgPSAoYWRldi0+bW1hbi5iZGV2Lm1hbltUVE1fUExfVFRdLnNpemUpICogUEFHRV9TSVpFOwo+ ICsKPiArCXJldHVybiBzbnByaW50ZihidWYsIFBBR0VfU0laRSwgIiVsbHUgJWxsdVxuIiwKPiAr CQkJICAgICAgdG90YWxfZ3R0LCB1c2VkX2d0dCk7Cj4gK30KPiArCj4gK3N0YXRpYyBERVZJQ0Vf QVRUUihtZW1faW5mb19ndHQsIFNfSVJVR08sIGFtZGdwdV9tZW1faW5mb19ndHRfc2hvdywgTlVM TCk7Cj4gKwo+ICAgLyoqCj4gICAgKiBhbWRncHVfZ3R0X21ncl9pbml0IC0gaW5pdCBHVFQgbWFu YWdlciBhbmQgRFJNIE1NCj4gICAgKgo+IEBAIC01MCw2ICs3NCw3IEBAIHN0YXRpYyBpbnQgYW1k Z3B1X2d0dF9tZ3JfaW5pdChzdHJ1Y3QgdHRtX21lbV90eXBlX21hbmFnZXIgKm1hbiwKPiAgIAlz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGFtZGdwdV90dG1fYWRldihtYW4tPmJkZXYpOwo+ ICAgCXN0cnVjdCBhbWRncHVfZ3R0X21nciAqbWdyOwo+ICAgCXVpbnQ2NF90IHN0YXJ0LCBzaXpl Owo+ICsJaW50IHJldDsKPiAgIAo+ICAgCW1nciA9IGt6YWxsb2Moc2l6ZW9mKCptZ3IpLCBHRlBf S0VSTkVMKTsKPiAgIAlpZiAoIW1ncikKPiBAQCAtNjEsNiArODYsMTMgQEAgc3RhdGljIGludCBh bWRncHVfZ3R0X21ncl9pbml0KHN0cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+ICAg CXNwaW5fbG9ja19pbml0KCZtZ3ItPmxvY2spOwo+ICAgCWF0b21pYzY0X3NldCgmbWdyLT5hdmFp bGFibGUsIHBfc2l6ZSk7Cj4gICAJbWFuLT5wcml2ID0gbWdyOwo+ICsKPiArCXJldCA9IGRldmlj ZV9jcmVhdGVfZmlsZShhZGV2LT5kZXYsICZkZXZfYXR0cl9tZW1faW5mb19ndHQpOwo+ICsJaWYg KHJldCkgewo+ICsJCURSTV9FUlJPUigiRmFpbGVkIHRvIGNyZWF0ZSBkZXZpY2UgZmlsZSBtZW1f aW5mb19ndHRcbiIpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAgCXJldHVybiAwOwo+ ICAgfQo+ICAgCj4gQEAgLTc0LDEyICsxMDYsMTYgQEAgc3RhdGljIGludCBhbWRncHVfZ3R0X21n cl9pbml0KHN0cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAqbWFuLAo+ICAgICovCj4gICBzdGF0 aWMgaW50IGFtZGdwdV9ndHRfbWdyX2Zpbmkoc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICpt YW4pCj4gICB7Cj4gKwlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGFtZGdwdV90dG1fYWRl dihtYW4tPmJkZXYpOwo+ICAgCXN0cnVjdCBhbWRncHVfZ3R0X21nciAqbWdyID0gbWFuLT5wcml2 Owo+ICAgCXNwaW5fbG9jaygmbWdyLT5sb2NrKTsKPiAgIAlkcm1fbW1fdGFrZWRvd24oJm1nci0+ bW0pOwo+ICAgCXNwaW5fdW5sb2NrKCZtZ3ItPmxvY2spOwo+ICAgCWtmcmVlKG1ncik7Cj4gICAJ bWFuLT5wcml2ID0gTlVMTDsKPiArCj4gKwlkZXZpY2VfcmVtb3ZlX2ZpbGUoYWRldi0+ZGV2LCAm ZGV2X2F0dHJfbWVtX2luZm9fZ3R0KTsKPiArCj4gICAJcmV0dXJuIDA7Cj4gICB9Cj4gICAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYwo+IGluZGV4IDNm OWQ1ZDAwYzliMy4uZDBiYWRhOTk3Y2JhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV92cmFtX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMKPiBAQCAtMzIsNiArMzIsNTUgQEAgc3RydWN0IGFtZGdw dV92cmFtX21nciB7Cj4gICAJYXRvbWljNjRfdCB2aXNfdXNhZ2U7Cj4gICB9Owo+ICAgCj4gKy8q Kgo+ICsgKiBET0M6IG1lbV9pbmZvX3ZyYW0KPiArICoKPiArICogVGhlIGFtZGdwdSBkcml2ZXIg cHJvdmlkZXMgYSBzeXNmcyBBUEkgZm9yIHJlcG9ydGluZyBjdXJyZW50IFZSQU0gaW5mb3JtYXRp b24KPiArICogVGhlIGZpbGUgbWVtX2luZm9fdnJhbSBpcyB1c2VkIGZvciB0aGlzLgo+ICsgKiBU aGUgZmlsZSByZXR1cm5zIHRoZSB0b3RhbCBhbW91bnQgb2YgVlJBTSBhbmQgdGhlIGN1cnJlbnQg dG90YWwgYW1vdW50IG9mCj4gKyAqIHVzZWQgVlJBTSBhcyAyIHNlcGFyYXRlIGludGVnZXJzLCBp biBieXRlcwo+ICsgKi8KPiArc3RhdGljIHNzaXplX3QgYW1kZ3B1X21lbV9pbmZvX3ZyYW1fc2hv dyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIs IGNoYXIgKmJ1ZikKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRkZXYgPSBkZXZfZ2V0X2Ry dmRhdGEoZGV2KTsKPiArCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZGRldi0+ZGV2X3By aXZhdGU7Cj4gKwl1aW50NjRfdCB1c2VkX3ZyYW0sIHRvdGFsX3ZyYW07Cj4gKwo+ICsJdXNlZF92 cmFtID0gYW1kZ3B1X3ZyYW1fbWdyX3VzYWdlKCZhZGV2LT5tbWFuLmJkZXYubWFuW1RUTV9QTF9W UkFNXSk7Cj4gKwl0b3RhbF92cmFtID0gYWRldi0+Z21jLnJlYWxfdnJhbV9zaXplOwo+ICsKPiAr CXJldHVybiBzbnByaW50ZihidWYsIFBBR0VfU0laRSwgIiVsbHUgJWxsdVxuIiwgdG90YWxfdnJh bSwgdXNlZF92cmFtKTsKPiArfQo+ICsKPiArLyoqCj4gKyAqIERPQzogbWVtX2luZm9fdmlzX3Zy YW0KPiArICoKPiArICogVGhlIGFtZGdwdSBkcml2ZXIgcHJvdmlkZXMgYSBzeXNmcyBBUEkgZm9y IHJlcG9ydGluZyBjdXJyZW50IHZpc2libGUgVlJBTQo+ICsgKiBpbmZvcm1hdGlvbgo+ICsgKiBU aGUgZmlsZSBtZW1faW5mb192aXNfdnJhbSBpcyB1c2VkIGZvciB0aGlzLgo+ICsgKiBUaGUgZmls ZSByZXR1cm5zIHRoZSB0b3RhbCBhbW91bnQgb2YgVlJBTSBhbmQgdGhlIGN1cnJlbnQgdG90YWwg YW1vdW50IG9mCj4gKyAqIHVzZWQgdmlzaWJsZSBWUkFNIGFzIDIgc2VwYXJhdGUgaW50ZWdlcnMs IGluIGJ5dGVzCj4gKyAqLwo+ICtzdGF0aWMgc3NpemVfdCBhbWRncHVfbWVtX2luZm9fdmlzX3Zy YW1fc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJc3RydWN0IGRldmljZV9hdHRyaWJ1dGUg KmF0dHIsIGNoYXIgKmJ1ZikKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRkZXYgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiArCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gZGRldi0+ ZGV2X3ByaXZhdGU7Cj4gKwl1aW50NjRfdCB1c2VkX3Zpc192cmFtLCB0b3RhbF92cmFtOwo+ICsK PiArCXVzZWRfdmlzX3ZyYW0gPQo+ICsJCWFtZGdwdV92cmFtX21ncl92aXNfdXNhZ2UoJmFkZXYt Pm1tYW4uYmRldi5tYW5bVFRNX1BMX1ZSQU1dKTsKPiArCXRvdGFsX3ZyYW0gPSBhZGV2LT5nbWMu cmVhbF92cmFtX3NpemU7Cj4gKwo+ICsJcmV0dXJuIHNucHJpbnRmKGJ1ZiwgUEFHRV9TSVpFLCAi JWxsdSAlbGx1XG4iLAo+ICsJCQl0b3RhbF92cmFtLCB1c2VkX3Zpc192cmFtKTsKPiArfQo+ICsK PiArc3RhdGljIERFVklDRV9BVFRSKG1lbV9pbmZvX3ZyYW0sIFNfSVJVR08sIGFtZGdwdV9tZW1f aW5mb192cmFtX3Nob3csIE5VTEwpOwo+ICtzdGF0aWMgREVWSUNFX0FUVFIobWVtX2luZm9fdmlz X3ZyYW0sIFNfSVJVR08sIGFtZGdwdV9tZW1faW5mb192aXNfdnJhbV9zaG93LAo+ICsJCSAgIE5V TEwpOwo+ICsKPiAgIC8qKgo+ICAgICogYW1kZ3B1X3ZyYW1fbWdyX2luaXQgLSBpbml0IFZSQU0g bWFuYWdlciBhbmQgRFJNIE1NCj4gICAgKgo+IEBAIC00Myw3ICs5Miw5IEBAIHN0cnVjdCBhbWRn cHVfdnJhbV9tZ3Igewo+ICAgc3RhdGljIGludCBhbWRncHVfdnJhbV9tZ3JfaW5pdChzdHJ1Y3Qg dHRtX21lbV90eXBlX21hbmFnZXIgKm1hbiwKPiAgIAkJCQl1bnNpZ25lZCBsb25nIHBfc2l6ZSkK PiAgIHsKPiArCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gYW1kZ3B1X3R0bV9hZGV2KG1h bi0+YmRldik7Cj4gICAJc3RydWN0IGFtZGdwdV92cmFtX21nciAqbWdyOwo+ICsJaW50IHJldDsK PiAgIAo+ICAgCW1nciA9IGt6YWxsb2Moc2l6ZW9mKCptZ3IpLCBHRlBfS0VSTkVMKTsKPiAgIAlp ZiAoIW1ncikKPiBAQCAtNTIsNiArMTAzLDE5IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZyYW1fbWdy X2luaXQoc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4sCj4gICAJZHJtX21tX2luaXQo Jm1nci0+bW0sIDAsIHBfc2l6ZSk7Cj4gICAJc3Bpbl9sb2NrX2luaXQoJm1nci0+bG9jayk7Cj4g ICAJbWFuLT5wcml2ID0gbWdyOwo+ICsKPiArCS8qIEFkZCB0aGUgdHdvIFZSQU0tcmVsYXRlZCBz eXNmcyBmaWxlcyAqLwo+ICsJcmV0ID0gZGV2aWNlX2NyZWF0ZV9maWxlKGFkZXYtPmRldiwgJmRl dl9hdHRyX21lbV9pbmZvX3ZyYW0pOwo+ICsJaWYgKHJldCkgewo+ICsJCURSTV9FUlJPUigiRmFp bGVkIHRvIGNyZWF0ZSBkZXZpY2UgZmlsZSBtZW1faW5mb192cmFtXG4iKTsKPiArCQlyZXR1cm4g cmV0Owo+ICsJfQo+ICsJcmV0ID0gZGV2aWNlX2NyZWF0ZV9maWxlKGFkZXYtPmRldiwgJmRldl9h dHRyX21lbV9pbmZvX3Zpc192cmFtKTsKPiArCWlmIChyZXQpIHsKPiArCQlEUk1fRVJST1IoIkZh aWxlZCB0byBjcmVhdGUgZGV2aWNlIGZpbGUgbWVtX2luZm9fdmlzX3ZyYW1cbiIpOwo+ICsJCXJl dHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gQEAgLTY1LDYg KzEyOSw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3ZyYW1fbWdyX2luaXQoc3RydWN0IHR0bV9tZW1f dHlwZV9tYW5hZ2VyICptYW4sCj4gICAgKi8KPiAgIHN0YXRpYyBpbnQgYW1kZ3B1X3ZyYW1fbWdy X2Zpbmkoc3RydWN0IHR0bV9tZW1fdHlwZV9tYW5hZ2VyICptYW4pCj4gICB7Cj4gKwlzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldiA9IGFtZGdwdV90dG1fYWRldihtYW4tPmJkZXYpOwo+ICAgCXN0 cnVjdCBhbWRncHVfdnJhbV9tZ3IgKm1nciA9IG1hbi0+cHJpdjsKPiAgIAo+ICAgCXNwaW5fbG9j aygmbWdyLT5sb2NrKTsKPiBAQCAtNzIsNiArMTM3LDggQEAgc3RhdGljIGludCBhbWRncHVfdnJh bV9tZ3JfZmluaShzdHJ1Y3QgdHRtX21lbV90eXBlX21hbmFnZXIgKm1hbikKPiAgIAlzcGluX3Vu bG9jaygmbWdyLT5sb2NrKTsKPiAgIAlrZnJlZShtZ3IpOwo+ICAgCW1hbi0+cHJpdiA9IE5VTEw7 Cj4gKwlkZXZpY2VfcmVtb3ZlX2ZpbGUoYWRldi0+ZGV2LCAmZGV2X2F0dHJfbWVtX2luZm9fdnJh bSk7Cj4gKwlkZXZpY2VfcmVtb3ZlX2ZpbGUoYWRldi0+ZGV2LCAmZGV2X2F0dHJfbWVtX2luZm9f dmlzX3ZyYW0pOwo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2FtZC1nZng=